u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: tekkamanv@163.com
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	Jagan Teki <jagan@amarulasolutions.com>,
	 Vignesh R <vigneshr@ti.com>,
	tekkamanv@starfivetech.com, tekkamanninja@163.com,
	"yanhong.wang" <yanhong.wang@starfivetech.com>
Subject: Re: [PATCH] mtd: Add SPI Nor Flash chip GD25LQ256D ID
Date: Sat, 2 Oct 2021 22:15:27 +0800	[thread overview]
Message-ID: <CAEUhbmWDfJMB98QuJMGzCuSg6U7DOtVB505SAtMqWCyb2UXOUw@mail.gmail.com> (raw)
In-Reply-To: <20210930105329.438730-1-tekkamanv@163.com>

On Thu, Sep 30, 2021 at 6:55 PM <tekkamanv@163.com> wrote:
>
> From: "yanhong.wang" <yanhong.wang@starfivetech.com>
>

Please add a brief commit message for this, like providing a datasheet
for reference:

https://www.gigadevice.com/datasheet/gd25lq256d/

> Signed-off-by: yanhong.wang <yanhong.wang@starfivetech.com>

I believe the name should be spelled as "Yanhong Wang"

> ---
>  drivers/mtd/spi/spi-nor-ids.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index 4aef1ddd6e..35fa347c44 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -122,6 +122,11 @@ const struct flash_info spi_nor_ids[] = {
>                         SECT_4K | SPI_NOR_DUAL_READ |
>                         SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>         },
> +       {
> +               INFO("gd25lq256d", 0xc86019, 0, 64 * 1024, 512,
> +                       SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                       SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> +       },
>  #endif
>  #ifdef CONFIG_SPI_FLASH_ISSI           /* ISSI */
>         /* ISSI */

Otherwise LGTM:
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

  reply	other threads:[~2021-10-02 14:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-30 10:53 [PATCH] mtd: Add SPI Nor Flash chip GD25LQ256D ID tekkamanv
2021-10-02 14:15 ` Bin Meng [this message]
2021-10-08 12:58 ` Jagan Teki
2021-10-08 15:13   ` Bin Meng
2021-10-09  8:51     ` Jagan Teki
2021-09-30 11:53 tekkamanv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEUhbmWDfJMB98QuJMGzCuSg6U7DOtVB505SAtMqWCyb2UXOUw@mail.gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=jagan@amarulasolutions.com \
    --cc=tekkamanninja@163.com \
    --cc=tekkamanv@163.com \
    --cc=tekkamanv@starfivetech.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    --cc=yanhong.wang@starfivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).