Re: [PATCH 00/13] USB support for QCS404 SoC

From: Sumit Garg <sumit.garg@linaro.org>
To: u-boot@lists.denx.de
Cc: rfried.dev@gmail.com, jorge.ramirez.ortiz@gmail.com,
	sjg@chromium.org,  trini@konsulko.com, stephan@gerhold.net,
	mario.six@gdsys.cc,  dsankouski@gmail.com,
	robert.marko@sartura.hr, luka.kovacic@sartura.hr,
	 luka.perkov@sartura.hr, jh80.chung@samsung.com,
	nicolas.dechesne@linaro.org,  vinod.koul@linaro.org,
	mworsfold@impinj.com, lgillham@impinj.com,
	 daniel.thompson@linaro.org, pbrobinson@gmail.com
Subject: Re: [PATCH 00/13] USB support for QCS404 SoC
Date: Tue, 16 Aug 2022 13:39:14 +0530	[thread overview]
Message-ID: <CAFA6WYOYOm-3aj6bnz8LX7mr9vqWh1K3qroYh+UA2rq+xTitaQ@mail.gmail.com> (raw)
In-Reply-To: <20220804142721.536556-1-sumit.garg@linaro.org>

Hi,

On Thu, 4 Aug 2022 at 19:57, Sumit Garg <sumit.garg@linaro.org> wrote:
>
> This series add support for USB on QCS404 SoC. USB support have
> dependencies on PHY, reset and PMIC GPIO drivers, so corresponding
> support has been added. There are also some renaming/reorganising
> patches (#1, #3 and #9) which tries to generalize drivers support
> for Qcom SoCs.
> - Patch #1 moves all Qcom PHY drivers to drivers/phy/qcom/.
> - Patch #3 coverts ipq4019 reset driver to a generic Qcom reset driver.
> - Patch #9 Convert pm8916 driver to a generic Qcom PMIC driver.
>
> Sumit Garg (13):
>   phy: Move qcom SoCs specific phy drivers to qcom folder
>   phy: Add support for drivers to enable USB on QCS404 SoC
>   reset: Convert ipq4019 driver to a generic Qcom driver
>   reset: qcom: Add support for QCS404 SoC reset table
>   dts: qcs404-evb: Add reset controller node
>   clocks: qcom: Add clock enable callback support
>   clocks: qcs404: Add support for USB clocks
>   dts: qcs404-evb: Add USB controller and PHY nodes
>   pmic: Convert pm8916 driver to a generic Qcom PMIC driver
>   gpio: qcom_pmic: Add support for GPIO LV/MV subtype
>   dts: qcs404-evb: Add PMIC GPIO controller node
>   board: qcs404-evb: Enable USB3 specific PMIC GPIO
>   qcs404evb_defconfig: Enable USB configs
>

Gentle ping for any further review comments.

-Sumit

>  arch/arm/dts/qcs404-evb-uboot.dtsi            |   6 +
>  arch/arm/dts/qcs404-evb.dts                   | 118 ++++++
>  arch/arm/mach-snapdragon/clock-apq8016.c      |   5 +
>  arch/arm/mach-snapdragon/clock-apq8096.c      |   5 +
>  arch/arm/mach-snapdragon/clock-qcs404.c       |  40 ++
>  arch/arm/mach-snapdragon/clock-sdm845.c       |   5 +
>  arch/arm/mach-snapdragon/clock-snapdragon.c   |   7 +
>  .../include/mach/sysmap-qcs404.h              |  17 +
>  board/qualcomm/qcs404-evb/qcs404-evb.c        |  29 ++
>  configs/dragonboard410c_defconfig             |   4 +-
>  configs/dragonboard820c_defconfig             |   4 +-
>  configs/dragonboard845c_defconfig             |   4 +-
>  configs/qcs404evb_defconfig                   |  18 +
>  configs/sandbox64_defconfig                   |   4 +-
>  configs/sandbox_defconfig                     |   4 +-
>  configs/sandbox_flattree_defconfig            |   4 +-
>  configs/sandbox_noinst_defconfig              |   4 +-
>  configs/sandbox_spl_defconfig                 |   4 +-
>  configs/sandbox_vpl_defconfig                 |   4 +-
>  configs/starqltechn_defconfig                 |   4 +-
>  doc/device-tree-bindings/pmic/pm8916.txt      |  18 -
>  .../pmic/qcom,spmi-pmic.txt                   |  94 +++++
>  drivers/gpio/Kconfig                          |  10 +-
>  drivers/gpio/Makefile                         |   2 +-
>  drivers/gpio/pm8916_gpio.c                    | 303 ---------------
>  drivers/gpio/qcom_pmic_gpio.c                 | 359 ++++++++++++++++++
>  drivers/phy/Kconfig                           |  15 +-
>  drivers/phy/Makefile                          |   3 +-
>  drivers/phy/qcom/Kconfig                      |  29 ++
>  drivers/phy/qcom/Makefile                     |   4 +
>  drivers/phy/{ => qcom}/msm8916-usbh-phy.c     |   0
>  drivers/phy/{ => qcom}/phy-qcom-ipq4019-usb.c |   0
>  drivers/phy/qcom/phy-qcom-usb-hs-28nm.c       | 250 ++++++++++++
>  drivers/phy/qcom/phy-qcom-usb-ss.c            | 154 ++++++++
>  drivers/power/pmic/Kconfig                    |   8 +-
>  drivers/power/pmic/Makefile                   |   2 +-
>  drivers/power/pmic/{pm8916.c => pmic_qcom.c}  |  42 +-
>  drivers/reset/Kconfig                         |   9 +-
>  drivers/reset/Makefile                        |   2 +-
>  .../reset/{reset-ipq4019.c => reset-qcom.c}   |  76 +++-
>  40 files changed, 1254 insertions(+), 416 deletions(-)
>  delete mode 100644 doc/device-tree-bindings/pmic/pm8916.txt
>  create mode 100644 doc/device-tree-bindings/pmic/qcom,spmi-pmic.txt
>  delete mode 100644 drivers/gpio/pm8916_gpio.c
>  create mode 100644 drivers/gpio/qcom_pmic_gpio.c
>  create mode 100644 drivers/phy/qcom/Kconfig
>  create mode 100644 drivers/phy/qcom/Makefile
>  rename drivers/phy/{ => qcom}/msm8916-usbh-phy.c (100%)
>  rename drivers/phy/{ => qcom}/phy-qcom-ipq4019-usb.c (100%)
>  create mode 100644 drivers/phy/qcom/phy-qcom-usb-hs-28nm.c
>  create mode 100644 drivers/phy/qcom/phy-qcom-usb-ss.c
>  rename drivers/power/pmic/{pm8916.c => pmic_qcom.c} (52%)
>  rename drivers/reset/{reset-ipq4019.c => reset-qcom.c} (64%)
>
> --
> 2.25.1
>