From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6FC9DC433EF for ; Wed, 18 May 2022 04:44:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8791483DEF; Wed, 18 May 2022 06:44:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="cXa8r9OR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CB6B68426D; Wed, 18 May 2022 06:44:47 +0200 (CEST) Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [IPv6:2607:f8b0:4864:20::112a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8485083DE0 for ; Wed, 18 May 2022 06:44:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=judge.packham@gmail.com Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-2ff39b44b06so11370087b3.13 for ; Tue, 17 May 2022 21:44:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=NFW5iMQTc5GXDWVKLHLL4cgq+5hVQVK7m72Pg/C9N8E=; b=cXa8r9ORWihe4uRh875B7Z5Y61lQzuJv5/4urMNkuE50KeFpwuTbajaV9WEnuRGncg eTtPVBW6uofhxMfYvU+H4fhb4840cJI961ork91ntmWNvNEPfTNM83MOsY3R/N+URdIJ /QNJhdE776c1kPOTAdGbLVBgPYHMt2d3+ppESL7J1vbW/X73cMrUSsd11FQ0xPnb3Nx4 UehP2bMgcM6+H9Xd6b4uP8CQR5rSG34/cx/3vu+AZIX9LtbuOI5OLQ40FhhaqnknQeh9 FDiFA83YP59RJuKOvSWyoZiqistE41/AYd3uvvf/PTMMMag1xocT5XFr/Llj3lvf6F5D IL+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=NFW5iMQTc5GXDWVKLHLL4cgq+5hVQVK7m72Pg/C9N8E=; b=EwUlgtnBnumuUZtFKp1+2tzPV5Aw01gNWVyvkp7ylTexeKgHzXEqBYMRRdhsQ+we/E WrDTAzamLWnGI7Q9iKX3e3L4YfyfecSyU4Qg7LlqZ0HPQ9atfVfYQYkOfYlgwK3Y8sAY xM3VWNgFDuU2DgT52TtRLvhSrcJ5I8KJ7vwZb5XUcyYDUkmoe3rF/bYbLJ2uiDIa2JU6 30xQRYdLZ/jJ+zduPFUYAPxBdBQqrCgf9zd+1+kH7PNXp22Kx5LRJcu1MqjPq1BPgJVv c6yFH2MdF0r8ydUXhVQ8SMUgYliFEqhqtwrujYrY7BzD/F3EmffCTImr1TitQeB3BtrC g0Sw== X-Gm-Message-State: AOAM532QfdMcXxAolWV+/1xuen397do6TR3sboikp22RGtAAobvrV+c+ aSVewnK+Y+v6fw1FPZ9flSEB7SnRoGPLuHKZdDk= X-Google-Smtp-Source: ABdhPJzzaaxDK3VDZR8b5zY+x9VhCMEu3fVMvVX93ndTHxbPPhgy4+KkQccEplRzvfTmxLI69S+ugszHn0LvllANE2g= X-Received: by 2002:a0d:e811:0:b0:2ff:617:f52c with SMTP id r17-20020a0de811000000b002ff0617f52cmr12769049ywe.361.1652849083346; Tue, 17 May 2022 21:44:43 -0700 (PDT) MIME-Version: 1.0 References: <20211009132735.5173-1-kabel@kernel.org> <20211009132735.5173-4-kabel@kernel.org> In-Reply-To: <20211009132735.5173-4-kabel@kernel.org> From: Chris Packham Date: Wed, 18 May 2022 16:44:32 +1200 Message-ID: Subject: Re: [PATCH 4/4] Convert CONFIG_USB_EHCI_IS_TDI to Kconfig To: =?UTF-8?B?TWFyZWsgQmVow7pu?= Cc: Tom Rini , u-boot , Marek Vasut , Stefan Roese , =?UTF-8?B?TWFyZWsgQmVow7pu?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Marek, On Sun, Oct 10, 2021 at 2:28 AM Marek Beh=C3=BAn wrote: > > From: Marek Beh=C3=BAn > > On mvebu this is defined if and only if !ARM64. > I'm working on a 64-bit MVEBU board which I'll hopefully be submitting soon (just getting the Linux stuff sorted first). Was there any particular reason you added the !ARM64 ? My board appears to need CONFIG_USB_EHCI_IS_TDI=3Dy. I can make the condition more complicated if necessary but it might just be easier to remove the !ARM64. > Otherwise it is defined for boards with ARCH_MX23, ARCH_TEGRA and > ARCH_ZYNQ, and also for SOC_AR934X (tplink_wdr4300). > > Signed-off-by: Marek Beh=C3=BAn > --- > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig > index be5e4b994d..ccecb5a3b0 100644 > --- a/drivers/usb/host/Kconfig > +++ b/drivers/usb/host/Kconfig > @@ -139,6 +139,9 @@ config USB_EHCI_HCD > > if USB_EHCI_HCD > > +config USB_EHCI_IS_TDI > + bool > + > config USB_EHCI_ATMEL > bool "Support for Atmel on-chip EHCI USB controller" > depends on ARCH_AT91 > @@ -150,6 +153,7 @@ config USB_EHCI_MARVELL > bool "Support for Marvell on-chip EHCI USB controller" > depends on ARCH_MVEBU || ARCH_KIRKWOOD || ARCH_ORION5X > default y > + select USB_EHCI_IS_TDI if !ARM64 Here I'm thinking about something like if !ARM64 || ALLEYCAT_5 > ---help--- > Enables support for the on-chip EHCI controller on MVEBU SoCs.