From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F32E8C433EF for ; Tue, 28 Sep 2021 13:32:44 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 861FF60F9D for ; Tue, 28 Sep 2021 13:32:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 861FF60F9D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7AE368334E; Tue, 28 Sep 2021 15:32:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="I3/Oa4Su"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3E4298326F; Tue, 28 Sep 2021 15:32:07 +0200 (CEST) Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EBBBD8330B for ; Tue, 28 Sep 2021 15:32:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-ot1-x333.google.com with SMTP id o59-20020a9d2241000000b0054745f28c69so26859965ota.13 for ; Tue, 28 Sep 2021 06:32:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DmsQFWVGcyhB7ADhBVFegzvj5kaAQLEc5usia5YBLhc=; b=I3/Oa4SukeKMZOu/eBPZeSO04mISOPOfXifq+j2/ZB2+1jQHkcAx3rCBImNIGCExCM pmpK0FdSKaYOEUJm4GR7KdczhuEOSxw96M96EjF9A9phEITpAMt7HHcNsTgfzBzPbl/1 kBop+yCNXVz3M3WTjP2OSNuGERqhlNQbg6ftp4uVa1bjSBjDNGGBZdPpMNcFDSrej1Sz lWehA/bgqjOHo3HHzys//tCOAsPqnQsMOVgFWeeBMS/xxtyRDuHnYniILVyjx39x5M/7 wHIj8axuipTRyAlah+DV3L+7ZAhm6CbzIvoW/E/Ko00GmIY/LA3lQ0H3uoTsWAeZ7mAc pSaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DmsQFWVGcyhB7ADhBVFegzvj5kaAQLEc5usia5YBLhc=; b=A9e2VTOTLC1eMtePEXziRcdc3OjGcj/crnyJzWGHqMWJd65AbyMJmeOUDn/1bR92Wy HEW5AOxYlmkOeSMaHTqPvtxJMT0HXNvp24schQdb9CBvSD9FDka8Xm/3SmxvWCNIdG2M w6u0kkyCis2bl6yDOyOgPSlQYJsRjVAQFI54jbMrz1bNjwV7LrpG7SE0IxnurVMtdDiy PM+KBjF3WBldmponF1S9tcnthhUtLbkUNYeaXWkSnfGepObItQ6nJDj6z8O6nprDsw5U kUE6LoHh73+DjdWj/nL5OIvO1C31aTMla5gtqbtbJm3z6vm67FF6mz6o+E9BIQwWMcys 99dQ== X-Gm-Message-State: AOAM532wX0CqRsRs9x1db+47X2tw5dF9xWFzNT1zmKFOZLj/BTWeDm75 63IDWlvF8l5UUxxqEvLuBODePUtlmNb4VngfksbnVy8NLYACoQ== X-Google-Smtp-Source: ABdhPJyb0nebLtFJrs8YHvnZriJ9w3INt/qvG6xX06g/xsxYBIwolmYpjawg/I6NHq4oSStgKT060MdEBiX9VONmiwg= X-Received: by 2002:a9d:12ec:: with SMTP id g99mr4081234otg.197.1632835920755; Tue, 28 Sep 2021 06:32:00 -0700 (PDT) MIME-Version: 1.0 References: <20210927112205.301876-1-vladimir.oltean@nxp.com> <20210927112205.301876-6-vladimir.oltean@nxp.com> In-Reply-To: <20210927112205.301876-6-vladimir.oltean@nxp.com> From: Ramon Fried Date: Tue, 28 Sep 2021 16:31:49 +0300 Message-ID: Subject: Re: [PATCH 05/25] net: bcm-sf2: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation To: Vladimir Oltean Cc: U-Boot Mailing List , Joe Hershberger Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass MDIO_NAME_LEN - 1 and a > previously zero-initialized destination string, but this is more > difficult to maintain. > > The chosen alternative is to use strlcpy(), which properly limits the > copy len in the (srclen >= size) case to "size - 1", and which is also > more efficient than the strncpy() byte-by-byte implementation by using > memcpy. The destination string returned by strlcpy() is always NULL > terminated. > > Signed-off-by: Vladimir Oltean > --- > drivers/net/bcm-sf2-eth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bcm-sf2-eth.c b/drivers/net/bcm-sf2-eth.c > index c862c141461c..88dc3ab38466 100644 > --- a/drivers/net/bcm-sf2-eth.c > +++ b/drivers/net/bcm-sf2-eth.c > @@ -250,7 +250,7 @@ int bcm_sf2_eth_register(struct bd_info *bis, u8 dev_num) > > if (!mdiodev) > return -ENOMEM; > - strncpy(mdiodev->name, dev->name, MDIO_NAME_LEN); > + strlcpy(mdiodev->name, dev->name, MDIO_NAME_LEN); > mdiodev->read = eth->miiphy_read; > mdiodev->write = eth->miiphy_write; > > -- > 2.25.1 > Reviewed-by: Ramon Fried