From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F1A9C433EF for ; Tue, 28 Sep 2021 13:30:49 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED5D8611CA for ; Tue, 28 Sep 2021 13:30:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ED5D8611CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 103C98326F; Tue, 28 Sep 2021 15:30:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="bcdorPgu"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A4C038326F; Tue, 28 Sep 2021 15:30:28 +0200 (CEST) Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DBC068326F for ; Tue, 28 Sep 2021 15:30:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-ot1-x331.google.com with SMTP id c26-20020a056830349a00b0054d96d25c1eso2424236otu.9 for ; Tue, 28 Sep 2021 06:30:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2weB7ZoPGiybd1bbdj3eXpBRYS4IhJY1oC/utPinaO8=; b=bcdorPguPTQL642LBwGSJJMoikO+DOfTBn6++/X1d9faA43Ho/zUsyvVx2awxbVYrA KiYjODWNTCi3yEyKwNuRQTQ4v/cNMJxKoEa0IJ7gAyQ7I2IeiKItjsIabPR1a8IX53PG Te2uHX9XPmstwE/z0mjNUcbDQMZqtQnf6ehWAE5/VnON+qLunUMM2ihhSXK+bEDzmFtt xaBHzYaQU8sO7D8UWBpzkZRw54R8tCSfOgj6rQq1x+Slzhi/K/3eS5fwxRkzMgLLow9y +KjuO+u0yspmutbxGplZYdfdeKa+zTMzS4Ve0yVvAXZtAJ3FHeqKWgt1drXhpj+GSVzq nrFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2weB7ZoPGiybd1bbdj3eXpBRYS4IhJY1oC/utPinaO8=; b=tSfZpuO4k+ZGqK23/6xNNECS3kZWqydXw3feAThyLJLIrzUJdNhtFRWdMt7nthVZTI WUkNmms0jkPcuLBFzuAIioFMlv+yXDs8pzHyNsH84FihkgQWFRbkfXOoRtdPj8pdqVsV 0TPUakaP/Dl2zDN4F06zBBPIMmc7lSlLlE5vtvtQ2fLKXlOW6xyIjW1lQayfEU4IUiHD LPlFK1aXhOVUfm7bP6PnO3SkUS2QzVUAG7CZDEOoKj8ujSG3uGYILlmCbrten9rpwLom UC8JwdkPNc55Yy0D3pmO8xGGQ9nhdzoB5lt9mbUXhxyJR6CmCWTH62hAZfXg/FycBsSK mqxg== X-Gm-Message-State: AOAM531L9xytS4LqX/lDQDmr1w/ovoEYlUCBXqnQOBuVykf8fLUs51vN +iqZdf20b01v1TAUBG5rGRKFncljh9H7dpKmpRw= X-Google-Smtp-Source: ABdhPJzHPthv7sI9Arc8C/4FEOlfc8fUDeiKlSGjBz4SLfMNlsRbU5zh++EdOd2w5aak9Yd/Y1/13pC+s7n5Ffxjc6w= X-Received: by 2002:a9d:12ec:: with SMTP id g99mr4072877otg.197.1632835819116; Tue, 28 Sep 2021 06:30:19 -0700 (PDT) MIME-Version: 1.0 References: <20210918123237.1081530-1-vladimir.oltean@nxp.com> <20210918123237.1081530-4-vladimir.oltean@nxp.com> In-Reply-To: <20210918123237.1081530-4-vladimir.oltean@nxp.com> From: Ramon Fried Date: Tue, 28 Sep 2021 16:30:08 +0300 Message-ID: Subject: Re: [PATCH 3/4] net: enetc: remove support for "xgmii" phy-mode To: Vladimir Oltean Cc: U-Boot Mailing List , Joe Hershberger , Priyanka Jain , Madalin Bucur , Ioana Ciornei , Camelia Groza , Scott Wood , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Marcin Wojtas , Stefan Chulski Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sat, Sep 18, 2021 at 3:34 PM Vladimir Oltean wrote: > > The enetc driver runs only on NXP LS1028A, which most definitely does > not support the parallel 10G interface, just USXGMII, and that only up > to 2.5Gbps (toned down from 10 Gbps via symbol replication). > > Signed-off-by: Vladimir Oltean > --- > drivers/net/fsl_enetc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/fsl_enetc.c b/drivers/net/fsl_enetc.c > index 045527dcf7d9..f56f9e7a129b 100644 > --- a/drivers/net/fsl_enetc.c > +++ b/drivers/net/fsl_enetc.c > @@ -226,7 +226,6 @@ static void enetc_setup_mac_iface(struct udevice *dev, > case PHY_INTERFACE_MODE_RGMII_TXID: > enetc_init_rgmii(dev, phydev); > break; > - case PHY_INTERFACE_MODE_XGMII: > case PHY_INTERFACE_MODE_USXGMII: > case PHY_INTERFACE_MODE_10GBASER: > /* set ifmode to (US)XGMII */ > @@ -294,7 +293,6 @@ static void enetc_start_pcs(struct udevice *dev) > case PHY_INTERFACE_MODE_2500BASEX: > enetc_init_sgmii(dev); > break; > - case PHY_INTERFACE_MODE_XGMII: > case PHY_INTERFACE_MODE_USXGMII: > case PHY_INTERFACE_MODE_10GBASER: > enetc_init_sxgmii(dev); > -- > 2.25.1 > Reviewed-by: Ramon Fried