From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3335C6FD1D for ; Sat, 1 Apr 2023 18:48:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8100885DBD; Sat, 1 Apr 2023 20:48:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Pz3IicAy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id ADE0585C8A; Sat, 1 Apr 2023 20:48:53 +0200 (CEST) Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 69847859B1 for ; Sat, 1 Apr 2023 20:48:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-wm1-x333.google.com with SMTP id v6-20020a05600c470600b003f034269c96so5552141wmo.4 for ; Sat, 01 Apr 2023 11:48:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680374930; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MbK0DlnbQu9kg+wDBI+1cL6xgCeswkjJmoLYhyRt0Ks=; b=Pz3IicAyFfPmTw5ySaULO6BRb+uvtl6Q926lbGEc11ZIAYbffMFuJxVzVs4k1GYmUV ndyzQ5epsf0qzybIx2HTXlX4hJhwYAqWP7q79AyQy3cFZiG3WitsutUcbtvbWkv7A5cy NV8LmbFd+y/tfnwewzbSTZSP7vHD0zxeP7e78d9qWrqcOQcyIEGXPB2RGZqP1T3IszTE dmUYxa1NScB1n8Zz5DJMN2WB+qzgkXuA0nHqk35Ic6C7iQdbxH+aPhv19vf5XuDBjK1l rRP33pMKBzT4ehCb3qvnKNLpPc0ETO2rC8KLEImPb8hMUFLNkyaUddZsWN7/Gs1CNpXj UVng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680374930; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MbK0DlnbQu9kg+wDBI+1cL6xgCeswkjJmoLYhyRt0Ks=; b=Fy/q8jq+MBDHKYlCuwqCXWvGCrBrgJ5igItdCam0gcZVsQXVxuI6q8GvhO29ovNfD8 LYtiAT1QvqRE3R7zC0Q29Ec25zk0bQsNYP7lQdsDG5fJHhNUTCsIkMKHCwLo70JnrtT2 QeBwRM01/7oJfEwB4UGx3KFRjsg02fTYEU1BYdzFlZ1i4W1R1dg2i6oRIMYLMdmArMXK nuYIeHMYoocGEp1g/r68kE1iuQ8aWAGpqSm88gESDQ+tsIZl9/tF5Fc1slhXEzkE8IGV ihoHQ4mqJMozisv/M6HOBvaXMbsXS2IIjBMdf4rc5oiJ4O8C0jETsXsDW43rcA+R+8fN cWmQ== X-Gm-Message-State: AAQBX9fQHn07eEndJPerkLzKM9MulYXMgW652KHJwzZ+x4tpOG2pJ+3w E4ldA4Ztd5OIQW9I7LqjFZ7R3y0vVLz05lZdgHM= X-Google-Smtp-Source: AKy350beXV7cbeUDVVu/is/fD6UU7UDmoH/QCZVSm6UOwcE9HvEXbuEcZ0t01XtD89mZ/SZux9J5cLNweI+vXV/IQ2A= X-Received: by 2002:a7b:cd93:0:b0:3ed:f966:b278 with SMTP id y19-20020a7bcd93000000b003edf966b278mr3237739wmj.0.1680374929850; Sat, 01 Apr 2023 11:48:49 -0700 (PDT) MIME-Version: 1.0 References: <20230319170647.28149-1-marek.vasut+renesas@mailbox.org> <20230319170647.28149-2-marek.vasut+renesas@mailbox.org> In-Reply-To: <20230319170647.28149-2-marek.vasut+renesas@mailbox.org> From: Ramon Fried Date: Sat, 1 Apr 2023 21:48:38 +0300 Message-ID: Subject: Re: [PATCH 2/3] net: mvpp2: Replace PHY_INTERFACE_MODE_SFI with 5GBASER/10GBASER/XAUI To: Marek Vasut Cc: u-boot@lists.denx.de, "Ariel D'Alessandro" , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Joe Hershberger , Stefan Roese , Tim Harvey , Vladimir Oltean Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Sun, Mar 19, 2023 at 7:07=E2=80=AFPM Marek Vasut wrote: > > Replace PHY_INTERFACE_MODE_SFI with PHY_INTERFACE_MODE_5GBASER, > PHY_INTERFACE_MODE_10GBASER and PHY_INTERFACE_MODE_XAUI to match > Linux PHY interface modes. > > Signed-off-by: Marek Vasut > --- > Cc: "Ariel D'Alessandro" > Cc: "Marek Beh=C3=BAn" > Cc: Joe Hershberger > Cc: Marek Vasut > Cc: Ramon Fried > Cc: Stefan Roese > Cc: Tim Harvey > Cc: Vladimir Oltean > --- > drivers/net/mvpp2.c | 8 ++++++-- > include/phy_interface.h | 2 ++ > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c > index 71347b7e69c..096b8a35853 100644 > --- a/drivers/net/mvpp2.c > +++ b/drivers/net/mvpp2.c > @@ -3438,7 +3438,9 @@ static int gop_port_init(struct mvpp2_port *port) > gop_gmac_reset(port, 0); > break; > > - case PHY_INTERFACE_MODE_SFI: > + case PHY_INTERFACE_MODE_10GBASER: > + case PHY_INTERFACE_MODE_5GBASER: > + case PHY_INTERFACE_MODE_XAUI: > num_of_act_lanes =3D 2; > mac_num =3D 0; > /* configure PCS */ > @@ -3489,7 +3491,9 @@ static void gop_port_enable(struct mvpp2_port *port= , int enable) > mvpp2_port_disable(port); > break; > > - case PHY_INTERFACE_MODE_SFI: > + case PHY_INTERFACE_MODE_10GBASER: > + case PHY_INTERFACE_MODE_5GBASER: > + case PHY_INTERFACE_MODE_XAUI: > gop_xlg_mac_port_enable(port, enable); > > break; > diff --git a/include/phy_interface.h b/include/phy_interface.h > index fed3357b9a2..52af7e612b6 100644 > --- a/include/phy_interface.h > +++ b/include/phy_interface.h > @@ -31,6 +31,7 @@ typedef enum { > PHY_INTERFACE_MODE_XGMII, > PHY_INTERFACE_MODE_XAUI, > PHY_INTERFACE_MODE_RXAUI, > + PHY_INTERFACE_MODE_5GBASER, > PHY_INTERFACE_MODE_SFI, > PHY_INTERFACE_MODE_INTERNAL, > PHY_INTERFACE_MODE_25G_AUI, > @@ -62,6 +63,7 @@ static const char * const phy_interface_strings[] =3D { > [PHY_INTERFACE_MODE_XGMII] =3D "xgmii", > [PHY_INTERFACE_MODE_XAUI] =3D "xaui", > [PHY_INTERFACE_MODE_RXAUI] =3D "rxaui", > + [PHY_INTERFACE_MODE_5GBASER] =3D "5gbase-r", > [PHY_INTERFACE_MODE_SFI] =3D "sfi", > [PHY_INTERFACE_MODE_INTERNAL] =3D "internal", > [PHY_INTERFACE_MODE_25G_AUI] =3D "25g-aui", > -- > 2.39.2 > Reviewed-by: Ramon Fried