From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A68EC19F2D for ; Sun, 7 Aug 2022 00:16:42 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 55F93841B0; Sun, 7 Aug 2022 02:16:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="E7yXyPg8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DA93A84377; Sun, 7 Aug 2022 02:16:38 +0200 (CEST) Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B11ED8415E for ; Sun, 7 Aug 2022 02:16:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-wm1-x330.google.com with SMTP id 186-20020a1c02c3000000b003a34ac64bdfso3388139wmc.1 for ; Sat, 06 Aug 2022 17:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=07bhBRxWZyQC9fP8RGgb6kRPNoe0xd+pdoUAWDw24lo=; b=E7yXyPg8b4ydTzByl4vwAwpthkD8WBT1jljYlLbHG2C0W56KP4m/qBQIvju3KSIgzJ UXxmdBwlTEnrUwCeqv8bz5xZnIY2MVYBEA1nUYljecRrlVvB12lbxZ5Ac5NuOrz0Hf0Y Y/SzAAirH5Mt/GbAYe6Cj97VQlsWh+ZxIw/nGADHQnN2zJKuYx96jSgLG8aIwmxhqCRA 200JmjzH2COt4SYjRj+iOHtkib44cBYsv7s2Yjd5N4hnAnr1PfRnluKxSo33ePAEqnYH LVJJifJUowOlnKJlDF5MvnARjbNJ3FsSg8MFav7vhYChWtY7obDViRY5nNW+T1+iBpmo 8r6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=07bhBRxWZyQC9fP8RGgb6kRPNoe0xd+pdoUAWDw24lo=; b=mnurznFK6FpnlFZjFe2Ab8uMEM7RgUc+USVP5if4xiUo9fBfliwdKaxdwuj9CJf2/n v6S52WUDmskfxjPdLN/D4/4WT4g7r9d5wewpG09LYyr+gx/aLytwNnbgE++C7LRgAOVt na3WN9CUEsAYZS9FN/O2oXovgiuQ4bMTnPr1bN9tS37Udh0p6PJCNrPxRqpLXidLoGRN Sn3na0YAicMxErMr6AKa/E19YaUnrLn/Rm40iogaxM4KRx9/3C9dtBKe9p3vCa5Vua0l U+htRSgTdW25JRULw+36zYuqXi6IltGoxUZz8UXpwIt7MLS8xaXQvP9YB/4yzNwnKlk1 Uvaw== X-Gm-Message-State: ACgBeo13H1UAA0GDI9BQk8h0zcQiyBAGkUy/6jl3PMi35p96bgPAA3VH C3ODg3Dc5/qbMw1X6X9vP1OIiDldFSacQ/0NQMA= X-Google-Smtp-Source: AA6agR7Wtqu06PYOjS004ZxAufvVT3+JjsRcZnC2MAzu2L7kou5/neXBYeBO5Fkt5xI4EPCGylXi+YEeQ4rGkF7Shnw= X-Received: by 2002:a05:600c:4e08:b0:3a3:55d9:fd52 with SMTP id b8-20020a05600c4e0800b003a355d9fd52mr8616279wmq.148.1659831396067; Sat, 06 Aug 2022 17:16:36 -0700 (PDT) MIME-Version: 1.0 References: <20220727082204.3677784-1-sumit.garg@linaro.org> <20220727082204.3677784-2-sumit.garg@linaro.org> In-Reply-To: <20220727082204.3677784-2-sumit.garg@linaro.org> From: Ramon Fried Date: Sun, 7 Aug 2022 03:16:24 +0300 Message-ID: Subject: Re: [PATCH v2 1/2] pinctrl: sdm845: Remove redundant CONFIG_SDM845 check To: Sumit Garg Cc: U-Boot Mailing List , Robert Marko , luka.kovacic@sartura.hr, luka.perkov@sartura.hr, =?UTF-8?B?0JTQvNC40YLRgNC40Lkg0KHQsNC90LrQvtCy0YHQutC40Lk=?= , Stephan Gerhold , Simon Glass , Tom Rini , Nicolas Dechesne , vinod.koul@linaro.org, mworsfold@impinj.com, Daniel Thompson , Peter Robinson Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Wed, Jul 27, 2022 at 11:22 AM Sumit Garg wrote: > > DT compatible is sufficient to make platform specific differentiation, > so remove redundant CONFIG_SDM845 check. > > Signed-off-by: Sumit Garg > --- > arch/arm/mach-snapdragon/Makefile | 2 +- > arch/arm/mach-snapdragon/pinctrl-snapdragon.c | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/arm/mach-snapdragon/Makefile b/arch/arm/mach-snapdragon/Makefile > index 0d31f10f68..cbaaf23f6b 100644 > --- a/arch/arm/mach-snapdragon/Makefile > +++ b/arch/arm/mach-snapdragon/Makefile > @@ -16,6 +16,6 @@ obj-y += pinctrl-snapdragon.o > obj-y += pinctrl-apq8016.o > obj-y += pinctrl-apq8096.o > obj-y += pinctrl-qcs404.o > -obj-$(CONFIG_SDM845) += pinctrl-sdm845.o > +obj-y += pinctrl-sdm845.o > obj-$(CONFIG_TARGET_QCS404EVB) += clock-qcs404.o > obj-$(CONFIG_TARGET_QCS404EVB) += sysmap-qcs404.o > diff --git a/arch/arm/mach-snapdragon/pinctrl-snapdragon.c b/arch/arm/mach-snapdragon/pinctrl-snapdragon.c > index c2148a5d0a..842e2da0c5 100644 > --- a/arch/arm/mach-snapdragon/pinctrl-snapdragon.c > +++ b/arch/arm/mach-snapdragon/pinctrl-snapdragon.c > @@ -116,9 +116,7 @@ static struct pinctrl_ops msm_pinctrl_ops = { > static const struct udevice_id msm_pinctrl_ids[] = { > { .compatible = "qcom,tlmm-apq8016", .data = (ulong)&apq8016_data }, > { .compatible = "qcom,tlmm-apq8096", .data = (ulong)&apq8096_data }, > -#ifdef CONFIG_SDM845 > { .compatible = "qcom,tlmm-sdm845", .data = (ulong)&sdm845_data }, > -#endif > { .compatible = "qcom,tlmm-qcs404", .data = (ulong)&qcs404_data }, > { } > }; > -- > 2.25.1 > Reviewed-by: Ramon Fried