From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92494C433FE for ; Tue, 28 Sep 2021 13:34:32 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07D4960F9D for ; Tue, 28 Sep 2021 13:34:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 07D4960F9D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 081D683340; Tue, 28 Sep 2021 15:34:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="KXvDyIXQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1CC2F83304; Tue, 28 Sep 2021 15:33:31 +0200 (CEST) Received: from mail-oo1-xc29.google.com (mail-oo1-xc29.google.com [IPv6:2607:f8b0:4864:20::c29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 64DCD83325 for ; Tue, 28 Sep 2021 15:32:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-oo1-xc29.google.com with SMTP id j11-20020a4a92cb000000b002902ae8cb10so7136266ooh.7 for ; Tue, 28 Sep 2021 06:32:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JTTYTqSK8OaW+rtmGTjbcbO+l+bXhw615i2aEUkRo7g=; b=KXvDyIXQuCs/NwgsOO4YitqMtyRgbrVVGAnafaUF/S27/TPs4nyXwoX4kSy64fYYvl ddVYR7QcceEsYjI/tfKcck11n5ALsOdFyT8Wl5SiyVuHfrMU8eiRYduWcIPWUPhMEKcu 0hy+CoHV3JiIOjc2mC1aBJDQd389Wc8EHo8ShJAOp8f7NR3iJka4K2C3wA45lPNE2c+3 tQ/kdAHm6EbmNp+yaqYf8jCfqaqzv/5fTOvRBP6RwNfhwrmHwiUBnO+LJgaAX10ZmKuk 21irgK4/hdvcsII2yHRt18LfXWKyF03iGyHgOe2Hzfbtlb2DeblQ3RNevhBWRtMSVpMi qMfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JTTYTqSK8OaW+rtmGTjbcbO+l+bXhw615i2aEUkRo7g=; b=czkUNdvlMWgU0LikV/tMrlivYpAYyOGQIxW0nM2QptHjKrLgY6QA1i3iwM0b3JDIsd JIFCxJg1tMQlXbfY0e9LjTxiqgHdTEdJZ/UKJfXn5wBUVWA4h+Pgpdr/5tfZTyZk78Ol 6d195/I+ej6rq7VflX1GrXIOAu9WqV7x259QF/8G0peA0Zx/KHYpHfz3VQ4z0zQKbx+j rhOnnxVY3ZyWAMEXokOimQarwMYrYPXj2uBKlSicJOdfKL3NO2D1RKOewsbZImEUbKt1 gvjQNWQJ/rZDlyUMGQnZVteh1cv2KX5VTNmttfEaT8AwPFQygD+MkJnFZJxZvyrSBv9L UzOA== X-Gm-Message-State: AOAM532GuOISlWQ2+g1mgxfD1P6ttfZvxTccD3dx1t9frKX/num4Aml+ CoKcsuSj5x0AOZLhqvVStIKGEB49dQ2SlZ+Tnw4= X-Google-Smtp-Source: ABdhPJwn2kSqTEpb207dFId0oxBeZWAwDCFBkrnWukTdE7s8isWeYUfqKYmyuX0CZwwxL4f7MaNrhT0wr7Bi3YH6QbQ= X-Received: by 2002:a05:6820:1018:: with SMTP id v24mr5050647oor.27.1632835969938; Tue, 28 Sep 2021 06:32:49 -0700 (PDT) MIME-Version: 1.0 References: <20210927112205.301876-1-vladimir.oltean@nxp.com> <20210927112205.301876-12-vladimir.oltean@nxp.com> In-Reply-To: <20210927112205.301876-12-vladimir.oltean@nxp.com> From: Ramon Fried Date: Tue, 28 Sep 2021 16:32:38 +0300 Message-ID: Subject: Re: [PATCH 11/25] net: lpc32xx: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation To: Vladimir Oltean Cc: U-Boot Mailing List , Joe Hershberger Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass MDIO_NAME_LEN - 1 and a > previously zero-initialized destination string, but this is more > difficult to maintain. > > The chosen alternative is to use strlcpy(), which properly limits the > copy len in the (srclen >= size) case to "size - 1", and which is also > more efficient than the strncpy() byte-by-byte implementation by using > memcpy. The destination string returned by strlcpy() is always NULL > terminated. > > Signed-off-by: Vladimir Oltean > --- > drivers/net/lpc32xx_eth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/lpc32xx_eth.c b/drivers/net/lpc32xx_eth.c > index 3f281a515c6a..1a5734343935 100644 > --- a/drivers/net/lpc32xx_eth.c > +++ b/drivers/net/lpc32xx_eth.c > @@ -638,7 +638,7 @@ int lpc32xx_eth_initialize(struct bd_info *bis) > struct mii_dev *mdiodev = mdio_alloc(); > if (!mdiodev) > return -ENOMEM; > - strncpy(mdiodev->name, dev->name, MDIO_NAME_LEN); > + strlcpy(mdiodev->name, dev->name, MDIO_NAME_LEN); > mdiodev->read = mii_reg_read; > mdiodev->write = mii_reg_write; > > -- > 2.25.1 > Reviewed-by: Ramon Fried