From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F47FC433EF for ; Tue, 28 Sep 2021 13:37:30 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CEEA860FE8 for ; Tue, 28 Sep 2021 13:37:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CEEA860FE8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8992583221; Tue, 28 Sep 2021 15:36:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="BQK7p1n3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 763B783143; Tue, 28 Sep 2021 15:35:38 +0200 (CEST) Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 656398334E for ; Tue, 28 Sep 2021 15:34:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-oi1-x22d.google.com with SMTP id w206so30025462oiw.4 for ; Tue, 28 Sep 2021 06:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2acFQM+eQfXryWXYsTvwPD5ebRaOuBzmUZXuuedFNvU=; b=BQK7p1n3oBYHLpkTkOWRlZ0M+q071ELUYJ9fNBWvhds4l3cMcyGlgi5MNtRN71BvSf Ztj8t1lS/8uTWZgTRaP9RNrvoCP9ayP7zJrl03wdoaq11SwENcmsjjmXEsbdKU8ugoH8 to5mnlQMrOsYer1bK5ju5ALCwuMid9hwahmIbxEW4y0+s/TMMqvS9ufoQ3UwAFocSEEr ZN9j8vvX+ZcXbDBKgkvk9KN17pPnfcL5D0GenVuawRqD0OfcTRG0H89EzEPLUHNq19BU fOtAdj6RhFlbzMSmO22NfsDDAFgANK8K5GvdATZUA8VWweZz1c1AuLPagLu17ZE43GTe 9tow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2acFQM+eQfXryWXYsTvwPD5ebRaOuBzmUZXuuedFNvU=; b=a3n4J/df1e/2DUzRPESm5lOsFWxcIRddd6LNFVO9ASn5NbUs8wmJbOBFEsLwnYKzmr rEK4E6Uc54W9wqrnkA8AevIujWY+YB067TeUOqtsLXzMVJrfhOJELNjNgFqf1i+LXbJE 9YpC95AMrKx7WvMKIVUtjFHaoB51m48U2bQhdcUSr1kS/k5nMQUzKdBl0KjRo4wA+5+J aA1uVVdc12CKhMmMrSHqg5Iu0XDvHxRrjIJ8haudonVbzMNXA+b9Q/ckb7kGlSHHadO/ 12R2TKTd4RScN5LwrCUVm98B4lOaq9UCRuCocQEL0MTDy7MGrXVkgc+BpeMWfQncnp75 VITw== X-Gm-Message-State: AOAM5329p5l0YP45WqcRPKNm9cfWW9f7snUdokd2+PRt3+VXB10YKEZA NCwKdh4PNlWpgJ+I8b2ZmboFf+eziqTPHfIv8z++SFgt49r9Lg== X-Google-Smtp-Source: ABdhPJxNzuu9dh6xXg5hhURxk7yYmqJCYgoRsg3T05cZjvD7scBP22gdZv3GHsyorl1Sltf1TZVpW1JfkNsH3cfmxE4= X-Received: by 2002:a05:6808:bd1:: with SMTP id o17mr3709863oik.92.1632836043140; Tue, 28 Sep 2021 06:34:03 -0700 (PDT) MIME-Version: 1.0 References: <20210927112205.301876-1-vladimir.oltean@nxp.com> <20210927112205.301876-23-vladimir.oltean@nxp.com> In-Reply-To: <20210927112205.301876-23-vladimir.oltean@nxp.com> From: Ramon Fried Date: Tue, 28 Sep 2021 16:33:51 +0300 Message-ID: Subject: Re: [PATCH 22/25] net: dsa: felix: check return code of mdio_alloc and mdio_register To: Vladimir Oltean Cc: U-Boot Mailing List , Joe Hershberger Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > These functions can return errors, it's best to catch them and trigger > the driver unwind code path. > > Signed-off-by: Vladimir Oltean > --- > drivers/net/mscc_eswitch/felix_switch.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/mscc_eswitch/felix_switch.c b/drivers/net/mscc_eswitch/felix_switch.c > index 4c2e57755967..98ae39e81d65 100644 > --- a/drivers/net/mscc_eswitch/felix_switch.c > +++ b/drivers/net/mscc_eswitch/felix_switch.c > @@ -276,6 +276,7 @@ static void felix_init(struct udevice *dev) > static int felix_probe(struct udevice *dev) > { > struct felix_priv *priv = dev_get_priv(dev); > + int err; > > if (ofnode_valid(dev_ofnode(dev)) && > !ofnode_is_available(dev_ofnode(dev))) { > @@ -300,11 +301,18 @@ static int felix_probe(struct udevice *dev) > struct mii_dev *mii_bus; > > mii_bus = mdio_alloc(); > + if (!mii_bus) > + return -ENOMEM; > + > mii_bus->read = felix_mdio_read; > mii_bus->write = felix_mdio_write; > mii_bus->priv = priv->imdio_base + FELIX_PM_IMDIO_BASE; > strlcpy(mii_bus->name, dev->name, MDIO_NAME_LEN); > - mdio_register(mii_bus); > + err = mdio_register(mii_bus); > + if (err) { > + mdio_free(mii_bus); > + return err; > + } > } > > dm_pci_clrset_config16(dev, PCI_COMMAND, 0, PCI_COMMAND_MEMORY); > -- > 2.25.1 > Reviewed-by: Ramon Fried