From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0D05C433F5 for ; Wed, 5 Oct 2022 02:09:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DE52484E09; Wed, 5 Oct 2022 04:09:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kXiJppwC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E755984E09; Wed, 5 Oct 2022 04:09:34 +0200 (CEST) Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1BC5484E02 for ; Wed, 5 Oct 2022 04:09:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-pf1-x434.google.com with SMTP id f140so9413502pfa.1 for ; Tue, 04 Oct 2022 19:09:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=vUzxOdiOL4EZ29A8NTipltbxs9kgzcyX122u2BtOQKM=; b=kXiJppwCwxhDWI2lM6/v7qhfZo8W3DEZjoM+Squf+Y4LS6xk4UcrPu5ClTrrIhszKz 9G4rWjEv2DLrriswJEBIc7S0Q7dvUr6FLmxEr0i4N+O7kR35l7Gr9orAnnyJcri8zqt2 AFKOLCS1ZzyTp3cLC8pp+5R2vF67ofzMLztWEgfbHyTIR5rpIaGDY+l64wUzlrtuS3wA iOx5U16gv6tM61QqI2A7LIafntBEMF08QPlriTmamuNpSvLE70343+p/PuzdkOY6EzWN rKSGkx/W4MFISmBsRc5zKAjgJvM92orcUow7Fbar7miCyJ0DmR447tFCOE0zPaS4Qrv4 daDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=vUzxOdiOL4EZ29A8NTipltbxs9kgzcyX122u2BtOQKM=; b=tihGkvlfxmSxzx1eK1OWhsnQt9n3BbXOWTpt1cUt1sPIWYXHFsETNRsF1IePOshms6 FeF3fFLPByLzstarmkaDA7NMV/XMgH/JuP3E6Vo8aDeEr3KVYEbkQpetLE5PxjH0ukbA E9MIrZqzDPmKh+tTLyV27fBJ0fAG9ryycxbstHVkZr2sg7PXq5T2Lvvxiw7+plXweIyp 6uGxHXLww4xanm7fB7jRE8VMpCG7OsI8gygBf4Bh9bn6jgJ7aJizfnSkTRF+oWljRGK5 ++Tu/nx5nOBATXtSpthDN+R9Dm7oi8VzW3McNWx+ECa+x5iVZWnY7F7EhnFZ5nyI22p2 kFfA== X-Gm-Message-State: ACrzQf3D7M4glqgLnVWY5fs9/o++JEIw6zIShR2si+EsXPg3UbH4T1oF bIrtS3p2rXhn1PArtLRyEdkxDy+dx9TEVLXVgZM= X-Google-Smtp-Source: AMsMyM69tjo8SJzoUAucdrK+7+jIpUzYmNvw2SWWC/dOlmlfI7+x9mzkF8qjRMQTlyaY2dZbBwZG3j2ppIwKXsWg+gM= X-Received: by 2002:a05:6a00:8cb:b0:52c:6962:2782 with SMTP id s11-20020a056a0008cb00b0052c69622782mr30611252pfu.81.1664935770442; Tue, 04 Oct 2022 19:09:30 -0700 (PDT) MIME-Version: 1.0 References: <20220713135204.233268-1-samuel.obuch@codasip.com> <20220713135204.233268-3-samuel.obuch@codasip.com> <44ac0918-fc12-88a9-f25e-9fab1510c73f@amd.com> <3d97da3d-3b5f-de6f-dbe0-1760ae834a6b@amd.com> In-Reply-To: <3d97da3d-3b5f-de6f-dbe0-1760ae834a6b@amd.com> From: Ramon Fried Date: Wed, 5 Oct 2022 05:09:19 +0300 Message-ID: Subject: Re: [PATCH 2/3] net: emaclite: fix xemaclite_alignedread/write functions To: Michal Simek Cc: Samuel Obuch , Jan Remes , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Fri, Sep 23, 2022 at 12:36 PM Michal Simek wrote: > > Hi, > > On 9/23/22 11:17, Samuel Obuch wrote: > > Hi, I tested both versions to be sure, but the results are as can be expected: > > > > 1. both __raw_readl/__raw_writel and readl/writel functions work ok on riscv - > > only the original nonvolatile accesses were problematic > > 2. the additional barrier in readl/writel functions can introduce noticeable > > slowdown - e.g. with our setup, download speed over tftp for the same image > > decreased from 460 KiB/s to 118 KiB/s > > > > Can we conclude to keep the raw versions in the patch? > > I prefer raw versions too. > > Let's keep it raw.