From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A809CC433F5 for ; Sat, 30 Oct 2021 13:32:10 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41442603E8 for ; Sat, 30 Oct 2021 13:32:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 41442603E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 83A2681BF4; Sat, 30 Oct 2021 15:32:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="mBAkt2Pn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8EABB833D8; Sat, 30 Oct 2021 15:32:04 +0200 (CEST) Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A223B8187B for ; Sat, 30 Oct 2021 15:32:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-oi1-x235.google.com with SMTP id x8so13330676oix.2 for ; Sat, 30 Oct 2021 06:32:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CtfwAmpusB4aZ2dfTAF/4kaPTvXEsHJTggOBWV1lYWo=; b=mBAkt2PnLGbAtHC+CzPAEcGY7reaJN+J1Xt3hRrqgTQAZq9ONBQQmcXXOOMEbmzi+O 0Au9MbruCZahszuLN747JNlbRIlPyobqe/uQjUiPs6yfs3KX3cKCSdlbBwQ4OnGFirIP ISdRcyUO7+CAhkRYRlzcX2SW7IhPXwBCUWFEM3RkyLd/pCzJuOxz/fNDLkEr9AkcF0yg Z5Our4DucnlOphWwzM6/yRbHLrFJw0guMfNGqEkflTbNY5VJYR+KNqK72VhrxFxuEQ1A i+zhBIYRukad5AJSFQ02cesvtowdd2yMn3Y3MxrFeXKTA1F+7V9W6vcPusbvG+xtRyKB bXNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CtfwAmpusB4aZ2dfTAF/4kaPTvXEsHJTggOBWV1lYWo=; b=k62q5eaO5tSPmpnDNZ71E0Wn7UafpogJmvEniZXH3uRejLxh5D9AKQRR52GiBn6Woo +Y5W5sSvhTzKLQi6vPeQEinUjuWRXkkmvTZ8mrMGPtFqTlyt6cY4C8Vuy4OPG0JfGarT /CTnmdxVc9xDfl2sM9t7QNfQSjbMODr7EYnnTTn4cyFXSjXWmOUZnw6yx81Sg7UjhwtY IOTu0g+jCeCMNjPx5oUSi24uKPwhcaArYdItJhKrI0Hyqvygg3aGw4gSm9THwL6BkHmy iYgTw5+pBMck+xMpThq0Y1LLgCosKct4yuCWKLCqRjW643Z13eY+9/D9raPSrj0IEw5Y OlaA== X-Gm-Message-State: AOAM530FbsdSrMTzlBP7jDg6cFKnudWzIrrpYaFLd+AXv/sPnnHFTr64 WpnCixj5+hCZoOGnZiKJQYiUvAFfRsmfMNg/Wqc= X-Google-Smtp-Source: ABdhPJyUJKmXPwj3gHQNwQ/ZKhh5UuZTbx9Vkof32NImAq+3X+tIzzHo5o6oUyo6TvEW5zWDVT9xpna5Vbs253Eb7TI= X-Received: by 2002:a05:6808:490:: with SMTP id z16mr18863828oid.54.1635600719306; Sat, 30 Oct 2021 06:31:59 -0700 (PDT) MIME-Version: 1.0 References: <20210929055046.4326-1-bmeng.cn@gmail.com> <20210929133211.y36cqkfhmpllvvai@skbuf> <20211028192907.t2mtufhg6h4od7sv@skbuf> In-Reply-To: <20211028192907.t2mtufhg6h4od7sv@skbuf> From: Ramon Fried Date: Sat, 30 Oct 2021 16:31:48 +0300 Message-ID: Subject: Re: [PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call To: Vladimir Oltean Cc: Bin Meng , "u-boot@lists.denx.de" Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, Oct 28, 2021 at 10:29 PM Vladimir Oltean wrote: > > On Thu, Oct 28, 2021 at 09:41:02PM +0300, Ramon Fried wrote: > > Bin, patches don't apply cleanly. can you rebase ? > > > > On Thu, Oct 28, 2021 at 7:53 AM Ramon Fried wrote: > > > > > > On Wed, Oct 27, 2021 at 5:19 AM Bin Meng wrote: > > > > > > > > On Sun, Oct 17, 2021 at 2:26 AM Ramon Fried wrote: > > > > > > > > > > On Wed, Sep 29, 2021 at 4:32 PM Vladimir Oltean wrote: > > > > > > > > > > > > On Wed, Sep 29, 2021 at 01:50:44PM +0800, Bin Meng wrote: > > > > > > > set_promisc() call accepts the parameter of a bool type. Make it > > > > > > > clear by using true instead of 1. > > > > > > > > > > > > > > Signed-off-by: Bin Meng > > > > > > > --- > > > > > > > > > > > > > > net/dsa-uclass.c | 2 +- > > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > > > diff --git a/net/dsa-uclass.c b/net/dsa-uclass.c > > > > > > > index 694664d81b..dcefec03f4 100644 > > > > > > > --- a/net/dsa-uclass.c > > > > > > > +++ b/net/dsa-uclass.c > > > > > > > @@ -282,7 +282,7 @@ static int dsa_port_probe(struct udevice *pdev) > > > > > > > struct eth_ops *eth_ops = eth_get_ops(master); > > > > > > > > > > > > > > if (eth_ops->set_promisc) > > > > > > > - eth_ops->set_promisc(master, 1); > > > > > > > + eth_ops->set_promisc(master, true); > > > > > > > > > > > > > > return 0; > > > > > > > } > > > > > > > -- > > > > > > > 2.25.1 > > > > > > > > > > > > > > > > > > > Reviewed-by: Vladimir Oltean > > > > > Reviewed-by: Ramon Fried > > > > > > > > Ping for apply? > > > I'll get to the patches today. > > > thanks for waking me up :) > > Why don't you apply patches immediately after reviewing them? It wouldn't make a difference. you were all working on the same file in code, If I would have applied bin's patches before yours, then you would need to rebase. simple as that. Also the time when I'm applying and when I'm reviewing is also meaningless because this problem would occur anyway.