From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0910BC6FD1D for ; Sat, 1 Apr 2023 19:00:12 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D678B85A33; Sat, 1 Apr 2023 21:00:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Ul6ElsLG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6A7E3859FF; Sat, 1 Apr 2023 21:00:05 +0200 (CEST) Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 94C96859FF for ; Sat, 1 Apr 2023 20:59:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-wr1-x42b.google.com with SMTP id l12so25502972wrm.10 for ; Sat, 01 Apr 2023 11:59:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680375598; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eNF4fWvgVF7TbRBv+LAf1+kUg79TDGMMz7e4azLG0KA=; b=Ul6ElsLG9Ar3+0Uru7XSJVuWge0/5PcNmZqC2dK5m1ogXCzNPsgjhWAkyW7TkLgn3o yoAIPIN/ky3gw0jTp5gbeekNagCqvdtwRYy5BC9q1sTWjCXMdMSqiyf9XsKyPHieY7JL RhnrYwBp8qk4YY8XlBe4O0+J1OtKBRLxiUvS227fVcg88oSrfBhyFK1IhwinzPqkNmcA cQtGir48iKHO0uKQM7m38YfgYQcPkHS9YnjYh/Zu5zlplYRDfQIqNocozojb7Th4TPtF k5XH4dKkaXF3FJtSOHJRXTNMUmv+Ffzg72PL07qdcn12QjGBZ/xSmynITcZp8Zjcnteg zA0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680375598; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eNF4fWvgVF7TbRBv+LAf1+kUg79TDGMMz7e4azLG0KA=; b=UVFYQgscuQBZ42B8sEwJMXCbqYbdcJlux4fuoElrlTXKkZVC2X8SYZ3lYcyHGiYZMr 5QIg8PFw63H8+L+Iql5CjJc3OyEtf08g2b0nr1/d+B72XYeDL85U4t6ruzwigt4Zt6P1 9iTENUmnWVUrTnVtzjabOY9FRRFTzWMFTymzUR0723xY1yM8Rr9zffOkuo0NW6mpqOAb vyf4u1De+moEnV/aeI9kWEb6Bfs/5gsKhjN9IxLfQqLu4wHXnNgEuxrhXtFJmSrSiHkt qwZDiiC+9yia3od4Xf0HSAzuFEu5RcjyCgRiMuEXyK0mTQicjup/8u9YKg7wUf/LIgro yZHg== X-Gm-Message-State: AAQBX9cV/7gmYLD7/HsPj9tprnEEOlqiSkW0LuOtt9+k/8k2Zf9kcIs1 kCp4bJspi672ipI51rxbA+51R7GEl0UAHz5+O0/K032PU7nJiw== X-Google-Smtp-Source: AKy350bnwiro7PpHnjHUN8REOSYCxxmNXgfj2rTeZRXSV8jnGD+kmDaos4YmV4GdG8PpB/A7RsBEkyukO+Jo61gmM8k= X-Received: by 2002:a5d:6b84:0:b0:2e4:c9ac:c495 with SMTP id n4-20020a5d6b84000000b002e4c9acc495mr2098599wrx.2.1680375597878; Sat, 01 Apr 2023 11:59:57 -0700 (PDT) MIME-Version: 1.0 References: <20230319170317.27711-1-marek.vasut+renesas@mailbox.org> In-Reply-To: <20230319170317.27711-1-marek.vasut+renesas@mailbox.org> From: Ramon Fried Date: Sat, 1 Apr 2023 21:59:46 +0300 Message-ID: Subject: Re: [PATCH 01/41] net: phy: aquantia: Staticize PHY driver entries To: Marek Vasut Cc: u-boot@lists.denx.de, "Ariel D'Alessandro" , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Alex Nemirovsky , Haolin Li , Heinrich Schuchardt , Joe Hershberger , Joel Stanley , Josua Mayer , Michael Trimarchi , Michal Simek , Nate Drude , Neil Armstrong , Radu Pirea , Samuel Mendoza-Jonas , Stefan Roese , T Karthik Reddy , Tim Harvey , Vladimir Oltean , u-boot-amlogic@groups.io Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Sun, Mar 19, 2023 at 7:03=E2=80=AFPM Marek Vasut wrote: > > These struct phy_driver ... instances are local to this source code > file, staticize them. No functional change. > > Signed-off-by: Marek Vasut > --- > Cc: "Ariel D'Alessandro" > Cc: "C=C3=A9dric Le Goater" > Cc: "Marek Beh=C3=BAn" > Cc: Alex Nemirovsky > Cc: Haolin Li > Cc: Heinrich Schuchardt > Cc: Joe Hershberger > Cc: Joel Stanley > Cc: Josua Mayer > Cc: Marek Vasut > Cc: Michael Trimarchi > Cc: Michal Simek > Cc: Nate Drude > Cc: Neil Armstrong > Cc: Radu Pirea > Cc: Ramon Fried > Cc: Samuel Mendoza-Jonas > Cc: Stefan Roese > Cc: T Karthik Reddy > Cc: Tim Harvey > Cc: Vladimir Oltean > Cc: u-boot-amlogic@groups.io > --- > drivers/net/phy/aquantia.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/phy/aquantia.c b/drivers/net/phy/aquantia.c > index 8eb6024829d..fa887ade0c2 100644 > --- a/drivers/net/phy/aquantia.c > +++ b/drivers/net/phy/aquantia.c > @@ -598,7 +598,7 @@ int aquantia_startup(struct phy_device *phydev) > return 0; > } > > -struct phy_driver aq1202_driver =3D { > +static struct phy_driver aq1202_driver =3D { > .name =3D "Aquantia AQ1202", > .uid =3D 0x3a1b445, > .mask =3D 0xfffffff0, > @@ -611,7 +611,7 @@ struct phy_driver aq1202_driver =3D { > .shutdown =3D &gen10g_shutdown, > }; > > -struct phy_driver aq2104_driver =3D { > +static struct phy_driver aq2104_driver =3D { > .name =3D "Aquantia AQ2104", > .uid =3D 0x3a1b460, > .mask =3D 0xfffffff0, > @@ -624,7 +624,7 @@ struct phy_driver aq2104_driver =3D { > .shutdown =3D &gen10g_shutdown, > }; > > -struct phy_driver aqr105_driver =3D { > +static struct phy_driver aqr105_driver =3D { > .name =3D "Aquantia AQR105", > .uid =3D 0x3a1b4a2, > .mask =3D 0xfffffff0, > @@ -638,7 +638,7 @@ struct phy_driver aqr105_driver =3D { > .data =3D AQUANTIA_GEN1, > }; > > -struct phy_driver aqr106_driver =3D { > +static struct phy_driver aqr106_driver =3D { > .name =3D "Aquantia AQR106", > .uid =3D 0x3a1b4d0, > .mask =3D 0xfffffff0, > @@ -651,7 +651,7 @@ struct phy_driver aqr106_driver =3D { > .shutdown =3D &gen10g_shutdown, > }; > > -struct phy_driver aqr107_driver =3D { > +static struct phy_driver aqr107_driver =3D { > .name =3D "Aquantia AQR107", > .uid =3D 0x3a1b4e0, > .mask =3D 0xfffffff0, > @@ -665,7 +665,7 @@ struct phy_driver aqr107_driver =3D { > .data =3D AQUANTIA_GEN2, > }; > > -struct phy_driver aqr112_driver =3D { > +static struct phy_driver aqr112_driver =3D { > .name =3D "Aquantia AQR112", > .uid =3D 0x3a1b660, > .mask =3D 0xfffffff0, > @@ -679,7 +679,7 @@ struct phy_driver aqr112_driver =3D { > .data =3D AQUANTIA_GEN3, > }; > > -struct phy_driver aqr113c_driver =3D { > +static struct phy_driver aqr113c_driver =3D { > .name =3D "Aquantia AQR113C", > .uid =3D 0x31c31c12, > .mask =3D 0xfffffff0, > @@ -693,7 +693,7 @@ struct phy_driver aqr113c_driver =3D { > .data =3D AQUANTIA_GEN3, > }; > > -struct phy_driver aqr405_driver =3D { > +static struct phy_driver aqr405_driver =3D { > .name =3D "Aquantia AQR405", > .uid =3D 0x3a1b4b2, > .mask =3D 0xfffffff0, > @@ -707,7 +707,7 @@ struct phy_driver aqr405_driver =3D { > .data =3D AQUANTIA_GEN1, > }; > > -struct phy_driver aqr412_driver =3D { > +static struct phy_driver aqr412_driver =3D { > .name =3D "Aquantia AQR412", > .uid =3D 0x3a1b710, > .mask =3D 0xfffffff0, > -- > 2.39.2 > Reviewed-by: Ramon Fried