From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3A61C433EF for ; Tue, 12 Oct 2021 19:47:21 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B25760ED4 for ; Tue, 12 Oct 2021 19:47:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2B25760ED4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E46088348E; Tue, 12 Oct 2021 21:47:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gateworks-com.20210112.gappssmtp.com header.i=@gateworks-com.20210112.gappssmtp.com header.b="NOLJkOvg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C46FA83474; Tue, 12 Oct 2021 21:47:15 +0200 (CEST) Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3F20D8350F for ; Tue, 12 Oct 2021 21:47:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tharvey@gateworks.com Received: by mail-pl1-x62b.google.com with SMTP id l6so240273plh.9 for ; Tue, 12 Oct 2021 12:47:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JIJ4s59fwch7/fhemkrdAF/tmxYpKSQc3Eo0gy2h6+0=; b=NOLJkOvgbAB/w22SY3nCZdLjUVMhdoVqJM59w+XpgX1Mwd0LGvwysg75Ai6eQ6r/At o9MAjSO/iSqSxkuJHnWuUYZq2Equa7Qdv1Kf1u5BsLRKAspM80WIUjb4TJhzYRY4jI8p J8MQW2hTMIXayCBwHYiGue437eDZce9Dun4K9l3z7G4sYSIUB5x5h+jdWFhXrVzkoIzA VEK9ya4LwStsWj+bz1/RUKOmyekzA5rLiuMItnfVHyuv4CUNMjPpUcv55Q1ddZ2adRL7 ZeWv7D2phViXAI3c64N8mYrg3X2iGnWuj3KkkIoWD3//pLhAS96CREOlF018oDTSJJ7K ywBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JIJ4s59fwch7/fhemkrdAF/tmxYpKSQc3Eo0gy2h6+0=; b=u7AlVQx31RTiSYkLDLZOqx7+SZKMels9qhT1WEQZvBWtPLUgn62Z5R4LfeJXVjz33r 2o9Dm7t7/eDdF+zD4Gml80VYWWOpw1VbkbVb+vZjF6ScLNN16SKfNfxrfzhRNWbPDp4e /6IKke4Ke51dirJfEkWcshVgPQtnuRl8nC+P3NlUB5Roc9Dea24s5p06P/MNcHbJZqgp yRBSQR9ze/3fTdt09qjE+DNEtFsAD2iTLBlUEJ9bjst/s/KaTbqwiMx5TEXaGRSp2Edi j3tkXUJkW/3NcCLUQ7fi/XyHNTYOf1fknFeiSQF9EE9WJPMBf7KM1HuZaJP64N2xVeeM SOPw== X-Gm-Message-State: AOAM532MnCFytGHYHLR+/0kjTj0zVYa/KiWvxoFobmrYS8VYrmX8/9u9 ivtTzAxnwonR7oBRLQoUgN0MenN5aqHWJZ7hS7oEpA== X-Google-Smtp-Source: ABdhPJyiM0T6TmFnDVQNVWSbMz/lWXWnChU2Jagmdn7jSl/bfk/kitZXIId7OzkkED1drndTRGO4Fy3HzFa6tzvEr5c= X-Received: by 2002:a17:90a:dc81:: with SMTP id j1mr8262762pjv.155.1634068023986; Tue, 12 Oct 2021 12:47:03 -0700 (PDT) MIME-Version: 1.0 References: <20211009204113.1208641-1-marcel@ziswiler.com> In-Reply-To: <20211009204113.1208641-1-marcel@ziswiler.com> From: Tim Harvey Date: Tue, 12 Oct 2021 12:46:52 -0700 Message-ID: Subject: Re: [PATCH v6 00/11] board: toradex: verdin-imx8mm: target refresh To: Marcel Ziswiler , Stefano Babic Cc: u-boot , Heiko Thiery , Frieder Schrempf , Fabio Estevam , Marcel Ziswiler , Heiko Schocher , Igor Opaniuk , Ilko Iliev , Jaehoon Chung , Jagan Teki , Marek Vasut , Max Krummenacher , "NXP i.MX U-Boot Team" , Oleksandr Andrushchenko , Patrick Delaunay , Peng Fan , Rick Chen , Simon Glass , Teresa Remmet , Tero Kristo , Tom Rini , Wolfgang Denk Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sat, Oct 9, 2021 at 1:43 PM Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > > An assortment of fixes and improvements like an Ethernet PHY > configuration fix, DEK blob encapsulation preparation, migration to > using binman to pack images, SLEEP_MOCI# enablement, dropping of V1.0 > hardware support [1], renaming kernel image variable, using preboot > for fdtfile evaluation and watchdog pinctrl fix. > > Note that this series is applied on top of Peng's Makefile fix [2] as > otherwise, it may not quite generate all binman artefacts in the right > order as discussed here [3]. > > [1] https://developer.toradex.com/verdin-sample-phase-over > [2] https://marc.info/?l=u-boot&m=162908373904742 > [3] https://marc.info/?l=u-boot&m=162945614207220 > > Changes in v6: > - New patch re-ordering fdt nodes and properties. > - Update commit message as requested by Wolfgang. > > Changes in v5: > - Drop device tree part already done by Marek's patch. > - Add another fixes tag as his patch forgot the board code part. > - Re-based on top of u-boot-imx, master yet again. > > Changes in v4: > - Add Heiko Schocher's reviewed-by tag. > - Fix copyright periods. > - Re-based. > > Changes in v3: > - Case fold hex string. > - Revert binman part of imx8mm-verdin-u-boot.dtsi to a plain copy from > imx8mm-evk and postpone further improvements to after migrating to a > common binman config as agreed with Frieder and Simon. > - New patch cleaning up include order. > - Add Fabio's reviewed-by tag. > - Fix patch. > - Add missing apalis-imx8 part. > - While at it update copyright year resp. period. > - Fix closing endif comment. > > Changes in v2: > - Explicitly pass filename to binman when generating binaries as > suggested by Heiko. > - Use proper intermediate binary u-boot-spl-ddr.bin for imximage as > pointed out by Heiko. > - Drop first patch ("imx: mkimage_fit_atf: fix legacy image generation") > as a similar fix was already refused earlier. > - New patch allows booting recent embedded Linux BSPs. > - New patch addressing dynamic fdtfile definition. > - New patch fixing watchdog pinctrl issue. > > Igor Opaniuk (1): > verdin-imx8mm: use preboot for fdtfile evaluation > > Marcel Ziswiler (7): > imx8m: clean-up kconfig indentation > verdin-imx8mm: fix ethernet > ARM: dts: imx8mm-verdin: prepare for dek blob encapsulation > arm64: dts: imx8mm-verdin-u-boot.dtsi: alphabetically re-order > verdin-imx8mm: switch to use binman to pack images > verdin-imx8mm: clean-up include order > verdin-imx8mm: fix watchdog pinctrl issue > > Max Krummenacher (2): > verdin-imx8mm: enable sleep_moci output > verdin-imx8mm: drop support for v1.0 hardware > > Oleksandr Suvorov (1): > include/configs: apalis-imx8/verdin-imx8mm: rename kernel image > variable > > arch/arm/dts/imx8mm-verdin-u-boot.dtsi | 147 +++++++++++++++++++- > arch/arm/dts/imx8mm-verdin.dts | 18 +++ > arch/arm/mach-imx/imx8m/Kconfig | 21 +-- > board/toradex/verdin-imx8mm/imximage.cfg | 11 +- > board/toradex/verdin-imx8mm/verdin-imx8mm.c | 81 +---------- > configs/verdin-imx8mm_defconfig | 6 +- > doc/board/toradex/verdin-imx8mm.rst | 53 ++++--- > include/configs/apalis-imx8.h | 6 +- > include/configs/verdin-imx8mm.h | 10 +- > 9 files changed, 220 insertions(+), 133 deletions(-) > > -- > 2.26.2 > Marcel, I've tested your series with mx8mm-venice and did not see any issues. Tested-by: Tim Harvey for imx8mm-venice-* boards Thanks, the common u-boot.dtsi is nice to see! I have a couple of patches that have not been picked up by Stefano yet due to I believe merge conflicts becuase his imx tree is behind master with respect to some of the Kconfig patches. You are likely in the same boat. Stefano, is it best for me to rebase my 'imx8mm_venice: switch to use binman to pack images' and 'board: gateworks: venice: add imx8mn-gw7902 support' patches on your tree or are you going to be merging in origin/master soon? Best regards, Tim