From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC9B0C48BD1 for ; Fri, 11 Jun 2021 16:01:41 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 665646140C for ; Fri, 11 Jun 2021 16:01:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 665646140C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A677D801DE; Fri, 11 Jun 2021 18:01:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gateworks-com.20150623.gappssmtp.com header.i=@gateworks-com.20150623.gappssmtp.com header.b="gnJFOYBi"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0B4E2803B9; Fri, 11 Jun 2021 18:01:36 +0200 (CEST) Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8E01D800D9 for ; Fri, 11 Jun 2021 18:01:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tharvey@gateworks.com Received: by mail-pf1-x436.google.com with SMTP id x73so4802683pfc.8 for ; Fri, 11 Jun 2021 09:01:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i8XM/2hlNNB3+h8oODm+R14s9iKVaoLaIhGMI6SIT4g=; b=gnJFOYBiKsWT8lk+9GhyUTKSSFE4uQzYrGA45y2yvXQybhRkbtXHWXaTAVVdcsUbbn jNv7hpiDa6S2KNIYR1Mggs7DqR/JbfGeFPYxc+Y380UT271ulnNGdUnKoLqik9/9PCKI gWM1KXUVNbA47v03/vE/GDVOhQgT3mHSI7Fo59ud1XgSir2tan/ku09UfFDV0E0zmKlP Q3pUNNReqq685vTSK0n5ukxA3iEvS4JY+8MRf7ber8EAJgbMnaiIDsWH5uxvZhxw5P27 5RI+XkLmcB9UwHT3iDu1sz79c6EV05e6mGEIycDJXg9qmXLWpQfERqJDaHHki5XXYvMC 6+NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i8XM/2hlNNB3+h8oODm+R14s9iKVaoLaIhGMI6SIT4g=; b=cRvGTaTFFkMsz/2pIo1JOSsRseBoTDfSxpPi5SwMHoPbkxGgj1pEaFJ67icZFletYw sB4k2z3VJSowdunAkTDNSvW70KFvC8v2CrbWa/y3IFJPpqOgAA0KcaXzKKfmIJ4yXrO+ zZM/oaz37rHJVNseSJRUlKYTckln6NYm/jrGYMJnAFYToi3jQEh09y1SKJrljLdRmQvO lokYh/0KHydKTXo86gn408EsC+ANm/VVAcvfkU946oGAbAiaA7d3gRmqJfTtaTo+GShZ 1CzQW1yQ58FwlbdzJINOqiE2mItblcMZ1Pi4azYvXf7KzP2RYxjgk+5c4wcywJRJiFa9 hSpA== X-Gm-Message-State: AOAM530MgznxkKFJ4b+RhAJZXIZpGRCclDKD6BGGQyiEmbUvwDJfaHay 0RvncmPIw1tl08GCF0jh4vpcGnW7tMohW3X7BlQvgw== X-Google-Smtp-Source: ABdhPJxjbCWaWDdZOh947NA5lZtcfWlubnkTA4Wn7sDa9gnw5EqhMicyKR0O026GxyU4aOsP0fNpbXWl3dpzOwNfaBQ= X-Received: by 2002:a62:198f:0:b029:2da:c68b:7a1b with SMTP id 137-20020a62198f0000b02902dac68b7a1bmr9016552pfz.62.1623427290672; Fri, 11 Jun 2021 09:01:30 -0700 (PDT) MIME-Version: 1.0 References: <20210416202509.3943-1-tharvey@gateworks.com> In-Reply-To: From: Tim Harvey Date: Fri, 11 Jun 2021 09:01:18 -0700 Message-ID: Subject: Re: [PATCH] net: e1000: do not attempt to set hwaddr for i210 without FLASH To: Joe Hershberger , Ramon Fried Cc: Hannu Lounento , Martyn Welch , Sebastian Reichel , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, Apr 22, 2021 at 5:11 PM Ramon Fried wrote: > > On Fri, Apr 16, 2021 at 11:25 PM Tim Harvey wrote: > > > > commit f1bcad22dd19 ("net: e1000: add support for writing to EEPROM") > > adds support for storing hwaddr in EEPROM however i210 devices do not > > support this and thus results in errors such as: > > Warning: e1000#0 failed to set MAC address' > > > > Check if a flash device is present and if not return -ENOSYS indicating > > this is not supported. > > > > Signed-off-by: Tim Harvey > > --- > > drivers/net/e1000.c | 4 ++++ > > drivers/net/e1000.h | 1 + > > 2 files changed, 5 insertions(+) > > > > diff --git a/drivers/net/e1000.c b/drivers/net/e1000.c > > index 694114eca7..60613b7df0 100644 > > --- a/drivers/net/e1000.c > > +++ b/drivers/net/e1000.c > > @@ -5673,6 +5673,10 @@ static int e1000_write_hwaddr(struct eth_device *dev) > > > > DEBUGOUT("%s: mac=%pM\n", __func__, mac); > > > > + if ((hw->eeprom.type == e1000_eeprom_invm) && > > + !(E1000_READ_REG(hw, EECD) & E1000_EECD_FLASH_DETECTED_I210)) > > + return -ENOSYS; > > + > > memset(current_mac, 0, 6); > > > > /* Read from EEPROM, not from registers, to make sure > > diff --git a/drivers/net/e1000.h b/drivers/net/e1000.h > > index 072851ba31..082154a997 100644 > > --- a/drivers/net/e1000.h > > +++ b/drivers/net/e1000.h > > @@ -1245,6 +1245,7 @@ struct e1000_hw { > > #define E1000_EECD_FLUPD 0x00080000 /* Update FLASH */ > > #define E1000_EECD_FLUPD_I210 0x00800000 /* Update FLASH */ > > #define E1000_EECD_FLUDONE_I210 0x04000000 /* Update FLASH done*/ > > +#define E1000_EECD_FLASH_DETECTED_I210 0x00080000 /* FLASH detected */ > > #define E1000_FLUDONE_ATTEMPTS 20000 > > #define E1000_EECD_AUPDEN 0x00100000 /* Enable Autonomous FLASH update */ > > #define E1000_EECD_SHADV 0x00200000 /* Shadow RAM Data Valid */ > > -- > > 2.17.1 > > > Reviewed-by: Ramon Fried Joe / Ramon, Can one of you pick this up? If I need to re-submit with Ramon's 'reviewed by' please let me know. Best regards, Tim