From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C763C48BE0 for ; Fri, 11 Jun 2021 15:09:20 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70BE2613D0 for ; Fri, 11 Jun 2021 15:09:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70BE2613D0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CD1DE803B9; Fri, 11 Jun 2021 17:09:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="trisCH1P"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 092EB80563; Fri, 11 Jun 2021 17:09:16 +0200 (CEST) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 822BD8031F for ; Fri, 11 Jun 2021 17:09:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=matwey.kornilov@gmail.com Received: by mail-qk1-x72b.google.com with SMTP id c138so18397047qkg.5 for ; Fri, 11 Jun 2021 08:09:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9ZX8+AbyLn2AM57WKvL4HG97X0Wy7C4t7N97mp2vGQw=; b=trisCH1PhuSF6tNM0RqqIY48LFbRUB6CAnRKmeDZpawD9YC2sru2sZRsLGSuxbRsqa X/Y0wAouT+EL9BmddouuGhBwqL7qH26tA7g2U7lVjRo63KqBl0ONC3VQeSJsDT9qaoy+ 5qGGxv9tC13oAF2F2onu1WRwfVzsLgddirF3uzvVclDVNROQhwZOcWh6KZGXV4+2sHZQ EU6K8eTxdKOjdkJZipamuRgY9Eu58vkuVenuJSqLCd6iHzaPIeYbqDe7l07H/9/z3xjc 5V4Iqw45bbYqFOQsGNqcz1AnP/mpo2weY5zkxYdDvG9h2+KkXK8v5hfceGcIwen96EA4 EMqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9ZX8+AbyLn2AM57WKvL4HG97X0Wy7C4t7N97mp2vGQw=; b=pKGKt2ohvApoCIwr1xE+Xv79m7p4zbQYGrP72E2qt+y1Cb02+3Un0RyWhwrCEfONne mzLDB6U+7yXhud3xXO+jm6WwlmD7AX2kDSGFR3POKbFipKp3XnHei24SiqtCql0vWJ60 4lQihDbNRV/WAGvx41FS2p85m/AnWU6Q4mmC0WPGeZXilAU12aOQvV7sIbXCl6pmKVOp 8rZrnWyFj97mIbSOammQmMDVh7LsBQpGpcrtkHv4KLi7a/kF5AnQmugrYDpZWK/qTb14 Sq/MGs4r8U8g89TliUsowqUuEXInM9LWArhDVbxiDJS9tVNffHBhc99wY9IyV9/mKHfL egkA== X-Gm-Message-State: AOAM533SHd4Yzb8do4ohtyNXniG4Efuc23tntGtklhqGQ5zN/puCKmWS /oMOrTkHMDJwa/bcLSGZgV5baA10kFScGpHFY68= X-Google-Smtp-Source: ABdhPJy2zlfaCAU1YdF/OjnveERkd8C4/kyBiOEG0jAoqtzlaAjzsEDOy4B53q8hQ2foujhjeRiuWaIavAwmSBjZZxg= X-Received: by 2002:a37:5943:: with SMTP id n64mr4367101qkb.122.1623424151142; Fri, 11 Jun 2021 08:09:11 -0700 (PDT) MIME-Version: 1.0 References: <5e1f6595-3371-8d56-ebfa-916d10b5aad4@gmx.de> <8d847043-ab5d-a627-ed71-5f8829bcad8c@gmx.de> <6683bdcc-d83b-de80-b0b2-4d0b8df268f0@gmx.de> In-Reply-To: From: "Matwey V. Kornilov" Date: Fri, 11 Jun 2021 18:08:28 +0300 Message-ID: Subject: Re: BISECTED f3866909e350 ("distro_bootcmd: call EFI bootmgr even without having /EFI/boot") To: Heinrich Schuchardt Cc: michael@walle.cc, U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean =D1=87=D1=82, 10 =D0=B8=D1=8E=D0=BD. 2021 =D0=B3. =D0=B2 23:05, Heinrich Sc= huchardt : > > On 6/7/21 7:51 PM, Matwey V. Kornilov wrote: > > =D0=B2=D1=81, 6 =D0=B8=D1=8E=D0=BD. 2021 =D0=B3. =D0=B2 19:47, Heinrich= Schuchardt : > >> > >> On 6/6/21 6:21 PM, Heinrich Schuchardt wrote: > >>> On 6/6/21 5:42 PM, Matwey V. Kornilov wrote: > >>>> =D0=B2=D1=81, 6 =D0=B8=D1=8E=D0=BD. 2021 =D0=B3. =D0=B2 18:20, Heinr= ich Schuchardt : > >>>>> > >>>>> On 6/6/21 4:37 PM, Matwey V. Kornilov wrote: > >>>>>> Hi, > >>>>>> > >>>>>> I've found that > >>>>>> > >>>>>> f3866909e350 ("distro_bootcmd: call EFI bootmgr even without havin= g > >>>>>> /EFI/boot") > >>>>>> > >>>>>> breaks running EFI application from USB device on BeagleBone Black > >>>>>> (am335x) device. > >>>>>> > >>>>>> With this patch I see the following: > >>>>>> > >>>>>> Booting /efi\boot\bootarm.efi > >>>>>> Welcome to GRUB! > >>>>>> > >>>>>> data abort > >>>>>> pc : [<9ce0b6d0>] lr : [<9ffab7c7>] > >>>>>> reloc pc : [<7d69d6d0>] lr : [<8083d7c7>] > >>>>>> sp : 9df44e28 ip : 9ffdfe90 fp : 00000003 > >>>>>> r10: 9ffe3300 r9 : 00000000 r8 : 9df6fe88 > >>>>>> r7 : 00000000 r6 : 9ce5da08 r5 : 9ce571f8 r4 : 9ce2c040 > >>>>>> r3 : 00000000 r2 : 00000001 r1 : 9ce56598 r0 : 00000000 > >>>>>> Flags: NzCv IRQs off FIQs on Mode SVC_32 > >>>>>> Code: e3500000 0a000015 e590000c eb00f96e (e5d03000) > >>>>> > UEFI image [0x9ce46000:0x9cf28fff] '/efi\boot\bootarm.efi' > >>>>> > Resetting CPU ... > >>>>> > >>>>> Hello Matwey, > >>>>> > >>>>> thank you for reporting the issue. > >>>>> > >>>>> $ echo 'Code: e3500000 0a000015 e590000c eb00f96e (e5d03000)' | > >>>>> CROSS_COMPILE=3Darm-linux-gnueabihf- ARCH=3Darm scripts/decodecode > >>>>> > >>>>> Code: e3500000 0a000015 e590000c eb00f96e (e5d03000) > >>>>> All code > >>>>> =3D=3D=3D=3D=3D=3D=3D=3D > >>>>> 0: e3500000 cmp r0, #0 > >>>>> 4: 0a000015 beq 0x60 > >>>>> 8: e590000c ldr r0, [r0, #12] > >>>>> c: eb00f96e bl 0x3e5cc > >>>>> 10:* e5d03000 ldrb r3, [r0] <-- trap= ping > >>>>> instruction > >>>>> > >>>>> Code starting with the faulting instruction > >>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >>>>> 0: e5d03000 ldrb r3, [r0] > >>>>> > >>>>> Looking at the disassembly above we see that reading memory locatio= n > >>>>> NULL fails. > >>>>> > >>>>> We need to find out where the exception occurs. The code position i= s > >>>>> neither in bootarm.efi nor in U-Boot (9ce0b6d0 is lower than the lo= ad > >>>>> position of bootarm.efi, so it is below the relocated U-Boot code). > >>>>> > >>>>> Please, add the following line at the start of grub.cfg to get more > >>>>> output from GRUB: > >>>>> > >>>>> debug=3Dall > >>>> > >>>> This doesn't provide any additional output from GRUB :( > >>>> > >>>>> > >>>>> When building U-Boot, please, add > >>>>> > >>>>> #define DEBUG 1 > >>>>> > >>>>> in lib/efi_loader/efi_disk.c and lib/efi_loader_file.c a line befor= e > >>>>> #include . > >>>> > >>>> > >>>> This doesn't provide much output as well: > >>>> > >>>> Scanning disk mmc@48060000.blk... > >>>> EFI: Call: efi_install_multiple_protocol_interfaces( &handle, > >>>> &efi_guid_device_path, diskobj->dp, &efi_block_io_guid, &diskobj->op= s, > >>>> NULL) > >>>> EFI: 0 returned by efi_install_multiple_protocol_interfaces( &handle= , > >>>> &efi_guid_device_path, diskobj->dp, &efi_block_io_guid, &diskobj->op= s, > >>>> NULL) > >>>> ** Unrecognized filesystem type ** > >>>> Scanning disk mmc@481d8000.blk... > >>>> EFI: Call: efi_install_multiple_protocol_interfaces( &handle, > >>>> &efi_guid_device_path, diskobj->dp, &efi_block_io_guid, &diskobj->op= s, > >>>> NULL) > >>>> EFI: 0 returned by efi_install_multiple_protocol_interfaces( &handle= , > >>>> &efi_guid_device_path, diskobj->dp, &efi_block_io_guid, &diskobj->op= s, > >>>> NULL) > >>>> EFI: Call: efi_install_multiple_protocol_interfaces( &handle, > >>>> &efi_guid_device_path, diskobj->dp, &efi_block_io_guid, &diskobj->op= s, > >>>> NULL) > >>>> EFI: 0 returned by efi_install_multiple_protocol_interfaces( &handle= , > >>>> &efi_guid_device_path, diskobj->dp, &efi_block_io_guid, &diskobj->op= s, > >>>> NULL) > >>>> Found 3 disks > >>> > >>> This implies that GRUB is crashing before even accessing the file sys= tem > >>> (including grub.cfg). > >>> > >>> On an OrangePi PC I deleted /boot.scr and moved grubarm.efi to > >>> /EFI/boot/bootarm.efi. It boots without problem. > >>> > >>> What version of GRUB are you using? > >>> How were you booting before updating U-Boot? > >>> What version of U-Boot are you using where the error occurs? > >>> Why do you have grub in /EFI/boot/bootarm.efi and not in a distro > >>> specific path, e.g. /EFI/debian/grubarm.efi? /EFI/boot is typically o= nly > >>> used by installers. > >>> > >>> If the boot manager is started by distroboot it may not have an > >>> appropriate device path. It tries to load the file given by environme= nt > >>> variable $fdtfile from the boot device. > >>> > >>> From the U-Boot console could you, please, try: > >>> > >>> 1) > >>> load usb 0:1 $kernel_addr_r EFI/boot/bootarm.efi > >>> bootefi bootmgr > >>> > >>> > >>> 2) > >>> load usb 0:1 $kernel_addr_r EFI/boot/bootarm.efi > >>> load usb 0:2 $fdt_addr_r dtb > >>> bootefi bootmgr $fdt_addr_r > >>> > >>> where you need to replace dtb by the correct device tree file and adj= ust > >>> the partition numbers. > >>> > >>> Best regards > >>> > >>> Heinrich > >> > >> To catch the earlier EFI API calls you can add > >> > >> #define DEBUG 1 > >> > >> to lib/efi_loader/efi_boottime.c > > > > > > Welcome to GRUB! > > > > EFI: Entry efi_locate_handle_ext(2, > > 9042a9de-23dc-4a38-96fb-7aded080516a, 00000000, 9df40dfc, 9ce2d660) > > EFI_GRAPHICS_OUTPUT_PROTOCOL_GUID > > This call could be from grub-core/video/efi_gop.c, check_protocol(). > > > EFI: Exit: efi_locate_handle_ext: 14 > > EFI_NOT_FOUND > > > EFI: Entry efi_open_protocol(9df5f298, > > 5b1b31a1-9562-11d2-8e3f-00a0c969723b, 9df40e14, 9df5f298, 00000000, > > 0x2) > > EFI_LOADED_IMAGE_PROTOCOL_GUID > > This call could be from grub-core/kern/efi/efi.c, > grub_efi_get_loaded_image(). > > > EFI: Exit: efi_open_protocol: 0 > > EFI: Entry efi_open_protocol(00000000, > > The parameter @handle must not be NULL. > > > 09576e91-6d3f-11d2-8e39-00a0c969723b, 9df40e14, 9df5f298, 00000000, > > EFI_DEVICE_PATH_PROTOCOL_GUID > > This could be called from grub-core/kern/efi/efi.c, > grub_efi_get_device_path() which is invoked from > grub_machine_get_bootlocation(). > > > 0x2) > > EFI_INVALID_PARAMETER is returned because the handle is NULL. > > I could partially reproduce the problem by setting > > info->device_handle =3D NULL; > > at the end of efi_setup_loaded_image(): > > Welcome to GRUB! > > EFI: Entry efi_open_protocol(79fdea40, > 5b1b31a1-9562-11d2-8e3f-00a0c969723b, 79f570e4, 79fdea40, 00000000, 0x2) > EFI: Exit: efi_open_protocol: 0 > EFI: Entry efi_open_protocol(00000000, > 09576e91-6d3f-11d2-8e39-00a0c969723b, 79f570b4, 79fdea40, 00000000, 0x2) > EFI: Exit: efi_open_protocol: 2 > error: disk `,msdos2' not found. > grub rescue> > > > This leaves me with two questions: > > Why does GRUB not handle > > *device =3D grub_efidisk_get_device_name (NULL); > > gracefully? Maybe it is because it tries to print via the graphical > output protocol which does not exist? > > Why is image->device_handle NULL? > > Next step is to verify that image->device_handle is really NULL. > > Please apply the following change to efi/efi_loader/efi_boottime.c > > @@ -2060,6 +2069,7 @@ efi_status_t EFIAPI efi_load_image(bool boot_policy= , > free(info); > } > error: > + printf("*** %p\n", info->device_handle); > return EFI_EXIT(ret); > } Booting /efi\boot\bootarm.efi EFI: Entry efi_load_image(0, 9df56d90, /VenHw(e61d73b9-a384-4acc-aeab-82e828f3628b)/UsbClass(0x13fe,0x4123,0x0,0x0= ,0x0)/HD(1,GPT,c3d6ff69-0ec0-4be1-91a3-e5fbeed5c4b9,0x2000,0x8000)/efi\boot= \bootarm.efi, 82000000, 929792, 9df40ea0) *** 00000000 EFI: Exit: efi_load_image: 0 EFI: Entry efi_start_image(9df5f298, 9df40e78, 9df40e7c) EFI: Call: efi_open_protocol(image_handle, &efi_guid_loaded_image, &info, NULL, NULL, EFI_OPEN_PROTOCOL_GET_PROTOCOL) EFI: Entry efi_open_protocol(9df5f298, 5b1b31a1-9562-11d2-8e3f-00a0c969723b, 9df40e60, 00000000, 00000000, 0x2) EFI: Exit: efi_open_protocol: 0 > > Best regards > > Heinrich > > > EFI: Exit: efi_open_protocol: 2 > > data abort > > pc : [<9ce076d0>] lr : [<9ffa85b3>] > > reloc pc : [<7d69d6d0>] lr : [<8083e5b3>] > > sp : 9df40e28 ip : 00000000 fp : 00000003 > > r10: 9ffe2df8 r9 : 00000000 r8 : 9df5f298 > > r7 : 00000000 r6 : 9ce59a08 r5 : 9ce531f8 r4 : 9ce28040 > > r3 : 00000000 r2 : 9ffeb328 r1 : 00000000 r0 : 00000000 > > Flags: NzCv IRQs off FIQs on Mode SVC_32 > > Code: e3500000 0a000015 e590000c eb00f96e (e5d03000) > > UEFI image [0x9ce42000:0x9cf24fff] '/efi\boot\bootarm.efi' > > Resetting CPU ... > > > > > >> > >> Best regards > >> > >> Heinrich > >> > >> > > > > > > --=20 With best regards, Matwey V. Kornilov