From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36BA5C4320A for ; Fri, 6 Aug 2021 11:50:42 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BC1A60EBC for ; Fri, 6 Aug 2021 11:50:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5BC1A60EBC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 694AD82C24; Fri, 6 Aug 2021 13:50:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="k35tRgfV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 49F5782C6D; Fri, 6 Aug 2021 13:50:38 +0200 (CEST) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C07F682C24 for ; Fri, 6 Aug 2021 13:50:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=matwey.kornilov@gmail.com Received: by mail-qv1-xf2c.google.com with SMTP id s11so4709408qvz.7 for ; Fri, 06 Aug 2021 04:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=LdHgXAEQKIRDpctY3q18m/BJh5JoFlICBugveFUXIkk=; b=k35tRgfVjcetb4dJzpyute++JNAbnmlOMs7JgMKWlHWBbUi4+8Ws0YvNPgHZjDeKcM qk9fgQldKayGll6XU+blfKceJwD2rk53nddRy9JVraxUKToLd4Rv75afxWV5lmwhspYu ++1zOatHqMA/HDl0V9Fj07o9gs7UXD1QMRhR6B2Y4jmkubXa1DbZT4m3vCayaAYIQPbP gjpy0xLzeeYChZBVNTInuZv+wDUtMoMu0CjnkXul+vobEau6AzBguJtlwZDCtxxDlvcN J9IdBG78LExF7ARKFGCgMnc4vGyjLb42H739QTPxA+nVCUXE16J7LQmCmsbVqmhTPU84 13dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=LdHgXAEQKIRDpctY3q18m/BJh5JoFlICBugveFUXIkk=; b=irJrnU+9EcpAGneiO7/zs5iBavjgLnIh+lKhwCxFx822WDjLAtqn87fU0ZMuSLiQZX R6kDSW5aXbUh8POkQMIjZYfeEPFJY4zwGyhJM8yPIB4PAcY+H4RbrwrjCua4tMV7Fz2A 69V3WvxhdOnNUS3lOAIuxH4nFL2hVWzc+rmjCEUWFlLgoWXET983peW9qP/K98ijV3gX gb6YA5UOjg6tuWusM8C2rBSbFaDFvzKe2tV8Wpyejg6u8ij0CoFIuDdGVkl433+Nxa6m L/88zxD8HznwBCav+ytSbFT7UDOeDWTDB1vbqO68LB4KhQFTCsZ29iP5XqGsE3EqS5q9 hDQQ== X-Gm-Message-State: AOAM5316bc1IYKzebWlNlWi3vtGzAum5brYcF3dTCcibzcCVkfWtFJl9 /9UkoPV2NK1CGLJ7M67w83JGTpAyNSTa3SFyvHk= X-Google-Smtp-Source: ABdhPJy529Q3zrfyBE7+XI8dNcuGBYb7G36A0s6GZLmuGPOCEnhpGx0gKYwhbaNvUic8qIb6MEul+sXGyK6sutVJpCw= X-Received: by 2002:a05:6214:20a2:: with SMTP id 2mr8734520qvd.51.1628250633490; Fri, 06 Aug 2021 04:50:33 -0700 (PDT) MIME-Version: 1.0 References: <5739230aa8a33618d50645315c456669c41598d1.camel@denx.de> In-Reply-To: From: "Matwey V. Kornilov" Date: Fri, 6 Aug 2021 14:50:22 +0300 Message-ID: Subject: Re: [BISECTED] arm: dts: Resync BeagleBone device trees To: Peter Robinson Cc: Harald Seiler , U-Boot Mailing List , paul.barker@sancloud.com, Tom Rini Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean =D0=BF=D1=82, 6 =D0=B0=D0=B2=D0=B3. 2021 =D0=B3. =D0=B2 14:45, Peter Robins= on : > > On Fri, Aug 6, 2021 at 12:39 PM Harald Seiler wrote: > > > > Hi, > > > > On Fri, 2021-08-06 at 13:54 +0300, Matwey V. Kornilov wrote: > > > Hello, > > > > > > I've found that the following commit breaks USB on BeagleBone Black > > > board (am335x based): > > > > > > commit 942853dd96df5de1c0a2a61c877c1cf1c24f1e91 > > > Author: Paul Barker > > > Date: Mon Jul 12 21:14:09 2021 +0100 > > > > > > arm: dts: Resync BeagleBone device trees > > > > > > > > > When commit is applied then I see the following: > > > > > > starting USB... > > > No working controllers found > > > USB is stopped. Please issue 'usb start' first. > > > starting USB... > > > No working controllers found > > > > > > Before the commit USB was working as expected: > > > > > > starting USB... > > > Bus usb@47401800: scanning bus usb@47401800 for devices... 1 USB Devi= ce(s) found > > > scanning usb for storage devices... 1 Storage Device(s) found > > > > > > Device 0: Vendor: Rev: PMAP Prod: USB DISK Pro > > > Type: Removable Hard Disk > > > Capacity: 7381.2 MB =3D 7.2 GB (15116736 x 512) > > > ... is now current device > > > > It looks the the arch/arm/dts/am33xx.dtsi file is out of sync with > > Linux, leading to this regression. In the current U-Boot version, it > > has > > > > status =3D "disabled"; > > > > lines for e.g. usb0 while in Linux mainline, those are missing. As the > > commit you found by bisecting drops the > > > > status =3D "okay"; > > > > lines from arch/arm/dts/am335x-bone-common.dtsi, the device now are no > > longer enabled. Maybe try syncing am33xx.dtsi as well to check if it > > helps? > > It's usual for peripheral devices to be disabled in the SoC .dtsi > file, those that are actively used by devices are supposed to enable > them in the device .dts so I would expect to see the appropriate bit > enabling it in the device .dts. This may be related: https://github.com/torvalds/linux/commit/12afc0cf81210969756daecd7eb48b307f= 08faed --=20 With best regards, Matwey V. Kornilov