From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48F96C6FA83 for ; Tue, 6 Sep 2022 07:39:54 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4A0608499C; Tue, 6 Sep 2022 09:39:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="CK7zEG1t"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E7B80849C4; Tue, 6 Sep 2022 09:39:49 +0200 (CEST) Received: from mail-oa1-x2f.google.com (mail-oa1-x2f.google.com [IPv6:2001:4860:4864:20::2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1F299848DD for ; Tue, 6 Sep 2022 09:39:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=etienne.carriere@linaro.org Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-11eab59db71so26157690fac.11 for ; Tue, 06 Sep 2022 00:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=GtNJ73yT7GJhGSFYAPCjc5N3ih1c2VIMJVcyzP20eXs=; b=CK7zEG1tFrQtwASJzJ2nEPWcmSlOeYOGTiq8owdtEs3U7cvtyChuk+65mGUtPuKWg8 OZsMI4BifzHZPNRHFw069+nLvovU1H/+sd2xuWkFHSUUQziUP5A8T81wwXxMPIFb/isE 31SEqIOB6gmSNDtNE17VKxbNEGoOz5M6zg+xRoosDZufQkkFOqUD+M6g5eNmbwgmGFRS k/87vwdBKjuldtx7d8NbgX+9kijOWz9Yu7tJDzgGQLI4qwROZWULrJuBjTRmYxeoiKO0 6ZSQArQ1ZQTjTzeaQXNTvh9Pj6RR1N9/Zbxb4STFXKeMQaGu0PMNLbN96gPOnsq6jCwG upRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=GtNJ73yT7GJhGSFYAPCjc5N3ih1c2VIMJVcyzP20eXs=; b=5pBejrC7Ttmt9UJ7YjOMaA34vQeNl8veJzxgfOcmIciMvb3pA17Q3xQMpvgBCyvtct 6McIgUi3Zxx9tQoYvqV7Eme9fWCxHDsJhWjn89fYG1g1tncysYCPuwkCtm6+NwUjf4G+ 5VE5p7yb7BFs2K+PjQmfyI7ttTLPzeM4jxa1Lz9zHhH7Hj+bPdHWUX2yKEoEUPTwZhZc nfekyZbW6OnHDcQym76ukZ0h/tj/G3OXbtaWr6mQH6D5N761MXuoFJumhY0T2Husd/82 MnGEekOhIFZOlxBYsvoTEsO3o5k7OFO6kiFRM3SSnxlkCCIDn15PmdYcxWsIejAf5yrQ gTlw== X-Gm-Message-State: ACgBeo1dxzm3lu1y08+I5nxI00SlpVpmbMly/thHQlHzLbhkyLRAHgjD pIWDiG/OrueZxy8VhTk2T/rQ/Jx1vUI7SQ5wnIGL2g== X-Google-Smtp-Source: AA6agR6KJ0nzI7eOJq+mHRF89iWBPprO0OqKjWIw+ng8TACN8B2PbiWvYJrEdSJzIPcq6Oz7FbI4sM56EikSXMS3Zuw= X-Received: by 2002:a05:6871:725:b0:127:96e8:21c with SMTP id f37-20020a056871072500b0012796e8021cmr2801502oap.104.1662449985799; Tue, 06 Sep 2022 00:39:45 -0700 (PDT) MIME-Version: 1.0 References: <20220826095716.1676150-1-sughosh.ganu@linaro.org> <20220826095716.1676150-7-sughosh.ganu@linaro.org> In-Reply-To: <20220826095716.1676150-7-sughosh.ganu@linaro.org> From: Etienne Carriere Date: Tue, 6 Sep 2022 09:39:35 +0200 Message-ID: Subject: Re: [PATCH v9 06/15] FWU: Add helper functions for accessing FWU metadata To: Sughosh Ganu Cc: u-boot@lists.denx.de, Heinrich Schuchardt , Ilias Apalodimas , Takahiro Akashi , Patrick Delaunay , Patrice Chotard , Simon Glass , Bin Meng , Tom Rini , Michal Simek , Jassi Brar Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Fri, 26 Aug 2022 at 11:57, Sughosh Ganu wrote: > > Add weak functions for getting the update index value and dfu > alternate number needed for FWU Multi Bank update > functionality. > > The current implementation for getting the update index value is for > platforms with 2 banks. If a platform supports more than 2 banks, it > can implement it's own function. The function to get the dfu alternate > number has been added for platforms with GPT partitioned storage > devices. Platforms with other storage partition scheme need to > implement their own function. > > Signed-off-by: Sughosh Ganu > Reviewed-by: Patrick Delaunay > --- > Changes since V8: > * Add comments for API functions > * Update the logic to get the update index as suggested by Jassi Acked-by: Etienne Carriere > > include/fwu.h | 29 ++++++++++ > lib/fwu_updates/fwu.c | 27 +++++++++ > lib/fwu_updates/fwu_gpt.c | 115 ++++++++++++++++++++++++++++++++++++++ > 3 files changed, 171 insertions(+) > create mode 100644 lib/fwu_updates/fwu_gpt.c > > diff --git a/include/fwu.h b/include/fwu.h > index ecabf11210..7ebd3a7115 100644 > --- a/include/fwu.h > +++ b/include/fwu.h > @@ -211,4 +211,33 @@ int fwu_accept_image(efi_guid_t *img_type_id, u32 bank); > */ > int fwu_clear_accept_image(efi_guid_t *img_type_id, u32 bank); > > +/** > + * fwu_plat_get_alt_num() - Get the DFU Alt Num for the image from the platform > + * @dev: FWU device > + * @image_guid: Image GUID for which DFU alt number needs to be retrieved > + * @alt_num: Pointer to the alt_num > + * > + * Get the DFU alt number from the platform for the image specified by the > + * image GUID. > + * > + * Return: 0 if OK, -ve on error > + * > + */ > +int fwu_plat_get_alt_num(struct udevice *dev, efi_guid_t *image_guid, > + int *alt_num); > + > +/** > + * fwu_plat_get_update_index() - Get the value of the update bank > + * @update_idx: Bank number to which images are to be updated > + * > + * Get the value of the bank(partition) to which the update needs to be > + * made. > + * > + * Note: This is a weak function and platforms can override this with > + * their own implementation for selection of the update bank. > + * > + * Return: 0 if OK, -ve on error > + * > + */ > +int fwu_plat_get_update_index(uint *update_idx); > #endif /* _FWU_H_ */ > diff --git a/lib/fwu_updates/fwu.c b/lib/fwu_updates/fwu.c > index a871d77b4c..94b15859a5 100644 > --- a/lib/fwu_updates/fwu.c > +++ b/lib/fwu_updates/fwu.c > @@ -355,3 +355,30 @@ int fwu_clear_accept_image(efi_guid_t *img_type_id, u32 bank) > return fwu_clrset_image_accept(img_type_id, bank, > IMAGE_ACCEPT_CLEAR); > } > + > +/** > + * fwu_plat_get_update_index() - Get the value of the update bank > + * @update_idx: Bank number to which images are to be updated > + * > + * Get the value of the bank(partition) to which the update needs to be > + * made. > + * > + * Note: This is a weak function and platforms can override this with > + * their own implementation for selection of the update bank. > + * > + * Return: 0 if OK, -ve on error > + * > + */ > +__weak int fwu_plat_get_update_index(uint *update_idx) > +{ > + int ret; > + u32 active_idx; > + > + ret = fwu_get_active_index(&active_idx); > + if (ret < 0) > + return -1; > + > + *update_idx = (active_idx + 1) % CONFIG_FWU_NUM_BANKS; > + > + return ret; > +} > diff --git a/lib/fwu_updates/fwu_gpt.c b/lib/fwu_updates/fwu_gpt.c > new file mode 100644 > index 0000000000..a3134b80c9 > --- /dev/null > +++ b/lib/fwu_updates/fwu_gpt.c > @@ -0,0 +1,115 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* > + * Copyright (c) 2022, Linaro Limited > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > + > +static int get_gpt_dfu_identifier(struct blk_desc *desc, efi_guid_t *image_guid) > +{ > + int i; > + struct disk_partition info; > + efi_guid_t unique_part_guid; > + > + for (i = 1; i < MAX_SEARCH_PARTITIONS; i++) { > + if (part_get_info(desc, i, &info)) > + continue; > + uuid_str_to_bin(info.uuid, unique_part_guid.b, > + UUID_STR_FORMAT_GUID); > + > + if (!guidcmp(&unique_part_guid, image_guid)) > + return i; > + } > + > + log_err("No partition found with image_guid %pUs\n", image_guid); > + return -ENOENT; > +} > + > +static int fwu_gpt_get_alt_num(struct blk_desc *desc, efi_guid_t *image_guid, > + int *alt_num, unsigned char dfu_dev) > +{ > + int ret = -1; > + int i, part, dev_num; > + int nalt; > + struct dfu_entity *dfu; > + > + dev_num = desc->devnum; > + part = get_gpt_dfu_identifier(desc, image_guid); > + if (part < 0) > + return -ENOENT; > + > + dfu_init_env_entities(NULL, NULL); > + > + nalt = 0; > + list_for_each_entry(dfu, &dfu_list, list) { > + nalt++; > + } > + > + if (!nalt) { > + log_warning("No entities in dfu_alt_info\n"); > + dfu_free_entities(); > + return -ENOENT; > + } > + > + for (i = 0; i < nalt; i++) { > + dfu = dfu_get_entity(i); > + > + if (!dfu) > + continue; > + > + /* > + * Currently, Multi Bank update > + * feature is being supported > + * only on GPT partitioned > + * MMC/SD devices. > + */ > + if (dfu->dev_type != dfu_dev) > + continue; > + > + if (dfu->layout == DFU_RAW_ADDR && > + dfu->data.mmc.dev_num == dev_num && > + dfu->data.mmc.part == part) { > + *alt_num = dfu->alt; > + ret = 0; > + break; > + } > + } > + > + dfu_free_entities(); > + > + return ret; > +} > + > +/** > + * fwu_plat_get_alt_num() - Get the DFU alt number > + * @dev: FWU metadata device > + * @image_guid: GUID value of the image for which the alt num is to > + * be obtained > + * @alt_num: The DFU alt number for the image that is to be updated > + * > + * Get the DFU alt number for the image that is to be updated. The > + * image is identified with the image_guid parameter that is passed > + * to the function. > + * > + * Note: This is a weak function and platforms can override this with > + * their own implementation for obtaining the alt number value. > + * > + * Return: 0 if OK, -ve on error > + * > + */ > +__weak int fwu_plat_get_alt_num(struct udevice *dev, efi_guid_t *image_guid, > + int *alt_num) > +{ > + struct fwu_mdata_gpt_blk_priv *priv = dev_get_priv(dev); > + > + return fwu_gpt_get_alt_num(dev_get_uclass_plat(priv->blk_dev), > + image_guid, alt_num, DFU_DEV_MMC); > +} > -- > 2.34.1 >