From: Ralph Siemsen <ralph.siemsen@linaro.org>
To: Sean Anderson <seanga2@gmail.com>
Cc: u-boot@lists.denx.de, Lukasz Majewski <lukma@denx.de>
Subject: Re: [RFC PATCH v1 3/9] clk: renesas: add R906G032 driver
Date: Wed, 22 Feb 2023 12:39:31 -0500 [thread overview]
Message-ID: <CANp-EDbfcg-S=j4QiGkSvmH79u0N_heLK7bfo=X0s3mGG-ytbA@mail.gmail.com> (raw)
In-Reply-To: <20220826154724.GB1235411@maple.netwinder.org>
Hi Sean,
I finally got around to posting v3 of this patch series. I wanted to
touch on a few issues you had mentioned in previous review.
On Fri, Aug 26, 2022 at 11:47 AM Ralph Siemsen <ralph.siemsen@linaro.org> wrote:
>
> On Tue, Aug 23, 2022 at 12:14:31AM -0400, Sean Anderson wrote:
> >>Regarding the unused fields (scon, mirack, mistat): I am not really
> >>sure what their purpose is. Maybe there is some value in having them.
> >>I'll try to find out more information about them. If we do decide to
> >>drop them, I would like to keep it synchronised with the Linux driver.
> >
> >OK, well if you don't use them then perhaps you can just leave them in
> >the macro but remove them from the struct. That way you can add support
> >for them later if you need to, but they don't take up space in the mean
> >time. A comment summarizing your explanation above would be helpful.
So I ended up doing as you suggested: keeping the values in the
tables, in case they are needed in the future, but omitting them from
the structure to save space.
> >>>DIV_ROUND_CLOSEST?
> >>
> >>I'm hesitant to change the logic on this, as it could subtly alter the values.
> >
> >Well if you have 2MHz divided by 3, the resulting rate is closer to
> >666667 kHz than 666666 Hz.
This could result in the chosen clock rate being higher than what was
requested. And in turn that could result in violating the spec of a
hardware device.
So I have kept the original logic here.
Regards
Ralph
next prev parent reply other threads:[~2023-02-22 17:39 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 12:59 [RFC PATCH v1 0/9] Renesas RZ/N1 SoC initial support Ralph Siemsen
2022-08-09 12:59 ` [RFC PATCH v1 1/9] ARM: armv7: add non-SPL enable for Cortex SMPEN Ralph Siemsen
2022-08-09 12:59 ` [RFC PATCH v1 2/9] clk: renesas: prepare for non-RCAR clock drivers Ralph Siemsen
2022-08-13 4:37 ` Sean Anderson
2022-08-09 12:59 ` [RFC PATCH v1 3/9] clk: renesas: add R906G032 driver Ralph Siemsen
2022-08-13 5:30 ` Sean Anderson
2022-08-15 2:48 ` Ralph Siemsen
2022-08-23 4:14 ` Sean Anderson
2022-08-26 15:47 ` Ralph Siemsen
2023-02-22 17:39 ` Ralph Siemsen [this message]
2022-08-09 12:59 ` [RFC PATCH v1 4/9] pinctrl: " Ralph Siemsen
2022-08-09 12:59 ` [RFC PATCH v1 5/9] ram: cadence: add driver for Cadence EDAC Ralph Siemsen
2022-08-09 12:59 ` [RFC PATCH v1 6/9] dts: basic devicetree for Renesas RZ/N1 SoC Ralph Siemsen
2022-08-09 12:59 ` [RFC PATCH v1 7/9] ARM: rzn1: basic support " Ralph Siemsen
2022-08-09 12:59 ` [RFC PATCH v1 8/9] board: schneider: add LCES board support Ralph Siemsen
2022-08-09 12:59 ` [RFC PATCH v1 9/9] tools: Add tool to create Renesas SPKG images Ralph Siemsen
2022-08-09 13:03 ` Pali Rohár
2022-08-09 13:07 ` Pali Rohár
2022-08-09 15:54 ` Ralph Siemsen
2022-08-09 16:06 ` Pali Rohár
2022-08-09 17:02 ` Ralph Siemsen
2022-08-09 17:15 ` Sean Anderson
2022-08-12 17:00 ` Ralph Siemsen
2022-08-12 17:03 ` [RFC PATCH v2 9/9] tools: spkgimage: add Renesas SPKG format Ralph Siemsen
2022-08-13 14:47 ` Sean Anderson
2022-08-14 1:45 ` Ralph Siemsen
2022-08-16 14:33 ` Ralph Siemsen
2022-08-23 3:42 ` Sean Anderson
2022-08-26 15:01 ` Ralph Siemsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANp-EDbfcg-S=j4QiGkSvmH79u0N_heLK7bfo=X0s3mGG-ytbA@mail.gmail.com' \
--to=ralph.siemsen@linaro.org \
--cc=lukma@denx.de \
--cc=seanga2@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).