From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D98AFC433EF for ; Fri, 17 Dec 2021 16:28:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0AF9283007; Fri, 17 Dec 2021 17:28:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="PjVc+2BK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CB88183007; Fri, 17 Dec 2021 17:28:49 +0100 (CET) Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 87B5282F5A for ; Fri, 17 Dec 2021 17:28:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=festevam@gmail.com Received: by mail-ed1-x535.google.com with SMTP id z7so9803148edc.11 for ; Fri, 17 Dec 2021 08:28:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SaFy7BPVlKozHhYF1mG3D/gpJjaW+o53TFLFEl5xVjQ=; b=PjVc+2BKusTfAON+4jZe5vBV7QCJPzLm9KpAM9tbzVoYO2cQNl8wKCEGVM+oAhvFg/ d6hqBRjB/SE3Ocpgli7wLe0+trUWCMKctPlgIg89J9exkib3dRWotNb1uxfNIoL47o9+ yR0vJKDeMcYiIAFnFaw88qO9AnFtUutyWXzAWU73grZUA2NxfwPAUk2M3Z/8DejjwDyp HHPy1vKzTxKYpXeSQ5E9jgOk12QP3GNaxdLkUqb9X8R+OwCtl1VS0e9O2ucKdRecOGEZ zjMVfl2D+U1/Z6FnEPc7+V90v/yPU0jKpzClsH2we60O16UXNXjNwU/s9vJoDbNRkqeg WcKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SaFy7BPVlKozHhYF1mG3D/gpJjaW+o53TFLFEl5xVjQ=; b=bGnQpexi2hJIEKt8JDOGcv8OR6rg9eNacLGKyS0Id5pkVrAwARgM0DeHri3A/b4cqw RRHbgrnxUjs2+z0BytuZSGOqXYnH8wNXzkgALbwXYqhQ3AdP+GjzU1aQbc5SErPsBEdV 2O/utHyLA1rxyVwp42VQT2HqymnF/42bhgeV1C39vxIALxv5zQapIL27UINa9ZXLPwK8 8BHTSh6R2XaR9QzMtBsfHSc8vtetzDKM5BiaSR/Ly7dS6ubV5FrirE3FwoJWJ9opmDyX RhDIHGTcWuhR8ozcGPxDeVc8wXtVJiHDKsYSLsuuYQlHehG/BVixwkd4s0tMNmkf3VkS b4pA== X-Gm-Message-State: AOAM530MTzwlSvBspAs5fTpAnXYB/MUrYAob46OTfypAjTHEllTrl1h6 xFNQBtk2VVPe9d03r/HXRa0eXUKQ14d2P6/X73o= X-Google-Smtp-Source: ABdhPJyaX1g4hNSebkVpvQUWBWvFsLR2+hzLxV6PrFfLY7FRDPEq/XFOAxojT9skMpVu8fLxrpR6Nbr9PLxRdaLDGoc= X-Received: by 2002:a05:6402:604:: with SMTP id n4mr3607696edv.226.1639758525103; Fri, 17 Dec 2021 08:28:45 -0800 (PST) MIME-Version: 1.0 References: <20211217152040.324803-1-angus@akkea.ca> <20211217152040.324803-3-angus@akkea.ca> In-Reply-To: <20211217152040.324803-3-angus@akkea.ca> From: Fabio Estevam Date: Fri, 17 Dec 2021 13:28:33 -0300 Message-ID: Subject: Re: [PATCH 2/3] arch: imx8m: imx-regs.h add the USB regs To: Angus Ainslie Cc: U-Boot-Denx , "NXP i.MX U-Boot Team" , Stefano Babic , Peng Fan , Marek Vasut , Ye Li , Alice Guo , Patrick Wildt , Simon Glass , Frieder Schrempf , =?UTF-8?B?TWFyZWsgQmVow7pu?= , "Ying-Chun Liu (PaulLiu)" , kernel@puri.sm Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Angus, On Fri, Dec 17, 2021 at 12:21 PM Angus Ainslie wrote: > > Add the USB regs for SDP mode > > Signed-off-by: Angus Ainslie > --- > arch/arm/include/asm/arch-imx8m/imx-regs.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/include/asm/arch-imx8m/imx-regs.h b/arch/arm/include/asm/arch-imx8m/imx-regs.h > index 8cb499d3a3..bd474f88a6 100644 > --- a/arch/arm/include/asm/arch-imx8m/imx-regs.h > +++ b/arch/arm/include/asm/arch-imx8m/imx-regs.h > @@ -103,6 +103,11 @@ > IMX_CSPI2_BASE, \ > IMX_CSPI3_BASE > > +#define USB1_BASE_ADDR 0x38100000 > +#define USB2_BASE_ADDR 0x38200000 > +#define USB1_PHY_BASE_ADDR 0x381F0000 > +#define USB2_PHY_BASE_ADDR 0x382F0000 Some time ago I sent a similar patch and the feedback from Marek was that these base addresses should be retrieved from the devicetree instead.