From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87F22ECAAD4 for ; Wed, 31 Aug 2022 13:15:07 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 09E23845F3; Wed, 31 Aug 2022 15:15:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="MF7furLS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E7B1784053; Wed, 31 Aug 2022 15:15:02 +0200 (CEST) Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8B4E1845F3 for ; Wed, 31 Aug 2022 15:14:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@amarulasolutions.com Received: by mail-pf1-x42d.google.com with SMTP id z187so14349068pfb.12 for ; Wed, 31 Aug 2022 06:14:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=dZRFIMhw+PWKO5l9GwcSawiIcD6TX7l7hRaBVAebnT4=; b=MF7furLSDnWs+Iy+GbAIfXRv6oS6uYeUcGHwXhB+P6QlMMN3+rofoLx+2MYBfMws/9 q5cpTzAacAprQBezfaJfKFBAj9kudFsPJSUW+SsJtXF2K3AE9Dk7uN0v3fumitzpvTIN Me5fZo7VjWGB4nhUKWdUZdM4GpLGrWF1fyqcc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=dZRFIMhw+PWKO5l9GwcSawiIcD6TX7l7hRaBVAebnT4=; b=BVRKhHXQB8+fOOl9TPRmhGmmoEB2iidJZUW6ZhHTVRIhFaWMGouwu6RKPmUNFz4Mgg FrgPTiJzwzpA96cqZZLLuE8x1tioqSKcUaCfTcnOOLInQFcvJBg7Q/YwsYmD5KH4jBIK KzXf87Y+yZoZaelZsViWLzjsNARq9l+7wGMTbwsytkBCDJzyUI/uj6aXe0HNSqdfanR7 xb5RtbqETzmDLpDGBeQI14eZOCsit1x8e406Y/Ems57JUkaRHGVNswmppWONXtchdjhE zXp4sDnayGhPUBAoNSZbXGhyMK4J/j7yj1gs4yCNQsas/DEGmE/o0PA+vL8SEMlUUZjF 3/MA== X-Gm-Message-State: ACgBeo0cM6aWbqjL7qqvjQu4dnyoMM48TCSsmNj7BY74XdOi5kSYglzh 8bd4Kma9OlumXi391dopYNmHwAx1Xqi44POdDES++g== X-Google-Smtp-Source: AA6agR71tBbYqFm9m4Exire7xJX97nFryIcjxaK/X2teXTDvAMptO8x3vUQdkauVQmqeWtanofQ8tUf+7GRJhIJlxDw= X-Received: by 2002:a05:6a00:b43:b0:52f:59dc:93 with SMTP id p3-20020a056a000b4300b0052f59dc0093mr26025261pfo.26.1661951696732; Wed, 31 Aug 2022 06:14:56 -0700 (PDT) MIME-Version: 1.0 References: <20220829061928.21895-1-balamanikandan.gunasundar@microchip.com> <20220829061928.21895-9-balamanikandan.gunasundar@microchip.com> In-Reply-To: <20220829061928.21895-9-balamanikandan.gunasundar@microchip.com> From: Michael Nazzareno Trimarchi Date: Wed, 31 Aug 2022 15:14:44 +0200 Message-ID: Subject: Re: [PATCH v2 8/9] ARM: dts: at91: sam9x60ek: Enable NAND support To: Balamanikandan Gunasundar Cc: u-boot@lists.denx.de, sandeep.sheriker@microchip.com, eugen.hristev@microchip.com, dario.binacchi@amarulasolutions.com, mihai.sain@microchip.com, sergiu.moga@microchip.com, claudiu.beznea@microchip.com, hs@denx.de, tudor.ambarus@microchip.com, sjg@chromium.org, ascull@google.com, kettenis@openbsd.org, jh80.chung@samsung.com, peng.fan@nxp.com, ye.li@nxp.com, hari.prasathge@microchip.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi On Mon, Aug 29, 2022 at 8:20 AM Balamanikandan Gunasundar wrote: > > Enable the EBI and NAND flash controller. Define the pinctrl and > partition table > > Signed-off-by: Balamanikandan Gunasundar > --- > arch/arm/dts/sam9x60ek.dts | 103 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 103 insertions(+) > > diff --git a/arch/arm/dts/sam9x60ek.dts b/arch/arm/dts/sam9x60ek.dts > index 54c694bd78..6cb81dd90f 100644 > --- a/arch/arm/dts/sam9x60ek.dts > +++ b/arch/arm/dts/sam9x60ek.dts > @@ -80,6 +80,44 @@ > }; > > pinctrl { > + nand { I can see two tabs here. You don't need it. The indentation go far on the right > + pinctrl_nand_oe_we: nand-oe-we-0 { > + atmel,pins = > + + AT91_PIOD 1 AT91_PERIPH_A (AT91_PINCTRL_NONE | AT91_PINCTRL_SLEWRATE_DIS)>; > + }; > + > + pinctrl_nand_rb: nand-rb-0 { > + atmel,pins = > + ; > + }; > + > + pinctrl_nand_cs: nand-cs-0 { > + atmel,pins = > + ; > + }; > + }; > + > + ebi { > + pinctrl_ebi_data_0_7: ebi-data-lsb-0 { > + atmel,pins = > + + AT91_PIOD 7 AT91_PERIPH_A (AT91_PINCTRL_NONE | AT91_PINCTRL_SLEWRATE_DIS) > + AT91_PIOD 8 AT91_PERIPH_A (AT91_PINCTRL_NONE | AT91_PINCTRL_SLEWRATE_DIS) > + AT91_PIOD 9 AT91_PERIPH_A (AT91_PINCTRL_NONE | AT91_PINCTRL_SLEWRATE_DIS) > + AT91_PIOD 10 AT91_PERIPH_A (AT91_PINCTRL_NONE | AT91_PINCTRL_SLEWRATE_DIS) > + AT91_PIOD 11 AT91_PERIPH_A (AT91_PINCTRL_NONE | AT91_PINCTRL_SLEWRATE_DIS) > + AT91_PIOD 12 AT91_PERIPH_A (AT91_PINCTRL_NONE | AT91_PINCTRL_SLEWRATE_DIS) > + AT91_PIOD 13 AT91_PERIPH_A (AT91_PINCTRL_NONE | AT91_PINCTRL_SLEWRATE_DIS)>; > + }; > + > + pinctrl_ebi_addr_nand: ebi-addr-0 { > + atmel,pins = > + + AT91_PIOD 3 AT91_PERIPH_A (AT91_PINCTRL_NONE | AT91_PINCTRL_SLEWRATE_DIS)>; > + }; > + }; > + Please remove the ebi and nand block so you have one tab less. Then I suggest to align to linux dts and refer to pinctrl instead to create another level of indentation > pinctrl_qspi: qspi { > atmel,pins = > @@ -106,6 +144,71 @@ > }; > }; > > +&ebi { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_ebi_addr_nand &pinctrl_ebi_data_0_7>; > + status = "okay"; > + > + nand_controller: nand-controller { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_nand_oe_we &pinctrl_nand_cs &pinctrl_nand_rb>; > + status = "okay"; > + > + nand@3 { > + reg = <0x3 0x0 0x800000>; > + rb-gpios = <&pioD 5 GPIO_ACTIVE_HIGH>; > + cs-gpios = <&pioD 4 GPIO_ACTIVE_HIGH>; > + nand-bus-width = <8>; > + nand-ecc-mode = "hw"; > + nand-ecc-strength = <8>; > + nand-ecc-step-size = <512>; > + nand-on-flash-bbt; > + label = "atmel_nand"; > + > + partitions { > + compatible = "fixed-partitions"; > + #address-cells = <1>; > + #size-cells = <1>; > + > + at91bootstrap@0 { > + label = "at91bootstrap"; > + reg = <0x0 0x40000>; > + }; > + > + uboot@40000 { > + label = "u-boot"; > + reg = <0x40000 0xc0000>; > + }; > + > + ubootenvred@100000 { > + label = "U-Boot Env Redundant"; > + reg = <0x100000 0x40000>; > + }; > + > + ubootenv@140000 { > + label = "U-Boot Env"; > + reg = <0x140000 0x40000>; > + }; > + > + dtb@180000 { > + label = "device tree"; > + reg = <0x180000 0x80000>; > + }; > + > + kernel@200000 { > + label = "kernel"; > + reg = <0x200000 0x600000>; > + }; > + > + rootfs@800000 { > + label = "rootfs"; > + reg = <0x800000 0x1f800000>; > + }; > + }; > + }; > + }; > +}; > + > &macb0 { > phy-mode = "rmii"; > status = "okay"; > -- > 2.34.1 > -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 michael@amarulasolutions.com __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 info@amarulasolutions.com www.amarulasolutions.com