From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40C4DC433F5 for ; Wed, 24 Nov 2021 17:48:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C4BC38371B; Wed, 24 Nov 2021 18:48:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="C9LQvKY7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2920282FDE; Wed, 24 Nov 2021 18:47:51 +0100 (CET) Received: from mail-ua1-x92b.google.com (mail-ua1-x92b.google.com [IPv6:2607:f8b0:4864:20::92b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8369680F9D for ; Wed, 24 Nov 2021 18:47:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x92b.google.com with SMTP id y5so6749860ual.7 for ; Wed, 24 Nov 2021 09:47:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:from:in-reply-to:references:date:message-id :subject:to:cc; bh=X1Akugu3mgaEwTm1ipMW58oyZJ3r0CiPBh78CznpWUs=; b=C9LQvKY7dbMyf4Td/F8A4kyNyzHCxqMcmp6y2vrZkDSAL5y3s2cyn+CAwKkJ+yQdtl nrSiRjCbAFJSgAybK6DzU+4VoQfB2M4WiiKlIh3BFoIKdAxJtHdHPFTfXxh6g82aWo7Z 9b3ye8vnKqIiJCPrNFTGLUaEvJM6+XoUi9t+Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:sender:from:in-reply-to:references :date:message-id:subject:to:cc; bh=X1Akugu3mgaEwTm1ipMW58oyZJ3r0CiPBh78CznpWUs=; b=0VQZdPmFg7zNPb9mQ99u8i32LuJxn3Nfx4ds06LFIwOjrIvpeJ1hGaWb54ynsfyXMd p+eT39AkGqM2U7Bz4ZNpDsqMQHA9psY0loJBNHp8XuPSjhBbqc49xA832vxUU4cIvSaf cn0fayCI2QCwaC5SDKrhVKSDCMuqpBLTNVKliCTGnQLIpiK9H6lX1vW/DgMDgWkR0Nef ES3RjzEWryyzWtcOQcsql9WQrgU8ngp/WMTif5HigrzYSlfwKRXQh4n0Wg71J/vh74sU pB9MuxbCmpDfieD8wud6mpNml9xc/M0cEaxx7bjW6aGwSO69pO5TblzqxApb1KC9oOuw G71w== X-Gm-Message-State: AOAM531z9sZped7x9s1CqTleDwHP/tBKx0fdkw070smDKuzs8CxgoShj 8anpJwrXCzStMEBxOc87lLnh+O4a1cg1hYF5bPYRoPb40Q0= X-Google-Smtp-Source: ABdhPJyTSgF59UUoDBTbAs0k/zU2sAbSserxLpn/36Ve8qCqouXWo18HNX+oKkHjI5GgOM/tUkKB2cpFAjzi3Biwgl4= X-Received: by 2002:ab0:66cd:: with SMTP id d13mr13194012uaq.140.1637776065163; Wed, 24 Nov 2021 09:47:45 -0800 (PST) Received: from 480794996271 named unknown by gmailapi.google.com with HTTPREST; Wed, 24 Nov 2021 12:47:44 -0500 MIME-Version: 1.0 From: Simon Glass In-Reply-To: <89fdf34f-5403-ac21-1c78-ed4d766d648e@gmx.de> References: <89fdf34f-5403-ac21-1c78-ed4d766d648e@gmx.de> <20210919214937.3829422-1-sjg@chromium.org> <20210919214937.3829422-2-sjg@chromium.org> Date: Wed, 24 Nov 2021 12:47:44 -0500 X-Google-Sender-Auth: Iae4oJBfV32jjGK9sRpesEFWHF8 Message-ID: Subject: Re: [PATCH v4 1/5] command: Use a constant pointer for the help To: Heinrich Schuchardt Cc: Jagan Teki , Simon Glass , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 9/19/21 23:49, Simon Glass wrote: > This text should never change during execution, so it makes sense to > use a const char * so that it can be declared as const in the code. > Update struct cmd_tbl with a const char * pointer for 'help'. > > We cannot make usage const because of the bmode command, used on mx53ppd > for example. > > Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt > --- > > (no changes since v2) > > Changes in v2: > - Explain why 'usage' cannot be const > > include/command.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied to u-boot-dm, thanks!