From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA355C00140 for ; Mon, 15 Aug 2022 17:38:11 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 654E4845D0; Mon, 15 Aug 2022 19:38:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="QFTb26ri"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CA53D844C0; Mon, 15 Aug 2022 19:38:07 +0200 (CEST) Received: from mail-yw1-x1132.google.com (mail-yw1-x1132.google.com [IPv6:2607:f8b0:4864:20::1132]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1E24283564 for ; Mon, 15 Aug 2022 19:38:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-328303afa6eso90259547b3.10 for ; Mon, 15 Aug 2022 10:38:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=pcf3cu6Jn2zWbRLbLxAtIqPIgwRu01p93xUZkgjVoMc=; b=QFTb26riU/H7Yu0bPt4YgkL/SjzEX9BK1iNDrVfjjGQjkSDTASwn2ZWav6HbEW2lPP Z4qqYVVN8fonGvt4alGPSUxSAtmN4iz7QvzFlhyGdGj6QIQ9tn1WXiI6vbHruChOFVbA G3kDsJwX/qRMVltl670RGIAh/P9q32WcW168k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=pcf3cu6Jn2zWbRLbLxAtIqPIgwRu01p93xUZkgjVoMc=; b=cNGOzTPo9i4La2poDUICw5XcOPX2JUgu60W4EF2TpaG7uAXH5Ophq7SMfNYrycaMwz oVpYI19sxXWVuI/IpzDsxDXYEyuFphKxZVlftrbXY2TwG8N9WhlZ/k94ho9gvyymNjj0 04I8mrRjd7f1mn334yq52zbNFTn7AQ+kZOPwITXRdNCeYHvHbjHPludrdFvxfkoDpZhp owk23EGtX/jYg8gc+HFvIfHX8JegWtoqgiuqvcCHCg2BmAJSw7NZvet880DTxmUrj1Ef q89TBXkxiVi5uo8anE2XwS6nR8qcEkX3x3aKZQ1KYZPEOdQglPf02W0MxshY//9lRQF/ J/Fg== X-Gm-Message-State: ACgBeo2NHHKyPqQUwiXEZyFgi9vuvMOo+YaUwJsi3ev359XnYi4ORhW1 4XFm3hpOltOTlKx0boWUgNBusbUFwbXpLOPXyE9Lqw== X-Google-Smtp-Source: AA6agR4IG0Ssen10NxQN03jzterm/PTNmku6C2vIOy+KWvaGW9+F4La062kUfUWwYLevm/vCbBQFlym4/qx7V/x+wSE= X-Received: by 2002:a25:6003:0:b0:68c:870b:2405 with SMTP id u3-20020a256003000000b0068c870b2405mr1350626ybb.9.1660585083389; Mon, 15 Aug 2022 10:38:03 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Simon Glass Date: Mon, 15 Aug 2022 11:37:52 -0600 Message-ID: Subject: Re: [PATCH] image-fit: don't set compression if it can't be read To: Daniel Golle Cc: U-Boot Mailing List , Alexandru Gagniuc , Chia-Wei Wang , Sean Anderson , Heinrich Schuchardt , Joel Stanley Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Mon, 15 Aug 2022 at 04:39, Daniel Golle wrote: > > fit_image_get_comp() should not set value -1 in case it can't read > the compression node. Instead, leave the value untouched in that case > as it can be absent and a default value previously defined by the > caller of fit_image_get_comp() should be used. > > As a result the warning message > WARNING: 'compression' nodes for ramdisks are deprecated, please fix your .its file! > no longer shows if the compression node is actually absent. > > Signed-off-by: Daniel Golle > --- > boot/bootm.c | 6 ++---- > boot/image-fit.c | 3 +-- > cmd/ximg.c | 7 ++----- > 3 files changed, 5 insertions(+), 11 deletions(-) Reviewed-by: Simon Glass