From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1963C433F5 for ; Wed, 29 Dec 2021 13:37:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 724E982F70; Wed, 29 Dec 2021 14:37:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Ulpac3K5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6EE52830C0; Wed, 29 Dec 2021 14:36:47 +0100 (CET) Received: from mail-ua1-x932.google.com (mail-ua1-x932.google.com [IPv6:2607:f8b0:4864:20::932]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2FB7A83433 for ; Wed, 29 Dec 2021 14:36:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x932.google.com with SMTP id az37so16462861uab.12 for ; Wed, 29 Dec 2021 05:36:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=4ZaSFccytX+FQequhjKisFNcoe1J9EltVNYpdQjhf4c=; b=Ulpac3K5HJSBXHjS/5G3n83QLfvpr1OzJHM8VvUgQIXaRY3nwzG9XVpJH965FvyYLy gpXAYxDK6+SFxilzfNqd4yyIRLgqaCfA54qqTwKl65C08w5tWxZwHbOp3bvPF/+SFAR/ ypW/wOhagpRIhggnC2eCgJfXMfPlPU4zO/vjw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=4ZaSFccytX+FQequhjKisFNcoe1J9EltVNYpdQjhf4c=; b=zt2uo7QDzvIFDD0vuk4NiaJSKX+Rsj6WT9i9ciDT++UTGfgi8QsMF/DlRx28XEI6h9 ZmXp2mkh1HyohjAjtuoFeRih1KBgdzN49pj3Aq4m8IY8R0pufk4Q1FewJqP60JNOlMft adfa5fCDuTSOFQw2QsABehQJnd1nhnmiQTWDYTi0MNfpgskhzEyoDpg2xWEfDNbYWw71 wcTCql2PK7c1FmexDQ5iLfrjdwa+ZjVDWkiwIyCVddbggyG1uUl52Agtx3y5ghTngEfl o+O881djz42adsT2JnViiqi1qYJbZ5aXjYPHPQXa4vnLrtPd0qaGY7NR07V7iNaMx2lP +FIw== X-Gm-Message-State: AOAM530VlfhZPgbtnbNakCNNYQYFcSETl0bah/HW/yyEycqtrMzWZLUo abOfbEK2EFiMQcEttfhTz9LPLll/sN9yddOk7QXsyg== X-Google-Smtp-Source: ABdhPJxRBFHmG6kvxtvHu03fQt5Y3WFU35RYsmpHCOZN78s6+RiYlK786I39DMDoVn98vkQP3HQSno5NUYkF8zbl9ZU= X-Received: by 2002:ab0:3301:: with SMTP id r1mr7876907uao.96.1640785000820; Wed, 29 Dec 2021 05:36:40 -0800 (PST) MIME-Version: 1.0 References: <20211204155657.2913911-1-sjg@chromium.org> <20211204155657.2913911-15-sjg@chromium.org> <31befeb9-2678-8f56-4067-829f1fd6c2d3@gmx.de> <20211220023812.GB7671@laputa> In-Reply-To: <20211220023812.GB7671@laputa> From: Simon Glass Date: Wed, 29 Dec 2021 06:36:28 -0700 Message-ID: Subject: Re: [PATCH v5 21/28] efi: Support the efi command in the app To: AKASHI Takahiro , Simon Glass , Heinrich Schuchardt , U-Boot Mailing List , Ilias Apalodimas , Christian Melki , Bin Meng , Tom Rini , Alexander Graf Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Takahiro, On Sun, 19 Dec 2021 at 19:38, AKASHI Takahiro wrote: > > On Fri, Dec 17, 2021 at 09:37:21AM -0700, Simon Glass wrote: > > Hi Heinrich, > > > > On Thu, 9 Dec 2021 at 13:27, Heinrich Schuchardt wrote: > > > > > > On 12/4/21 07:56, Simon Glass wrote: > > > > At present the 'efi' command only works in the EFI payload. Update it to > > > > work in the app too, so the memory map can be examined. > > > > > > cmd/efi.c seems to be duplicating function do_efi_show_memmap(). In a > > > future patch we should try to move to using common code for commands efi > > > and efidebug. > > > > Yes and that depends on EFI_LOADER. Perhaps one day we can have a > > common helper for this, e.g. in lib/efi ? > > It will inevitably means that we should stick to *UEFI* interfaces > (not EFI_LOADER's internal interfaces like efi_xxx_yyy()) to implement > those commands, including most of efidebug subcommands. That seems right to me, although of course there may be some 'inside knowledge' for some subcommands. Regards, Simon