From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A2BDC54EBD for ; Thu, 12 Jan 2023 23:44:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 667F685156; Fri, 13 Jan 2023 00:44:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="K2rwhDXc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1E3FA85156; Fri, 13 Jan 2023 00:43:51 +0100 (CET) Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 105578529D for ; Fri, 13 Jan 2023 00:43:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ej1-x62b.google.com with SMTP id hw16so36712201ejc.10 for ; Thu, 12 Jan 2023 15:43:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uYnoIkFigkkSJsDXl92S+byFdQL48cchrLPoYkJdfNU=; b=K2rwhDXcQPTdGyZ1aoheuRRybjrZNkr97OcdkP9urep6m4AO6Pc9NOBxWxBFnTp/v5 ue+6RwEF3pD2ysmJLHqR62EuzIc17d2z782JohlcF6SAksFl9fNkg+BPFTXzZ0nSVTrj xC/GK52Osn+eJG2ddmEMQG3r6gmXDgYy7qMO8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uYnoIkFigkkSJsDXl92S+byFdQL48cchrLPoYkJdfNU=; b=Ur2Lc/h0PkwHqoohgU1fyzBGk8bjUpX6Pr5ZZiybxOzIWLK/NIDi+TZjSrJRhqF9HW P3niL9gHwRYgg+ji9PHhl8O9qwRIsjpV8PQpMFDeTpZPExBP0dCnxHslsjTv4Xjyq6dm zuey3aHGGrad7AIeeaqzfWGPGvYE02m2XPsYkSsQLsL337tbozmoAkPBvvR/rENEb/5i UEJCbqcGdeMhiRc9AEaLqEz7kNKAIE+++mVJjJ6Lb9+QuR7W+dNEKoDoP4UAfAoxwO6k EIvwdJbMxZN/5mZUg1XZ8Py16/D9iA6EZVFKeQubU6Y9k5jYJXAD7Ex/7FqJrJKY0FF0 Yi3A== X-Gm-Message-State: AFqh2kpxlQX60nn9dZ27R+n7CBVmogMn4DjBAhrV4NgWiZGgEutOES3o 3Wfep+KJeDUrP3JppEwPugQo2ENXyIJbPh/TzM6ouL6dwwrLpcWG X-Google-Smtp-Source: AMrXdXsg1Fc9G7D/5+CynFj2Po9OKSs1YzTJdOThfbElv0wXGtQnkclGpWYBZGabzh279z2djupTz2AkU9St4aW4+Dk= X-Received: by 2002:a17:906:cb85:b0:7ea:608f:23bd with SMTP id mf5-20020a170906cb8500b007ea608f23bdmr8813581ejb.221.1673567026035; Thu, 12 Jan 2023 15:43:46 -0800 (PST) MIME-Version: 1.0 References: <20221107192055.21669-1-abdellatif.elkhlifi@arm.com> <20221122131751.22747-1-abdellatif.elkhlifi@arm.com> <20221122131751.22747-4-abdellatif.elkhlifi@arm.com> <20221124132115.GA393@e121910.cambridge.arm.com> <20221219111251.GA22370@e121910.cambridge.arm.com> In-Reply-To: From: Simon Glass Date: Thu, 12 Jan 2023 16:43:32 -0700 Message-ID: Subject: Re: [PATCH v8 03/10] arm_ffa: introduce Arm FF-A low-level driver To: Rob Herring Cc: Abdellatif El Khlifi , ilias.apalodimas@linaro.org, jens.wiklander@linaro.org, achin.gupta@arm.com, trini@konsulko.com, xueliang.zhong@arm.com, nd@arm.com, u-boot@lists.denx.de Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Rob, On Wed, 11 Jan 2023 at 19:10, Rob Herring wrote: > > On Mon, Dec 19, 2022 at 1:21 PM Simon Glass wrote: > > > > Hi Abdellatif, > > > > On Mon, 19 Dec 2022 at 04:12, Abdellatif El Khlifi > > wrote: > > > > > > On Mon, Dec 05, 2022 at 09:49:30AM -0600, Rob Herring wrote: > > > > On Sun, Dec 4, 2022 at 1:22 PM Simon Glass wrote= : > > > > > > > > > > Hi Rob, > > > > > > > > > > On Tue, 29 Nov 2022 at 05:22, Rob Herring wrote= : > > > > > > > > > > > > On Fri, Nov 25, 2022 at 3:18 PM Simon Glass = wrote: > > > > > > > > > > > > > > Hi Abdellatif, > > > > > > > > > > > > > > On Thu, 24 Nov 2022 at 06:21, Abdellatif El Khlifi wrote: > > > > > > > > > > > > > > > > On Tue, Nov 22, 2022 at 07:09:16PM -0700, Simon Glass wrote= : > > > > > > > > > should be called 'priov' and should beHi Abdellatif, > > > > > > > > > > > > > > > > > > > > > > > [..] > > > > > > > > > > > > > > > > > +/** > > > > > > > > > > + * ffa_device_get - create, bind and probe the arm_ffa= device > > > > > > > > > > + * @pdev: the address of a device pointer (to be fille= d when the arm_ffa bus device is created > > > > > > > > > > + * successfully) > > > > > > > > > > + * > > > > > > > > > > + * This function makes sure the arm_ffa device is > > > > > > > > > > + * created, bound to this driver, probed and ready to = use. > > > > > > > > > > + * Arm FF-A transport is implemented through a single = U-Boot > > > > > > > > > > + * device managing the FF-A bus (arm_ffa). > > > > > > > > > > + * > > > > > > > > > > + * Return: > > > > > > > > > > + * > > > > > > > > > > + * 0 on success. Otherwise, failure > > > > > > > > > > + */ > > > > > > > > > > +int ffa_device_get(struct udevice **pdev) > > > > > > > > > > +{ > > > > > > > > > > + int ret; > > > > > > > > > > + struct udevice *dev =3D NULL; > > > > > > > > > > + > > > > > > > > > > + ret =3D device_bind(dm_root(), DM_DRIVER_GET(ar= m_ffa), FFA_DRV_NAME, NULL, ofnode_null(), > > > > > > > > > > + &dev); > > > > > > > > > > > > > > > > > > Please add a DT binding. Even if only temporary, we need = something for this. > > > > > > > > > > > > > > > > Thanks for the feedback. I'm happy to address all the comme= nts. > > > > > > > > > > > > > > > > Regarding DT binding and FF-A discovery. We agreed with Lin= aro and Rob Herring > > > > > > > > about the following: > > > > > > > > > > > > > > > > - DT is only for what we failed to make discoverable. For h= ardware, we're stuck > > > > > > > > with it. We shouldn't repeat that for software interfaces= . This approach is > > > > > > > > already applied in the FF-A kernel driver which comes wit= h no DT support and > > > > > > > > discovers the bus with bus_register() API [1]. > > > > > > > > > > > > > > This may be the UEFI view, but it is not how U-Boot works. Th= is is not something we are 'stuck' with. It is how we define what is presen= t on a device. This is how the PCI bus works in U-Boot. It is best practice= in U-Boot to use the device tree to make this things visible and configura= ble. Unlike with Linux there is no other way to provide configuration neede= d by these devices. > > > > > > > > > > > > Where do you get UEFI out of this? > > > > > > > > > > I assume it was UEFI as there was no discussion about this in U-B= oot. > > > > > Which firmware project was consulted about this? > > > > > > > > > > > > > > > > > It is the discoverability of hardware that is fixed (and we are= stuck > > > > > > with). We can't change hardware. The disoverability may be PCI > > > > > > VID/PID, USB device descriptors, or nothing. We only use DT whe= n those > > > > > > are not sufficient. For a software interface, there is no reaso= n to > > > > > > make them non-discoverable as the interface can be fixed (at le= ast for > > > > > > new things like FF-A). > > > > > > > > > > Here I am talking about the controller itself, the top-level node= in > > > > > the device tree. For PCI this is a device tree node and it should= be > > > > > the same here. So I am not saying that the devices on the bus nee= d to > > > > > be in the device tree (that can be optional, but may be useful in= some > > > > > situations where it is status and known). > > > > > > > > Sure, the PCI host bridges are not discoverable, have a bunch of > > > > resources, and do need to be in DT. The downstream devices only do = if > > > > they have extra resources such as when a device is soldered down on= a > > > > board rather than a standard slot. > > > > > > > > > We need something like: > > > > > > > > > > ff-a { > > > > > compatible =3D "something"; > > > > > }; > > > > > > > > > > I don't know what mechanism is actually used to communicate with = it, > > > > > but that will be enough to get the top-level driver started. > > > > > > > > There's discovery of FF-A itself and then discovery of FF-A feature= s > > > > (e.g. partitions). Both of those are discoverable without DT. The > > > > first is done by checking the SMCCC version, then checking for FF-A > > > > presence and features. Putting this into DT is redundant. Worse, wh= at > > > > if they disagree? > > > > > > Hi Simon, > > > > > > Do you agree with Rob, Ilias and myself that it makes more sense > > > FF-A bus is discovered without a DT node and following the same appro= ach as > > > Linux ? (FF-A bus doesn't have a HW controller and is a purely SW bus= , > > > no configuration/description needed at DT level). > > > > > > Your suggestions are always welcome. > > > > I'm sorry I don't agree with that. It does need a compatible string, > > like PCI has. You can just add it in U-Boot if Linux won't accept the > > binding. > > It's not like PCI as the host side of PCI has non-discoverable resources. OK I see. It is certainly an edge case. > > This all could have been designed better, but hindsight is 20/20 and > things evolved step by step. There are a bunch of firmware services > that are all behind SMCCC. The first (upstream) was PSCI. IIRC, SMCCC > was invented a bit after that, but generalized PSCI for other > services. Since then more have been added. More services get added one > by one and yes we added bindings for them. Because what's one more... > But that really needs to stop. We're stuck with h/w that's not > discoverable, there's zero reason to do that with s/w interfaces. If > we could redo everything, we'd have a node for SMCCC and that's it > unless there's h/w resources provided to the rest of DT. But we can't, > so SMCCC is discovered by the presence of PSCI. I understand the background here, but if we don't take a stand on this, this sort of thing will continue. Just because something works in Linux does not mean that the binding (or lack of it) is good. The reasons to do this are: - avoids needing to manually call device_bind() - avoids extra plumbing in U-Boot - provides visibility into what is in the system, by looking at the DT, like documentation - DT is how devices are bound in U-Boot You can see the problem if you look at ffa_device_get(). It is called from ffa_bus_discover() which is a new addition into the board_init list. We are trying to remove this list and certainly don't want new things added!! We don't need to change this in the Linux implementation, just add a top-level DT node for U-Boot. I don't understand why that is such a big problem? Regards, Simon