From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B733C433F5 for ; Fri, 30 Sep 2022 13:30:04 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1CDF884DB5; Fri, 30 Sep 2022 15:29:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="LZAZ5aJh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8AABE84D81; Fri, 30 Sep 2022 15:29:14 +0200 (CEST) Received: from mail-oo1-xc34.google.com (mail-oo1-xc34.google.com [IPv6:2607:f8b0:4864:20::c34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A6A3184D7F for ; Fri, 30 Sep 2022 15:29:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oo1-xc34.google.com with SMTP id c22-20020a4a4f16000000b00474a44441c8so2224827oob.7 for ; Fri, 30 Sep 2022 06:29:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=Jpco8fjeaDNcBM/nOozp/jfKXpqrgqO4Vmtg6VqZBMM=; b=LZAZ5aJhwm0gdoK8mNUHR0Iir9A8E00hKHg347ednVuyosDL6QYJsdPhGLvLSTuUQq 6XCdTFpAO2HRaynPwb3YiMhJdXY9UukExBNI19cew1Sqj9Vg6lFVJQiNLtiVbZvkfk4w H/kWO41a0H2XpudgorloNhF4ryhCXy5vxDOp4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=Jpco8fjeaDNcBM/nOozp/jfKXpqrgqO4Vmtg6VqZBMM=; b=g31ZijWfsE2lRfFzfNaenjjNHan7Is0OqAcqEWvxdKU8HGEQ1PcGfKV4BnwpiF9qUW 9VFxVLFxiHPKPLlNGBCx13XyV/dl+qwSwH1ZuEONoWZmNXsf6eGrU0yFpdJ+eOW3aU/y t6aSogaI5bPE4MZjqWlfUyMDAoJnNkKj+b/sTAFChiu4cpVs9rxGhl2rjJn6MiHp+Yh2 M9DvZBlhk476P3my0I8lLdEf8OJHWi23m9ve8SXp+vyfP9nT1yO2J2yBiYTceckD7Ud4 Ht4W/4L9DE3Z+OjVSic8a30LbpDcknD1gbNsRomCJ3n355CbI0DmxZogLQEMrSDYuFxA QkaQ== X-Gm-Message-State: ACrzQf1AEafyq60myVfmuf9g4i1PHlCxPd7bwc5Xg9pEFKfYbVXJZeZF gpaR8Eq1RzrrWaiZiJa3ha163Z6iGCGXMomyklellQ== X-Google-Smtp-Source: AMsMyM4s8gNt+lHShHzoh1RRwWv9ORxTNLjClpMgHYBT2yg1FZzr0MCvmUUbTgFxY0ui5VOmnFgLX3166ZEdvMF00Zk= X-Received: by 2002:a4a:528f:0:b0:475:8c71:2b36 with SMTP id d137-20020a4a528f000000b004758c712b36mr3336908oob.39.1664544544864; Fri, 30 Sep 2022 06:29:04 -0700 (PDT) MIME-Version: 1.0 References: <20220925150248.2524421-1-sjg@chromium.org> <20220925150248.2524421-10-sjg@chromium.org> <53180fd5-5cc6-7e6f-e86f-914ebf8732f8@gmx.de> <20220929150540.GC3044094@bill-the-cat> <20220930125624.GQ3044094@bill-the-cat> In-Reply-To: <20220930125624.GQ3044094@bill-the-cat> From: Simon Glass Date: Fri, 30 Sep 2022 07:28:52 -0600 Message-ID: Subject: Re: [PATCH 09/45] CI: Install pyelftools for builds To: Tom Rini Cc: Heinrich Schuchardt , AKASHI Takahiro , Huang Jianan , Joel Stanley , Rick Chen , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Fri, 30 Sept 2022 at 06:56, Tom Rini wrote: > > On Thu, Sep 29, 2022 at 05:55:54PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Thu, 29 Sept 2022 at 09:05, Tom Rini wrote: > > > > > > On Wed, Sep 28, 2022 at 04:20:41AM -0600, Simon Glass wrote: > > > > Hi Heinrich, > > > > > > > > On Mon, 26 Sept 2022 at 00:35, Heinrich Schuchardt wrote: > > > > > > > > > > On 9/25/22 17:02, Simon Glass wrote: > > > > > > Binman needs this module to build sandbox_vpl so install it in the > > > > > > before_script and in the world build. The existing pip install is too > > > > > > late for the buildman invocation. > > > > > > > > > > > > Add it to the docker file for the future. > > > > > > > > > > > > Signed-off-by: Simon Glass > > > > > > --- > > > > > > > > > > > > .gitlab-ci.yml | 2 ++ > > > > > > tools/docker/Dockerfile | 1 + > > > > > > 2 files changed, 3 insertions(+) > > > > > > > > > > > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > > > > > > index 8e94bf8d4e8..47e36edcc4a 100644 > > > > > > --- a/.gitlab-ci.yml > > > > > > +++ b/.gitlab-ci.yml > > > > > > @@ -34,6 +34,7 @@ stages: > > > > > > # If we've been asked to use clang only do one configuration. > > > > > > - export UBOOT_TRAVIS_BUILD_DIR=/tmp/${TEST_PY_BD} > > > > > > - echo BUILD_ENV ${BUILD_ENV} > > > > > > + - pip install pyelftools > > > > > > > > > > Why do we need pip install here? Is pyelftools used outside the Docker > > > > > image to which you add pyelftools below? > > > > > > > > We don't need it if Tom wants to regen the docker image, but I'm not > > > > sure how often he does that. So this change actually makes CI work, in > > > > either case. > > > > > > I would re-generate the CI image as part of the series, and we should > > > really do this separate and drop the pip install pyelftools we already > > > have, too. > > > > OK, shall I resend this patch accordingly or will you just change it? > > Or should I split into two patches, one to add to Dockerfile (I hate > > the capital D!) and one to remove the pip install? > > In v2 of the series, doing all of this as patch #1 will make my life > easier, how about that? Yes OK. Regards, Simon