From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA1ECC74A5B for ; Sat, 18 Mar 2023 20:20:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DB5F3858EF; Sat, 18 Mar 2023 21:20:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="GMhRJdNC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2450A858F1; Sat, 18 Mar 2023 21:20:33 +0100 (CET) Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4D2DE85894 for ; Sat, 18 Mar 2023 21:20:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-yb1-xb2e.google.com with SMTP id y5so9101866ybu.3 for ; Sat, 18 Mar 2023 13:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1679170829; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7xrOTPpMqgt7Sl+dbm4u1Q1Rue9Jn4gGujtMla7cKpg=; b=GMhRJdNCEMFIq8Qq/r3iItkTbwsgurGXZAq6+1yRPpneBg3JAbcmiRvRkDDJHz213w kKkLnWxNRoMdN7nXe5d5BcRKbDH0ckmokquF2hpzP3/IINZ6tRwHkW+sM13tUrFofs3T Jn1eGNA2Nd27FeolkJA9lXyggFAjnL40cAE6w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679170829; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7xrOTPpMqgt7Sl+dbm4u1Q1Rue9Jn4gGujtMla7cKpg=; b=eHrRn94FLWDwSswJSwaLqHiEjdMgyGSB7wizml7cNZx/r2W4V6KfcISmrcsBktHycV tPTDSkw1UNygDykzdxvybCnPvMUQSMnM5fUz7cba2xmUOSFNXdMqEZ2HePH1bDVNzBoZ npjpUHHkiPblOFMPPRY9EyXOytxWyLU5kDF38PLoupeWuNqDBt3rj2jlhhS856XkPLeZ C/RhOhzLMKeKE2twkAm0YVJRBjECWNRa3opvVtGpSnugp91KeAQ7KbtxPrw88b6WbZTP 3qBKHnJm+2UEyi4RtPF31DnaJ22viARBI9dqwr/lVfmsXjU9EvMop1OKCeXe2YHKwlhZ S4iA== X-Gm-Message-State: AO0yUKXuAKCw85L8qYcgvWSJtvdGNStPxJbqpiHul7A6jA5cOr9tPb86 CjvsmNXEMyOtgzdBoPaafBcbEAhvdhMddFKW+zz/+Q== X-Google-Smtp-Source: AK7set/Sq/Z5wNW5+PSBqLo46+jBSj/5xgZ7cROug2hTSWoEufsngCREIgOf6k8K/1WO0U4GrNqUTuChEgTX7JUUEkI= X-Received: by 2002:a5b:b03:0:b0:ac2:a7a7:23c3 with SMTP id z3-20020a5b0b03000000b00ac2a7a723c3mr1460909ybp.12.1679170828713; Sat, 18 Mar 2023 13:20:28 -0700 (PDT) MIME-Version: 1.0 References: <20230317201222.734132-1-rasmus.villemoes@prevas.dk> In-Reply-To: <20230317201222.734132-1-rasmus.villemoes@prevas.dk> From: Simon Glass Date: Sun, 19 Mar 2023 09:20:12 +1300 Message-ID: Subject: Re: [PATCH] gpio: allow passing NULL to gpio_request_by_line_name() to search all gpio controllers To: Rasmus Villemoes Cc: u-boot@lists.denx.de, Andrew Jeffery , Eddie James , Tom Rini Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Rasmus, On Fri, 17 Mar 2023 at 14:13, Rasmus Villemoes wrote: > > The API is more convenient to use if one doesn't have to know upfront > which gpio controller has a line with the name one is searching for, > and arrange to look that device up somehow. Or implement this loop > oneself. > > Signed-off-by: Rasmus Villemoes > --- > drivers/gpio/gpio-uclass.c | 7 +++++++ > include/asm-generic/gpio.h | 3 ++- > 2 files changed, 9 insertions(+), 1 deletion(-) Reviewed-by: Simon Glass What is a line name? I don't see any mention of its purpose in the binding doc[1]. Regards, Simon [1] https://github.com/devicetree-org/dt-schema/blob/3c35bfee83c2e38e2ae7af5f83eb89ca94a521e8/dtschema/schemas/gpio/gpio.yaml#L17