From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3C7DECAAD2 for ; Tue, 30 Aug 2022 02:32:09 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F33A7849C3; Tue, 30 Aug 2022 04:30:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="npiP0u2l"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 34875849A8; Tue, 30 Aug 2022 04:30:36 +0200 (CEST) Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 357A78497F for ; Tue, 30 Aug 2022 04:30:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-33dc345ad78so240966937b3.3 for ; Mon, 29 Aug 2022 19:30:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=s+tDcE2PWxJAVL+rdcw9mbLvnYaMxlGe/DkdJrSocz8=; b=npiP0u2lO7BgboDKiWfWSgViGO36qI/XMhyef43wHI8XntvYGahBAT9yQJg3ql77AG 3Qxqv2ChFaRjEQGWHlvs8KYrYeaWpGLdxbu8+lgxcatZBKpnMItGM01NFPyL5dt7+fir bcoiB8oFgiKx62ILDmLybHEho/y4C6NXlxmgE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=s+tDcE2PWxJAVL+rdcw9mbLvnYaMxlGe/DkdJrSocz8=; b=dZHt5Ve3PxAnnOee6i2P7HbmvXFLXHoy7lVUYk3E6YiNP5oZP4bWLx9SQVf1H5iWlk Q0TJaRnlhXaASY7LyP5aVVqPBMG8J0lewSjHd4Qq/IsvB4DaFgrHSKdLtGf0p/EWOdge hWmep+CQYak/BX/FqGkzIv+hgzRaiNikk0STi08xXE4eNQ4wN4YPsCPam31/H+TvPr4D nI3wJb3Kqf0v8UopXXLsuWc2pQiiyoaKnKk/uHN7YdnE7msOBXs0mYTZYLT3cjaMtZwK d3g42MaOYusL3ayp6TiTH75KGAUhFJq7DS/aX5xkHhTvF6CAsBVt+XT2keb/d83t9AHb kmuQ== X-Gm-Message-State: ACgBeo20RuClUclO0Tw+wl0YyagFZjQUE7o/xSRdiZjrxuQk1DVpp2Cj 3Vn08ltOm3WGGTw+Ztw+41X/3pFzYHylJkpQDYH2mQ== X-Google-Smtp-Source: AA6agR6A77zii/C2CC92XOOXTiZoguCCHK/mOtuNRiyPuat3OWq+ls95sZy6faX+saMC1xTbxRUFqQvr7BJ8PPsJD5w= X-Received: by 2002:a25:558:0:b0:696:4e84:6367 with SMTP id 85-20020a250558000000b006964e846367mr9884103ybf.412.1661826628649; Mon, 29 Aug 2022 19:30:28 -0700 (PDT) MIME-Version: 1.0 References: <20220829061928.21895-1-balamanikandan.gunasundar@microchip.com> In-Reply-To: From: Simon Glass Date: Mon, 29 Aug 2022 20:30:16 -0600 Message-ID: Subject: Re: [PATCH v2 0/9] Add DM support for atmel NAND driver To: Michael Nazzareno Trimarchi Cc: Balamanikandan Gunasundar , U-Boot Mailing List , Sandeep Sheriker M , Eugen Hristev , Dario Binacchi , mihai.sain@microchip.com, sergiu.moga@microchip.com, Claudiu Beznea , Heiko Schocher , tudor.ambarus@microchip.com, Andrew Scull , Mark Kettenis , Jaehoon Chung , Peng Fan , Ye Li , hari.prasathge@microchip.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi, On Mon, 29 Aug 2022 at 00:41, Michael Nazzareno Trimarchi wrote: > > Hi > > On Mon, Aug 29, 2022 at 8:19 AM Balamanikandan Gunasundar > wrote: > > > > Change include: > > > > - Adapt GPIO descriptor apis for U-Boot. Use > > gpio_request_by_name_nodev, dm_gpio_get_value etc. > > - Use U_BOOT_DRIVER instead of platform_driver. > > - Replace struct platform_device with struct udevice > > - Check the status of nfc exec operation by polling the status > > register instead of interrupt based handling > > - DMA operations not supported. Remove it > > - Adapt DT parsing to U-Boot APIs > > > > v2: > > > > - Add linux reference version in the commit message from which the > > driver is ported from > > - Reword the commit message to describe the changes clearly > > > > Thank you to repost it again, I will review it and try to include soon > > Michael > > > Balamanikandan Gunasundar (9): > > nand: atmel: Add DM based NAND driver > > nand: atmel: Add pmecc driver > > mfd: syscon: Add atmel-matrix registers definition > > memory: atmel-ebi: add Atmel EBI (External Bus Interface) driver > > mfd: syscon: atmel-smc: Add driver for atmel SMC > > configs: at91: sam9x60ek: Enable DM based nand driver > > ARM: dts: at91: sam9x60: Add nodes for EBI and NAND > > ARM: dts: at91: sam9x60ek: Enable NAND support > > board: sam9x60ek: remove nand init from board file > > > > MAINTAINERS | 1 + > > arch/arm/dts/sam9x60.dtsi | 42 + > > arch/arm/dts/sam9x60ek.dts | 103 + > > board/atmel/sam9x60ek/sam9x60ek.c | 59 - > > configs/sam9x60ek_mmc_defconfig | 9 +- > > configs/sam9x60ek_nandflash_defconfig | 9 +- > > configs/sam9x60ek_qspiflash_defconfig | 8 +- > > drivers/Kconfig | 2 + > > drivers/Makefile | 1 + > > drivers/memory/Kconfig | 7 + > > drivers/memory/Makefile | 1 + > > drivers/memory/atmel_ebi.c | 37 + > > drivers/mfd/Kconfig | 4 + > > drivers/mfd/Makefile | 1 + > > drivers/mfd/atmel-smc.c | 364 +++ > > drivers/mtd/nand/raw/Kconfig | 8 + > > drivers/mtd/nand/raw/Makefile | 1 + > > drivers/mtd/nand/raw/atmel/Makefile | 5 + > > drivers/mtd/nand/raw/atmel/nand-controller.c | 2293 ++++++++++++++++++ > > drivers/mtd/nand/raw/atmel/pmecc.c | 965 ++++++++ > > drivers/mtd/nand/raw/atmel/pmecc.h | 94 + > > include/configs/sam9x60ek.h | 5 - > > include/linux/mfd/syscon/atmel-matrix.h | 112 + > > include/linux/mfd/syscon/atmel-smc.h | 119 + > > 24 files changed, 4177 insertions(+), 73 deletions(-) > > create mode 100644 drivers/memory/atmel_ebi.c > > create mode 100644 drivers/mfd/Kconfig > > create mode 100644 drivers/mfd/Makefile > > create mode 100644 drivers/mfd/atmel-smc.c > > create mode 100644 drivers/mtd/nand/raw/atmel/Makefile > > create mode 100644 drivers/mtd/nand/raw/atmel/nand-controller.c > > create mode 100644 drivers/mtd/nand/raw/atmel/pmecc.c > > create mode 100644 drivers/mtd/nand/raw/atmel/pmecc.h > > create mode 100644 include/linux/mfd/syscon/atmel-matrix.h > > create mode 100644 include/linux/mfd/syscon/atmel-smc.h > > > > -- > > 2.34.1 > > Once this series is in, I wonder if it might be possible to drop the nand_init() call and have this happen as needed, i.e. lazy init? Regards, Simon