u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH] net: use the same alias stem for ethernet as linux
Date: Thu, 29 Apr 2021 09:10:19 -0700	[thread overview]
Message-ID: <CAPnjgZ1-TG0QD5SRGxRygGFXytj8A+-8jzuncS2ZnwVu+0-Mhw@mail.gmail.com> (raw)
In-Reply-To: <20210225155111.2812-1-michael@walle.cc>

On Thu, 25 Feb 2021 at 07:51, Michael Walle <michael@walle.cc> wrote:
>
> Linux uses the prefix "ethernet" whereas u-boot uses "eth". This is from
> the linux tree:
>
> $ grep "eth[0-9].*=.*&" arch/**/*dts{,i}|wc -l
> 0
> $ grep "ethernet[0-9].*=.*&" arch/**/*dts{,i}|wc -l
> 633
>
> In u-boot device trees both prefixes are used. Until recently the only
> user of the ethernet alias was the sandbox test device tree. This
> changed with commit fc054d563bfb ("net: Introduce DSA class for Ethernet
> switches"). There, the MAC addresses are inherited based on the devices
> sequence IDs which is in turn given by the device tree.
>
> Before there are more users in u-boot and both worlds will differ even
> more, rename the alias prefix to "ethernet" to match the linux ones.
> Also adapt the test cases and rename any old aliases in the u-boot
> device trees.
>
> Cc: David Wu <david.wu@rock-chips.com>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> Vladimir, I didn't do another patch to rename any ethernet aliases to
> "eth". Though kontron boards contain "ethernetN" aliases, all in tree
> variants don't make use of it. So there is nothing to be fixed.
>
>  arch/arm/dts/fsl-ls1028a-rdb.dts | 12 ++++++------
>  arch/sandbox/dts/test.dts        | 10 +++++-----
>  net/eth-uclass.c                 |  4 ++--
>  test/dm/ofnode.c                 |  2 +-
>  test/dm/test-fdt.c               |  2 +-
>  5 files changed, 15 insertions(+), 15 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

  parent reply	other threads:[~2021-04-29 16:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 15:51 [PATCH] net: use the same alias stem for ethernet as linux Michael Walle
2021-02-25 15:58 ` Fabio Estevam
2021-02-25 19:32   ` Ramon Fried
2021-03-03 10:26 ` David Wu
2021-04-24 11:03 ` Michael Walle
2021-04-29 16:10 ` Simon Glass [this message]
2021-06-14 20:55   ` Ramon Fried

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ1-TG0QD5SRGxRygGFXytj8A+-8jzuncS2ZnwVu+0-Mhw@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).