From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A90E2C433FE for ; Wed, 23 Nov 2022 02:10:09 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 806AC854FB; Wed, 23 Nov 2022 03:10:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="J6Vx7AUP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9F39A853C9; Wed, 23 Nov 2022 03:09:51 +0100 (CET) Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A5850853C9 for ; Wed, 23 Nov 2022 03:09:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-io1-xd31.google.com with SMTP id y6so12274037iof.9 for ; Tue, 22 Nov 2022 18:09:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=sfJotHkYRUtn4xtOooRLs9R1C6AM9h87lqnPWnzbtS8=; b=J6Vx7AUPveefuAFhh+fMg62dBo4Jnd7IZfxc7a3rLf3uWf0tXbQIXY1l/33dt1vrbD kvYO7CW9sQitkqMtxWViKh8M93Elib3iK4VfjrJwQ/snc1Ow5wkde2kOXmUpXFKZn9Js tM6kdF7ILDmEcVAb3+NppDfd4i6eBY55VS9Y8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sfJotHkYRUtn4xtOooRLs9R1C6AM9h87lqnPWnzbtS8=; b=kgEEhXiD6FFVSjic/DdIIFabnYdScIffBPmf86Hzd261JeJ27qX3tT2TNyG7dTD/Iu 9oprg+CUAQJer8m/8Z/wcVuk6X8kn5t54DnY/Ht5/9Awb+VOtNTLiTyD/4hVtjoN30Ot 1be27s1QbniEAXz6p6mKJNg1x1C2hYC3O/Zo+6Zf/E63ffdTnIwO36EBa3N2kDilqKHP gUbrP7kI5Cf/jC34jbnLQKe479yjJllNFCHufjgm7gRgXW1dcPTsQ/zdYTQPYU3+Onjg kE7sr7oBRTSOA9Swxx1DpthuMP2qV5KZWrwnaapb99NfjYy1gu3qJ2EtJ2LF+Fad8RFj /bPw== X-Gm-Message-State: ANoB5pndFlbJp1yC4T7DSn6C8dPAMpPrG1RZ7S7T7OURHSWbCbd3y6RG qMS8ubr/2c3CH/rawGIee5Mu2EElUzpLM0prQi97Yg== X-Google-Smtp-Source: AA0mqf47b171QSsKn3awv7qa8tHwx0wsnNvbBEZsa/4W0YzI2FAUqPKSnGQZ3sA7ATJKQi3z3REGfPJodRVJ+gn7Gyg= X-Received: by 2002:a05:6602:200c:b0:6de:90a6:6b04 with SMTP id y12-20020a056602200c00b006de90a66b04mr10383371iod.101.1669169386897; Tue, 22 Nov 2022 18:09:46 -0800 (PST) MIME-Version: 1.0 References: <20221107192055.21669-1-abdellatif.elkhlifi@arm.com> <20221122131751.22747-1-abdellatif.elkhlifi@arm.com> <20221122131751.22747-8-abdellatif.elkhlifi@arm.com> In-Reply-To: <20221122131751.22747-8-abdellatif.elkhlifi@arm.com> From: Simon Glass Date: Tue, 22 Nov 2022 19:09:19 -0700 Message-ID: Subject: Re: [PATCH v8 07/10] arm_ffa: introduce Sandbox test cases for UCLASS_FFA To: Abdellatif El Khlifi Cc: Drew.Reed@arm.com, achin.gupta@arm.com, ilias.apalodimas@linaro.org, jens.wiklander@linaro.org, nd@arm.com, trini@konsulko.com, u-boot@lists.denx.de, vishnu.banavath@arm.com, xueliang.zhong@arm.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Abdellatif, On Tue, 22 Nov 2022 at 06:18, Abdellatif El Khlifi wrote: > > Add functional test cases for the FF-A core driver > > These tests rely on the FF-A Sandbox driver which helps in > inspecting the FF-A core driver. > > Signed-off-by: Abdellatif El Khlifi > Cc: Tom Rini > Cc: Simon Glass > Cc: Ilias Apalodimas > Cc: Jens Wiklander > > --- > > Changelog: > =============== > > v8: > > * update partition_info_get() second argument to be an SP count > * pass NULL device pointer to the FF-A bus discovery and operations > > v7: set the tests to use 64-bit direct messaging > > v4: align sandbox tests with the new FF-A driver interfaces > and new way of error handling > > v1: introduce sandbox tests > > MAINTAINERS | 1 + > test/dm/Makefile | 2 + > test/dm/ffa.c | 392 +++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 395 insertions(+) > create mode 100644 test/dm/ffa.c This looks OK to me, but for sorting out how devices are bound / probed and how to call into a uclass. Also, just return 0, not CMD_RET_SUCCESS. This isn't actually a command :-) Even if it were, 0 is better. Regards, Simon