From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 472FBC433F5 for ; Fri, 24 Sep 2021 02:48:58 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B2ED661090 for ; Fri, 24 Sep 2021 02:48:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B2ED661090 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 24EAB83394; Fri, 24 Sep 2021 04:48:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="jpJMtS+r"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6107A83394; Fri, 24 Sep 2021 04:48:52 +0200 (CEST) Received: from mail-vs1-xe29.google.com (mail-vs1-xe29.google.com [IPv6:2607:f8b0:4864:20::e29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 816D080202 for ; Fri, 24 Sep 2021 04:48:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vs1-xe29.google.com with SMTP id az15so8580602vsb.8 for ; Thu, 23 Sep 2021 19:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xsvcNaatlx+05YpXWEEAWKvv2GRN/KehdYSyumOFy6A=; b=jpJMtS+rZ3Zxeln+W5VlepujzRFAYu5pWRMu/XtT4VMGJ2yvvyeC1XRdpZ2uzmG+O5 K5WU87hFXF5Z4kVCMleKoI1+S2m/8cBZnztTzTuri2pX0M2r9AU+GxNgYq+GtLuAn1f9 ghwHVo2XTwcXFEliJxUiJQ8DgL5cFSJHISuEE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xsvcNaatlx+05YpXWEEAWKvv2GRN/KehdYSyumOFy6A=; b=VWeAtbvQtDLBa+pzqWHdqbIUkvu7m7SvrS9xOPYK8VsdKGXVtqKz7tdTgkqs0md75R n1EEdKqcCtX0aYJ6eNEj+ec1Pba0jEs2WJYbmO3u1M5hU0DBQsZ5VY0OMPpJYDGZdYoY QPWLYHB4Nt3OrxVH0e4BI8J0WXP1CWDkP2snH0owJoqG0yHOB1H8ueYvYZ0o4BzKB7Er pj4QQGs4oa+OO5BdL83/X68p6VHB8XF8G5epcYLQKDZvNdp4ZdSDAbVutjCFtQtT/J8u vEiyjjPktjS1SIL/sefj1ny4R6Cn3DI810uMW/q3zlcd/85/5M9oMAZsVKSCGFs35Dus XXeg== X-Gm-Message-State: AOAM5310Gw9jpOYM97Xr6TP2ugH+/PpPRooHv0qyuUX2J+lYNN2ru0Lk LO9r6JxYZX0qhVCFg/efH8A0WO5jTpj4AR3dVUPMSnzik/8= X-Google-Smtp-Source: ABdhPJzG2lQ05Et6E64kz7bAAzsEO06avuy8ArsPwHHAqRjnqEHoNLQXO9PcCtfwiL6scRwtWqUJlcRuskawJMyuvqw= X-Received: by 2002:a05:6102:457:: with SMTP id e23mr5695417vsq.8.1632451726917; Thu, 23 Sep 2021 19:48:46 -0700 (PDT) MIME-Version: 1.0 References: <20210919214937.3829422-1-sjg@chromium.org> <20210919214937.3829422-4-sjg@chromium.org> <20210920110804.y45c26bkvyyaczgy@ti.com> In-Reply-To: <20210920110804.y45c26bkvyyaczgy@ti.com> From: Simon Glass Date: Thu, 23 Sep 2021 20:48:35 -0600 Message-ID: Subject: Re: [PATCH v4 3/5] sf: Tidy up code to avoid #ifdef To: Pratyush Yadav Cc: U-Boot Mailing List , Jagan Teki , Heinrich Schuchardt , Mike Frysinger Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Pratyush, On Mon, 20 Sept 2021 at 05:08, Pratyush Yadav wrote: > > Hi Simon, > > On 19/09/21 03:49PM, Simon Glass wrote: > > Update this code to use IS_ENABLED() instead. > > > > Signed-off-by: Simon Glass > > > > Reviewed-by: Pratyush Yadav > > Nitpick: Trailers shouldn't have a blank line between them. I see it for > this patch and 4/5 as well. It probably doesn't matter, but I wonder if > it will trip up some tools that work on commit trailers like > git-interpret-trailers. Something you might want to fix in your > workflow... The fix to 'patman status -d ' is in mainline but was not in the tree where I ran this tool, unfortunately. So hopefully this won't happen again. Regards, Simon