From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E5DCC4332F for ; Fri, 14 Oct 2022 15:37:05 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B3BD684E06; Fri, 14 Oct 2022 17:37:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="ClNGai3O"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4297584EAD; Fri, 14 Oct 2022 17:37:01 +0200 (CEST) Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D495384DFC for ; Fri, 14 Oct 2022 17:36:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-wm1-x32d.google.com with SMTP id l16-20020a05600c4f1000b003c6c0d2a445so3794484wmq.4 for ; Fri, 14 Oct 2022 08:36:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Mfw8ENGk8SlfsN6RK4o8J0QYaLLiSbhnd1aUj7b6RZ4=; b=ClNGai3OHUgupUp4viCsOf+cE3fYhRAsVvumwY8MhYBN7Ri211h1bOzPD56kNrBz48 EmC4Fh2OhC7G9Nb1rp5var2mQu1S3hcF461MEmQ0sMxBEy+XdM3UURgnpbn8FMSHKQKq NwmQ/aFeV8+K/c8YQMtwzAIeUb7thuswGzr6w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Mfw8ENGk8SlfsN6RK4o8J0QYaLLiSbhnd1aUj7b6RZ4=; b=NlyprNZwsZQjep1g4y6N4m/RhGOcZttrj3O/oc1mUbrLu1OgjI+dpFh0GC5eF7WFzc SkNvyljeFaCBDHZu2/RYsA29QBNs2+1doumLuNWbtnm8P/aZMHsmS75C1Ql1dO2mWdvh emzxdZ1E+SbFX8SuJ6P5xg+VoUDp8gXnfzZGO+FRuuOORZ39CpDnfBgSk2wgb/aquV9R MZnwawaYWKQgoLbVz7BSa4KO75VohB2kixzV+B68hoyLk8ZOESnqP0IM5khpuZrAcukU atrxbU31IJnhu1FAzCs3HsjPQ2wXH3F59nGn2CkAGwoO96YZlw8iGHQ3oxi2wNUjWt4I EIug== X-Gm-Message-State: ACrzQf0b/likoHmQ9o4jC/HNpVPSqEBU3Hs9/jmbIKfapGaucA1nlpGY hBW2znk98cMdoQstCdBTf4glXDYTQGYI/CLBoX+TCQ== X-Google-Smtp-Source: AMsMyM5q8ci7Wyzce6hP/ullWBQVfjWhijRBTPAOFOiTYE4nlVwOtcChQhCiePJeY//gBxl4f/38luWM8xduMgM4AC4= X-Received: by 2002:a7b:c3c4:0:b0:3c4:785a:36d7 with SMTP id t4-20020a7bc3c4000000b003c4785a36d7mr11073621wmj.138.1665761818106; Fri, 14 Oct 2022 08:36:58 -0700 (PDT) MIME-Version: 1.0 References: <20210925003055.759305-1-sjg@chromium.org> <20210924183029.v2.1.Id572ddf5eb457096b95d30ae2d8675f539367fe8@changeid> <5e4facbe-c78b-c3a6-2fb6-b268e8761d66@gmx.de> <87380b1a-5011-1e75-a02c-2508227e9818@siemens.com> <20221014131315.GM2020586@bill-the-cat> In-Reply-To: From: Simon Glass Date: Fri, 14 Oct 2022 09:36:46 -0600 Message-ID: Subject: Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model To: Jan Kiszka Cc: Tom Rini , Heinrich Schuchardt , Bin Meng , Christian Melki , Ilias Apalodimas , U-Boot Mailing List , Alexander Graf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Jan, On Fri, 14 Oct 2022 at 09:35, Jan Kiszka wrote: > > On 14.10.22 17:33, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 14 Oct 2022 at 07:13, Tom Rini wrote: > >> > >> On Fri, Oct 14, 2022 at 01:51:54PM +0200, Jan Kiszka wrote: > >>> On 21.10.21 01:34, Heinrich Schuchardt wrote: > >>>> On 9/25/21 2:30 AM, Simon Glass wrote: > >>>>> This code should never have been added as it builds a new feature o= n top > >>>>> of legacy code. This has already been improved with the dependency = on > >>>>> BLK. > >>>>> > >>>>> Add a dependency on DM_ETH also, to avoid needing to deal with this= old > >>>>> code. > >>>>> > >>>>> Boards which want EFI_LOADER should migrate to driver model first. > >>>>> > >>>>> Note this patch is included to resolve the following build error: > >>>>> > >>>>> lib/efi_loader/efi_runtime.c:680:16: error: =E2=80=98CONFIG_SYS_TEX= T_BASE=E2=80=99 > >>>>> undeclared (first use in this function); did you mean > >>>>> =E2=80=98CONFIG_SYS_SRAM_BASE=E2=80=99? > >>>>> 680 | ulong base =3D CONFIG_SYS_TEXT_BASE; > >>>>> | ^~~~~~~~~~~~~~~~~~~~ > >>>>> | CONFIG_SYS_SRAM_BASE > >>>>> > >>>>> Signed-off-by: Simon Glass > >>>> > >>>> Reviewed-by: Heinrich Schuchardt > >>>> > >>> > >>> How to deal with boards that need CONFIG_NET but do not actually > >>> implement any driver (yet)? This now broke UEFI for the IOT2050 which > >>> needs NET for network-related device tree setup (see also [1]) and > >>> enforces a local hack for us. > >> > >> Yes, looking at the patch, this should probably use NETDEVICES and not > >> NET as the test? Would that fix your problem, Jan? > > > > But that selects DM_ETH. You can still enable DM_ETH when there are no > > devices, so I'm not sure what the problem is. Can you post an error? > > > > Things should be migrated to DM_ETH by now (end of 2020). > > > > I am enable DM_ETH now at board-level, just to make EFI_LOADER happy, > but that feels wrong. I agree, but I wonder if this might need some code refactoring. Perhaps EFI_LOADER_NET needs to be created, net functionality can be disabled? Regards, Simon