From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F07CC77B73 for ; Wed, 19 Apr 2023 07:14:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 78C05861F3; Wed, 19 Apr 2023 09:14:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="aNrTXTI9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 919CE86192; Wed, 19 Apr 2023 03:46:27 +0200 (CEST) Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 62994861A8 for ; Wed, 19 Apr 2023 03:46:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ej1-x630.google.com with SMTP id fw30so25038927ejc.5 for ; Tue, 18 Apr 2023 18:46:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1681868773; x=1684460773; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qX3cpuG+CGnXT+a6KCU0LoiDbeC2c5JmlA6qsC+TBZ8=; b=aNrTXTI9MxYdzsGzIiOGTlJEdxxIzxbs4NUHjCw61fwEurWQw4H4cwpuw52sn4xXM7 Jw45YXVjAj+rZSzYlCNilX9xGUB2wCCZKIn6Zxz2bHXuAYCeJ+fZT3JtcV2jEt6mUPB6 dya1V5QmwZ9ssmczqiHDmia9IGWAf+oGD+WiY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681868773; x=1684460773; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qX3cpuG+CGnXT+a6KCU0LoiDbeC2c5JmlA6qsC+TBZ8=; b=MYoEdeUwGGN1Ycy9pnDYuOU5+ZZnFBBb5qJQke4izyBBgNURaJ5LEr3HDLoVYEzfcN iAnpRN8giXLr+QeKfetz7Vm0h2B6/Mr7WxcL6zPnIztszLOcuVqFSXh3zMsWRu2tvf7L eR5+nM4I1ylFDJCQfj7bncLyArmXvlWjcl7V6TgpMZUHttupBuvIT2uvfsQxeTe7+ka6 e8ZOPORQg0j8+0CyhyL1XvtdiziiZbCQpItnUubcEHwYz2j5ut2UFNtD8dvwNUjHRtZ/ eRfFrMA6YOBcOcMG1buOicUsG7iDDn+Js7oBw2pg3BisPKj3NWRz13w/yDKaXsw3Of5j GPpA== X-Gm-Message-State: AAQBX9fYjSEzgrloiFuAprr4fFCTQZU6SA8heCbKr6HsylVj0dtzyDxJ +j425jidvkbYy1bkY8SQg822faFJPwm0EDBTMB6+XrR1hwhcllv1uyj43A== X-Google-Smtp-Source: AKy350bEx5zbkYJIiJ2/1tHt/jAQR+myHxvZp6X8YwePOC+fZMComeFbW+JXtQe3iSfQBL/FlaUE2os4/qT+pPOuCvM= X-Received: by 2002:a17:906:c78f:b0:878:711d:9310 with SMTP id cw15-20020a170906c78f00b00878711d9310mr12437981ejb.1.1681868773104; Tue, 18 Apr 2023 18:46:13 -0700 (PDT) MIME-Version: 1.0 References: <20230330213227.2142353-1-sjg@chromium.org> In-Reply-To: <20230330213227.2142353-1-sjg@chromium.org> From: Simon Glass Date: Tue, 18 Apr 2023 19:45:58 -0600 Message-ID: Subject: Re: [PATCH 00/38] x86: Use qemu-x86_64 to boot EFI installers To: U-Boot Mailing List Cc: Bin Meng , Heinrich Schuchardt , AKASHI Takahiro , Anatolij Gustschin , Andre Przywara , Andrew Scull , Ashok Reddy Soma , Balamanikandan Gunasundar , =?UTF-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?= , Dzmitry Sankouski , Enric Balletbo i Serra , Fabio Estevam , George McCollister , Ilias Apalodimas , Jaehoon Chung , Jason Liu , John Keeping , Jose Marinho , Marcel Ziswiler , Mario Six , Mark Kettenis , Masahisa Kojima , Michal Simek , Michal Suchanek , Nikhil M Jain , Oleksii Bidnichenko , Ovidiu Panait , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Paul Barker , Philippe Reynes , =?UTF-8?Q?Pierre=2DCl=C3=A9ment_Tosi?= , Rasmus Villemoes , Sean Anderson , Stefan Herbrechtsmeier , Stefan Roese , Sughosh Ganu , Ye Li Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Wed, 19 Apr 2023 09:14:18 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Bin, On Thu, 30 Mar 2023 at 15:32, Simon Glass wrote: > > This series adds various minor features so that qemu-x86_64 can boot the > Ubuntu 2022.04 installer using a virtio device: > > qemu-system-x86_64 -M pc -drive format=raw,file=root.img > -bios /tmp/b/qemu-x86_64/u-boot.rom > -drive if=virtio,file=ubuntu-22.04.2-desktop-amd64.iso > -smp 4 -m 4G -serial mon:stdio > > The main changes include: > - Enable video in SPL while running in 32-bit mode > - Drop the duplicate ACPI tables with EFI > - Support PCI autoconfig in SPL > - Support FAT on a CDROM filesystem > - Improved bootstd rules around device tree and efi_set_bootdev() > > There are also quite a number of minor tweaks and fixes to make things > easier to use. > > This series is based on an older version of the SPL-video series from > Nikhil M Jain. It is available at u-boot-dm/bryc-working > > > Simon Glass (38): > x86: Tidy up availability of string functions > x86: Allow listing MTRRs in SPL > bios_emulator: Add Kconfig and adjust Makefile for SPL > bios_emulator: Drop VIDEO_IO_OFFSET > x86: Tidy up EFI code in interrupt_init() > x86: Set high bits of the mtrr base registrer > x86: Add a comment for board_init_f_r_trampoline() > x86: Show the CPU physical address size with bdinfo > x86: Correct get_sp() implementation for 64-bit > x86: Show an error when a BINS exception occurs > acpi: Add a comment to set the acpi tables > bdinfo: Show the RAM top and approximate stack pointer > part: Allow setting the partition-table type > qfw: Show the file address if available > log: Tidy up an ambiguous comment. > video: Allow building video drivers for SPL > qfw: Set the address of the ACPI tables > efi: Show all known UUIDs with CONFIG_CMD_EFIDEBUG > x86: Improve the trampoline in 64-bit mode > Show the malloc base with the bdinfo command > nvme: Provide more useful debugging messages > pci: Support autoconfig in SPL > pci: Allow the video BIOS to work in SPL with QEMU > pci: Tidy up logging and reporting for video BIOS > x86: Allow video-BIOS code to be built for SPL > x86: Pass video settings from SPL to U-Boot proper > x86: Init video in SPL if enabled > pci: Adjust video BIOS debugging to be SPL-friendly > pci: Mask the ROM address in case it is already enabled > x86: Enable display for QEMU 64-bit > x86: Allow logging to be used in SPL reliably > fs: fat: Shrink the size of a few strings > fs: fat: Support reading from a larger block size > x86: Enable useful options for qemu-86_64 > x86: Record the start and end of the tables > sandbox: Correct header order in board file > sandbox: Install ACPI tables on startup > efi: Use the installed ACPI tables > > arch/sandbox/include/asm/global_data.h | 4 + > arch/x86/cpu/i386/interrupt.c | 17 +-- > arch/x86/cpu/mtrr.c | 62 +++++++- > arch/x86/cpu/start64.S | 19 +++ > arch/x86/include/asm/global_data.h | 4 + > arch/x86/include/asm/mtrr.h | 20 +++ > arch/x86/include/asm/string.h | 6 +- > arch/x86/include/asm/u-boot-x86.h | 21 ++- > arch/x86/lib/Makefile | 9 +- > arch/x86/lib/bdinfo.c | 5 + > arch/x86/lib/bios.c | 5 +- > arch/x86/lib/bootm.c | 2 +- > arch/x86/lib/spl.c | 26 +++- > arch/x86/lib/tables.c | 4 +- > board/google/Kconfig | 7 - > board/sandbox/sandbox.c | 22 ++- > cmd/Kconfig | 8 ++ > cmd/acpi.c | 24 +++- > cmd/bdinfo.c | 6 + > cmd/part.c | 34 +++++ > cmd/qfw.c | 2 +- > cmd/x86/mtrr.c | 60 +------- > common/board_f.c | 12 +- > common/board_r.c | 7 +- > common/log.c | 2 +- > configs/qemu-x86_64_defconfig | 14 ++ > disk/part.c | 16 +++ > doc/usage/cmd/acpi.rst | 29 +++- > doc/usage/cmd/part.rst | 74 ++++++++++ > doc/usage/cmd/qfw.rst | 28 ++-- > drivers/Kconfig | 2 + > drivers/Makefile | 5 +- > drivers/bios_emulator/Kconfig | 10 ++ > drivers/bios_emulator/biosemui.h | 18 +-- > drivers/bios_emulator/x86emu/sys.c | 1 + > drivers/misc/qfw.c | 12 ++ > drivers/nvme/nvme.c | 36 +++-- > drivers/pci/Kconfig | 8 ++ > drivers/pci/pci-uclass.c | 10 +- > drivers/pci/pci_rom.c | 165 +++++++++++++++++----- > fs/fat/Kconfig | 13 ++ > fs/fat/fat.c | 117 ++++++++++++--- > fs/fat/fat_write.c | 22 ++- > include/asm-generic/global_data.h | 11 ++ > include/bloblist.h | 1 + > include/configs/conga-qeval20-qa3-e3845.h | 2 - > include/configs/dfi-bt700.h | 2 - > include/configs/minnowmax.h | 2 - > include/configs/som-db5800-som-6867.h | 2 - > include/configs/theadorable-x86-common.h | 2 - > include/configs/x86-chromebook.h | 2 - > include/part.h | 9 ++ > include/pci_ids.h | 1 + > include/video.h | 24 ++++ > lib/efi_loader/efi_acpi.c | 33 +++-- > lib/uuid.c | 2 +- > test/dm/acpi.c | 38 +++++ > 57 files changed, 866 insertions(+), 233 deletions(-) > create mode 100644 drivers/bios_emulator/Kconfig > > -- > 2.40.0.348.gf938b09366-goog > Any thoughts on this series, please? I have some comments from Heinrich so will respin this, but would like to check first if there is anything else? Regards, Simon