From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 644BCC433EF for ; Thu, 7 Oct 2021 02:49:35 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 883CB6113E for ; Thu, 7 Oct 2021 02:49:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 883CB6113E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CFCDB83270; Thu, 7 Oct 2021 04:49:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Mz/ShyfJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B62C18331F; Thu, 7 Oct 2021 04:49:29 +0200 (CEST) Received: from mail-vs1-xe35.google.com (mail-vs1-xe35.google.com [IPv6:2607:f8b0:4864:20::e35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 66257831B0 for ; Thu, 7 Oct 2021 04:49:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vs1-xe35.google.com with SMTP id g10so5181485vsb.8 for ; Wed, 06 Oct 2021 19:49:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VjTD28dXHDYUywf4svonqd9ajhDZayKs3eJLBc6xxF0=; b=Mz/ShyfJx4DjkiSGzBRgCWS2pfRsQ145MUbEAaE/0teZPEVzSNmmTivpnoVb8PSiCz xAIt7HvF4U49UTOqQojwd8vWjp4ONX+c5VX3MZDs39pk3o5Tlm+SNvaQiiMsMm6YIyPR Ow/ftbOOhq0JxysCZta5Eteq21TiBZajYmifk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VjTD28dXHDYUywf4svonqd9ajhDZayKs3eJLBc6xxF0=; b=dnKebOIPQTk9IW70dLdTHDrlVBWrGmVP98pJyGYkZB8wT8QvLY3AYkDbhCzoQr/KEZ cMMgPjA4PS/ZvHJZEKmMFimZ6RDFVVlmw8o1sRsjBQAuRlnINoxkF7gCESlriSVhsSpL K7wBkX1FVBtGcY+3myKcJoWCscbERWGwB/si2HcqenHhEwaB7qTR350D8wBG9V6dJ+SC cynGR9eOIhz7/MtJpUPyrDD9GKxMWfZV7x5G9VaNaCRQvIqfCd+9CbJxMmeoXcS4JDuS MGLi8Ma0c2ivOiDMJMz8mcPXmpsNdcJnv6TQmFVT3wZZXkjqUf51oF8TFcPnFhCpBZBF 4ZLA== X-Gm-Message-State: AOAM532c/Cbxs8enCe4mLynzqLxI7DIylmjW8wI36mQvCqY6hycnfhfh 4gsu8iXu0ejkJ19GdF4Yihg+PSqKKwrd1pjLp6hHiA== X-Google-Smtp-Source: ABdhPJz4yZ4Ksu1VFq8HIuL/BlVPrywJrfd36LxjqT7KKr447EeDA+v+nEPYNrXtQf+zf0ZcxblUhQvRSc7hXmkCwbU= X-Received: by 2002:a67:f801:: with SMTP id l1mr1879534vso.59.1633574964590; Wed, 06 Oct 2021 19:49:24 -0700 (PDT) MIME-Version: 1.0 References: <20210926014342.127913-1-sjg@chromium.org> <20210926014342.127913-3-sjg@chromium.org> <20211007002647.GA11424@bill-the-cat> In-Reply-To: <20211007002647.GA11424@bill-the-cat> From: Simon Glass Date: Wed, 6 Oct 2021 20:49:13 -0600 Message-ID: Subject: Re: [PATCH v5 02/29] kconfig: Add tools support to CONFIG_IS_ENABLED() To: Tom Rini Cc: U-Boot Mailing List , Alexandru Gagniuc , Andre Przywara , Rasmus Villemoes , Robert Marko , Masahiro Yamada , Masahiro Yamada Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Wed, 6 Oct 2021 at 18:26, Tom Rini wrote: > > On Sat, Sep 25, 2021 at 07:43:15PM -0600, Simon Glass wrote: > > > At present we must separately test for the host build for many options, > > since we force them to be enabled. For example, CONFIG_FIT is always > > enabled in the host tools, even if CONFIG_FIT is not enabled by the > > board itself. > > > > It would be more convenient if we could use, for example, > > CONFIG_IS_ENABLED(FIT) and get CONFIG_HOST_FIT, when building for the > > host. Add support for this. > > > > With this and the tools_build() function, we should be able to remove all > > the #ifdefs currently needed in code that is build by tools and targets. > > > > This will be even nicer when we move to using CONFIG(xxx) everywhere, > > since all the #ifdef and IS_ENABLED/CONFIG_IS_ENABLED stuff will go away. > > > > Signed-off-by: Simon Glass > > Suggested-by: Rasmus Villemoes # b4f73886 > > Reviewed-by: Alexandru Gagniuc > > The problem here is we don't include automatically > when building host stuff, I believe. This is why doing this breaks > test_mkimage_hashes for me on am335x_evm with: > /tmp/.bm-work/am335x_evm/tools/mkimage -D -I dts -O dtb -i /tmp/.bm-work/am335x_evm -f /home/trini/work/u-boot/u-boot/test/py/tests/vboot//hash-images.its /tmp/.bm-work/am335x_evm/test.fit > *** stack smashing detected ***: terminated Oh dear, and no CI coverage. I was reluctant to include kconfig.h everywhere but perhaps that is the best approach. Will take a look ASAP. Regards, Simon