From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9964C04AA5 for ; Thu, 25 Aug 2022 01:27:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 09EEE8487F; Thu, 25 Aug 2022 03:26:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="KICR4urf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 08F4384870; Thu, 25 Aug 2022 03:25:59 +0200 (CEST) Received: from mail-oa1-x29.google.com (mail-oa1-x29.google.com [IPv6:2001:4860:4864:20::29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D5BBF8484E for ; Thu, 25 Aug 2022 03:25:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-f2a4c51c45so23076791fac.9 for ; Wed, 24 Aug 2022 18:25:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=uM57vVlseQ4OS7wALsJh6vjnna+O08jSxP2P1K5zBP8=; b=KICR4urfidFq7kGobqVAOWYWwgW7Ru2P80Vz0wOx99fKvwv0rHM32gblJD1Xx8jau1 RPP+WpaCzsNhK6C/o89Y6gnm71rIcroEqOFnw2zER+2TUdEH/a88SNpZbbz2Tu9eamro P3gp+ITsMF+unSomzrc4QynoFci+KS66McvcU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=uM57vVlseQ4OS7wALsJh6vjnna+O08jSxP2P1K5zBP8=; b=eWMzRfnClS/OebrAaGwOKcypvY1XLjjoafM+wvCZ9yJvTANyv3S6fU4rDJ1l55kQP0 9rYC8D68O1Shq8Xjx8k5w5Zko2KhxD4s6xFTn14KLzLltAPS81dNVmFI8/z3WvA1r/2W Jmzb+Ak9e5hlXBWAYfAx6oANwutjoY11o0HCmV05HQaMISmu4tGYJ0pGK8oByaUm/yqo fQSmSHZsXDUer163io4M8AsJ0jNPHewOcRTU5V1lBd6r2BdcRyzMII6suB/HgpWU1c4W Safqe9PtD5RzmtmEVh7v+6cJjvvGyKV1CzauD7MOCWCqRcb6etxkikhZ7rKQUDXk7pso Nh8A== X-Gm-Message-State: ACgBeo3QiKFLMZsfhK+b+8S/I0Duc3UvDjVEwuqsWiX1kDHhwkRcibkz JBcZRJ6z5/Hlpq4GQz/IaxBK1ZQGCAS6b/bcmGQjpA== X-Google-Smtp-Source: AA6agR7/aSFM6hGYTxhVplt9E/rmD8t+qYjH4LQcyULo3VmvBqfoKtbkQHDs7ket8668NCUDmylpjmmu00SDO6RicQw= X-Received: by 2002:a05:6870:7a7:b0:fb:d45:62f with SMTP id en39-20020a05687007a700b000fb0d45062fmr4835192oab.170.1661390752831; Wed, 24 Aug 2022 18:25:52 -0700 (PDT) MIME-Version: 1.0 References: <20220823215300.1485789-1-quic_jaehyoo@quicinc.com> <20220823215300.1485789-5-quic_jaehyoo@quicinc.com> In-Reply-To: <20220823215300.1485789-5-quic_jaehyoo@quicinc.com> From: Simon Glass Date: Wed, 24 Aug 2022 18:25:38 -0700 Message-ID: Subject: Re: [PATCH v3 4/7] cmd: fru: add product info area parsing support To: Jae Hyun Yoo Cc: Michal Simek , Ovidiu Panait , Mario Six , Masahisa Kojima , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Heinrich Schuchardt , Ashok Reddy Soma , Thomas Huth , Huang Jianan , Chris Morgan , Roland Gaudig , Patrick Delaunay , Alexandru Gagniuc , Jamie Iles , Graeme Gregory , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Jae, On Tue, 23 Aug 2022 at 14:53, Jae Hyun Yoo wrote: > > Add product info area parsing support. Custom board fields can be > added dynamically using linked list so that each board support can > utilize them in their own custom way. > > Signed-off-by: Jae Hyun Yoo > --- > Changes from v2: > * Changed 'struct fru_board_info_member' to 'struct fru_common_info_member'. > > Changes from v1: > * Refactored using linked list instead of calling a custom parsing callback. > > Changes from RFC: > * Added manufacturer custom product info fields parsing flow. > > cmd/fru.c | 28 ++++-- > include/fru.h | 34 ++++++- > lib/fru_ops.c | 244 +++++++++++++++++++++++++++++++++++++++++++++++--- > 3 files changed, 286 insertions(+), 20 deletions(-) > Please add tests for this code. Regards, Simon