From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9056FC43334 for ; Wed, 13 Jul 2022 15:29:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 65AEB8403B; Wed, 13 Jul 2022 17:29:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="k4z/fR+A"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C5EDC8404A; Wed, 13 Jul 2022 17:28:46 +0200 (CEST) Received: from mail-oa1-x2c.google.com (mail-oa1-x2c.google.com [IPv6:2001:4860:4864:20::2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 232898403D for ; Wed, 13 Jul 2022 17:28:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-10c0d96953fso14519968fac.0 for ; Wed, 13 Jul 2022 08:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gITjapI/c241VGgyMip6RFBPyBRYy4JDfHpbqDa2Dy4=; b=k4z/fR+AfAdiGH9uliSUIq0SUOCDwnWkRFgRZlDEDnHY0UMrkYIHPlSeRe/btm5A4z VmBGFGdDdkL2qqltQiHiRWwSy3kHEfHlhL1byyaZ7wTxS2Q774onSoeVsyyPOjcdIDcL oId0oeof2ecxQv2b5qSRGivnaOTIi3MZQuOU0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gITjapI/c241VGgyMip6RFBPyBRYy4JDfHpbqDa2Dy4=; b=OYrRSHsstdUhSpfVuFr6Y+dqN9nvu2uW1iVxPviGiILO3mdyKEjdJBgI399Cvb8HYG m0CLA5AcUNtWHToxqBkA35QKqN9T/N808e9xuUhIZpF3wmiB8zZIdys7Rjfwo8eIiBQy k0+161l7ydIBDDqMd6Pb2NxKGbY+oqZTx2OQPMQkXkj+ZNxXKcVFxT6bO1yJyQTJH47t 1o/VLzNH/jl5eQdk11ZoJLhVbsY+VIFl1iiWzbM5DqCfRoSx3xLqg352vmacn1fDYLP8 L15j0CoklQdC9Oach7F4QP10z701zzyt1c7C9/Cg3ISa+zl0amhsT+lddHXGAQweG7RR mz/w== X-Gm-Message-State: AJIora8AE866R9pUB8TSfcz76PMrJwKmbAUsre9uk648BvjESIm8mbpR r48LABNckEGWTIQ28v4+RMYbNE/7VUuXym1GfcCSa9f8+AE= X-Google-Smtp-Source: AGRyM1v3ZL1UG7m2+n5Zbhx5sH5M/FbobPZtkyvxC6JrSB+ucMLM+pZpP+ei+yqGRpVMJF5nbbLfASdPiqg7EDXCSNw= X-Received: by 2002:a05:6870:b61c:b0:10c:8308:e41b with SMTP id cm28-20020a056870b61c00b0010c8308e41bmr2106837oab.64.1657726108180; Wed, 13 Jul 2022 08:28:28 -0700 (PDT) MIME-Version: 1.0 References: <20220712010413.331984-1-sjg@chromium.org> <20220712010413.331984-11-sjg@chromium.org> <20220712213851.GS1146598@bill-the-cat> In-Reply-To: <20220712213851.GS1146598@bill-the-cat> From: Simon Glass Date: Wed, 13 Jul 2022 09:28:06 -0600 Message-ID: Subject: Re: [PATCH 10/19] buildman: Incorporate the genboardscfg.py tool To: Tom Rini Cc: U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Tue, 12 Jul 2022 at 15:38, Tom Rini wrote: > > On Mon, Jul 11, 2022 at 07:04:04PM -0600, Simon Glass wrote: > > Bring this tool into buildman, so we don't have to run it separately. The > > board.cfg file is still produced as part of the build, to save time when > > doing another build in the same working directory. If it is out of date > > with respect to the Kconfig, it is updated. > > > > Time to regenerate on a recent single-thread machine is 4.6s (1.3s on a > > 32-thread machine), so we do need some sort of cache if we want buildman > > to be useful on incremental builds. We could use Python's pickle format > > but: > > > > - it seems useful to allow boards.cfg to be regenerated, at least for a > > while, in case other tools use it > > - it is possible to grep the file easily, e.g. to find boards which use > > a particular SoC (similar to 'buildman -nv ' > > While I don't think other tools still use boards.cfg, this will make it > easier to find out that I'm wrong. Perhaps once the CONFIG to Kconfig > migration is done we can move to just pickle'ing the data or similar > since I find the main use of what was in boards.cfg can be figured out > with some other git grep'ing, and in turn that's mainly for me when > trying to convert stuff. Thanks for doing this. Yes. I'm excited to hear that Kconfig migration might be done - any forecast as to when? One thing we could to is provide an option for buildman to spit out the various fields that go into boards.cfg Regards, SImon