From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B1DAC6FD1D for ; Thu, 30 Mar 2023 23:49:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2CE4185F2D; Fri, 31 Mar 2023 01:49:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="B1DiMEHZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 62FD885F2D; Fri, 31 Mar 2023 01:49:13 +0200 (CEST) Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0D56A85E8F for ; Fri, 31 Mar 2023 01:49:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ed1-x534.google.com with SMTP id er13so42162232edb.9 for ; Thu, 30 Mar 2023 16:49:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1680220147; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=i7AUK6B2l9+pAiUdgBAPLGsDT/LMc6qPQhO7oWEEXY4=; b=B1DiMEHZsPjxhpPia0N6KQj6ay2EhrDNrUyx47PzOPgDyX2IPeYXlDhBH7rU30h4TY D158rxbrWaeTVfqVfpxu/Re1mc1O2IrBOBH1qT0PTjoqz6KFVm62L41H9W/VWvilMZMV UOHEgCPZqYxfWwVtOVqQKZe0b3kgOpHaXT1nc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680220147; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i7AUK6B2l9+pAiUdgBAPLGsDT/LMc6qPQhO7oWEEXY4=; b=mAk9VWIVEFHAr/kKfXBE844PdBJ7m/JBIm4tz9chhs1vnkpqcClP+/mtl5ziQWh/ig OFn44S62K4UmgZ3aWm1QkzRJATcBiDq7F3LrepnxwDx6KyGG4WAJtjLr+aFWz60oaOnQ sHq7aeuD1R2EOWDJqaOOE2EK4tFDrpgppy/V/WHJDEZir+E5Hf7HFzx2J1X0refTSbiO 5jVMkDhvB4ksd/UF8SsaK/s9QkwTIgWbUxHMu27welT2EGRUTjDwt4qcrEwNa+EDXIIq 1je0II8Cccn5L31mFSxLCEEXxak9U47276ns+149wtHe2guuGnnGUZAi7YH/VZw4FmbS s3Sw== X-Gm-Message-State: AAQBX9fVjxZNSDfAu3msne0Jj4Z/pHlaBoaiNFvv9DBRlx4lFaz26SC8 6mvcqU/ucWeKcOk6GV81AggAKmZeRcaldSyZTkj9TnynQMNYKRNiBvu2eA== X-Google-Smtp-Source: AKy350ZzyQQ3j3p9HG3v/ScJfqifGhyzHmFBl4eF2RzCN8gJDmc3JR9znGnij6BXotm/CYXba27+nEGdn+zUvKQgSJc= X-Received: by 2002:a50:bb62:0:b0:4fa:ce07:639f with SMTP id y89-20020a50bb62000000b004face07639fmr12322751ede.5.1680220146750; Thu, 30 Mar 2023 16:49:06 -0700 (PDT) MIME-Version: 1.0 References: <20230330213227.2142353-1-sjg@chromium.org> <20230331103047.38.I86db03df16c50b2b03532f99064a26c14704056f@changeid> <7E384BC1-C009-4E2F-B540-4A2BE975A91B@gmx.de> In-Reply-To: <7E384BC1-C009-4E2F-B540-4A2BE975A91B@gmx.de> From: Simon Glass Date: Fri, 31 Mar 2023 12:48:55 +1300 Message-ID: Subject: Re: [PATCH 38/38] efi: Use the installed ACPI tables To: Heinrich Schuchardt Cc: U-Boot Mailing List , Bin Meng , Ilias Apalodimas Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Heinrich, On Fri, 31 Mar 2023 at 10:53, Heinrich Schuchardt wrot= e: > > > > Am 30. M=C3=A4rz 2023 23:32:27 MESZ schrieb Simon Glass : > >U-Boot sets up the ACPI tables during startup. Rather than creating a > >new set, install the existing ones. Create a memory-map record to cover > >the tables. > > I understand that this works on QEMU which provides ACPI tables. But on a= ll other systems that use ACPI you will still have to generate ACPI tables. > > So you cannot simply drop the table generation. > > If you have moved the generation step somewhere else, this patch should m= ention the new location. This only applies to x86 as we don't have ACPI tables for other archs. The generation step has not moved, it's just that they have always been generated before start-up. I think this might have been overlooked when writing the UEFI code? I'm actually not sure how this worked before on any x86 board. See last_stage_init() which calls write_tables(). Regards, Simon > > > > >Signed-off-by: Simon Glass > >--- > > > > lib/efi_loader/efi_acpi.c | 33 +++++++++++++++++++-------------- > > 1 file changed, 19 insertions(+), 14 deletions(-) > > [..]