From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C34C0C433EF for ; Thu, 30 Sep 2021 04:10:51 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 168B961880 for ; Thu, 30 Sep 2021 04:10:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 168B961880 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8F5BA81F0B; Thu, 30 Sep 2021 06:10:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="W7E5/tx1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A9FFD81F87; Thu, 30 Sep 2021 06:09:13 +0200 (CEST) Received: from mail-ua1-x92c.google.com (mail-ua1-x92c.google.com [IPv6:2607:f8b0:4864:20::92c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3B5EA802C6 for ; Thu, 30 Sep 2021 06:09:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x92c.google.com with SMTP id b34so3197365uad.8 for ; Wed, 29 Sep 2021 21:09:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=O+nGicuckzmfUHuZ9kzSFADxY8Nw3V/k7SHNwNU4hag=; b=W7E5/tx1+oFds/LsBVTQ6U434GzK6OvSGLaWlP+zhEcAaXwt/1CN/LjVK/6NS7naWD tWMZoCWEgVxiYlcQuE2Zb1/lN9pK8HDdosRCySMP8kV9owXBl0dFnbkw/6pSD21sGw2h VjqdVtoOLWjYR0pDsoxqvuNR0BKz8qlavMT9M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O+nGicuckzmfUHuZ9kzSFADxY8Nw3V/k7SHNwNU4hag=; b=iiQroh7d9JPL/JBwOKgRFXhhg+55WM7DvkF9LFogVWY1rE071nokayx8Pxgn4MTZ00 0FVHqAX7ebHGppPR7csv56OGa/4VAHqstxNKiTgDjlfYsSa/7zldvnjfrfUkjjBTmnr4 SDPitubd1BLnFcOFcGUw5S4V+6gbgynN/CTiihXi8fjBqqqBsRj1Id6Nq5HCKqrKvFwQ kuwppsr2wML2ISb9U8FPkNc2ir32Wy7kxDz7AeBy5cHQ+Eg2IkKnUeUNhLx+Stqhh8Bi xAm71+0OCs9AlU+f2eKWVlNIpmE1/YNGJyj3FlqfginCl6lnR33vxnZTv01m2HuRtXf4 5ShA== X-Gm-Message-State: AOAM532rQH+t2y+P6lPr8ff1q+kLax1BAhn4uIuHlztZ3QN1n8tIDGk7 wbXbZ5pIfJm8adRYrav/aWBY+kPcrOlVNANm6TnOfFpVJMA= X-Google-Smtp-Source: ABdhPJwpasBMNpw7IytVVHsK0DbDnrIr5MQhji28A8BKPKQKE1lbcd4y5OPYSTmuO5mQHuvOsDvsJNpN4+awqWKVero= X-Received: by 2002:ab0:5bdc:: with SMTP id z28mr3628141uae.35.1632974938798; Wed, 29 Sep 2021 21:08:58 -0700 (PDT) MIME-Version: 1.0 References: <20210808182031.3747270-1-sjg@chromium.org> <20210808182031.3747270-20-sjg@chromium.org> <20210904150830.GA13888@bill-the-cat> In-Reply-To: <20210904150830.GA13888@bill-the-cat> From: Simon Glass Date: Wed, 29 Sep 2021 22:08:46 -0600 Message-ID: Subject: Re: [PATCH 19/23] i2c: Convert CONFIG_POWER_I2C et al to Kconfig To: Tom Rini Cc: U-Boot Mailing List , Heiko Schocher Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Sat, 4 Sept 2021 at 09:08, Tom Rini wrote: > > On Sun, Aug 08, 2021 at 12:20:27PM -0600, Simon Glass wrote: > > > This converts the following to Kconfig: > > CONFIG_POWER_I2C > > CONFIG_POWER_LEGACY > > > > They are handled at the same time due to a dependency between them. > > Update the Makefile rule to use legacy power only in U-Boot proper. > > > > Unfortunately a separate rule is needed in SPL to be able to build legacy > > power. All of this can be cleaned up when boards are migrated or removed. > > > > Signed-off-by: Simon Glass > > Reviewed-by: Jaehoon Chung > > I'm taking care of this now, but JFYI, this is actually a tricky > conversion where the "hack print" tool I've posted before is required, > along with running it with and without CONFIG_SPL_BUILD defined. At > issue here is that a number of platforms play games with only setting > CONFIG_POWER in SPL, really but moveconfig.py doesn't catch it. You can > see this with the buildman size/bloat functions and that main U-Boot > nows includes drivers/power/power_core.c and its non-DM non-configurable > pmic cmd. What is the 'hack print' tool? Regards, Simon