From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7278FC6FD1D for ; Thu, 30 Mar 2023 23:49:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 819BC85ED1; Fri, 31 Mar 2023 01:48:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="lFSKGsxP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 645FB85ED1; Fri, 31 Mar 2023 01:48:56 +0200 (CEST) Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 15D7B85F04 for ; Fri, 31 Mar 2023 01:48:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ed1-x52e.google.com with SMTP id b20so83188421edd.1 for ; Thu, 30 Mar 2023 16:48:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1680220130; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cjqXfwUEWjDbedcrrsOIB0PusArwUuWeH5ygVHDy7GY=; b=lFSKGsxPIRY3nlsfvx7IYz1+JojprgAGkGYdiNZylgIqdqSI0vaMqFgFC6JQh5n0c9 NahdfuKaAuqqjdmKMZ3HDvMgZKIcu1JdiXjqgGc8GEB1B0IwoOOR9zhMXmaMDHynj0OE dpn3+jUKrVGSGvawJXAs3FBW+APk+zhiqdZew= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680220130; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cjqXfwUEWjDbedcrrsOIB0PusArwUuWeH5ygVHDy7GY=; b=KOoMDj2rbUkFp1f82cSSirzvbsdMVfjXBB9aWnbcptIa6G5PQ6rbtwWwIBW3j0poBx h7j2mfwMLuxYq3Rf6tEu6/tSPthcjVudX2f87AW1cG2LcVrTkbQxsssYCsoJptELim2c aftF59Ek1kW/5U6Npt56w0AeagIqsRmWEu70SRTCC55kkm/Ht1AnReIUCAJh2I7KYHJD huO0v8pdNCbRPAxJHA+iuazwLlEu1q2uYdSdt9GLMRkQ86VHVsJvw+Vs4PsrFjs7vK05 iT9Opo3fszp4e5NMXWzX97ybxGldwxmx0Y+csYlduV8CZhYxZUQgW+8cC+qbH2L7MSPp 8Wlw== X-Gm-Message-State: AAQBX9dyzm+o69Q6BCyd/AOxwWOIf2sLEB3DCJ4W5I1MRYyVm8uJ0JNW nGBT+kU9ijjxgbnw94RF1NygA0mIedtWL8XdOvo3hQ== X-Google-Smtp-Source: AKy350bTNusUm1scqRcWrVEbHiEqJWTlQEIFxZw6oN0gUZsNEQAkbdbB8BMEbwo4pdRfs6NvX3ohQF3M2mTTtFELX2I= X-Received: by 2002:a50:d69a:0:b0:501:d2fb:44bb with SMTP id r26-20020a50d69a000000b00501d2fb44bbmr12390172edi.5.1680220130292; Thu, 30 Mar 2023 16:48:50 -0700 (PDT) MIME-Version: 1.0 References: <20230330213227.2142353-1-sjg@chromium.org> <20230331103047.14.I32eae3bc14e6961dd375dc4b993c62fa22bd5bf7@changeid> <8A50C7B8-3D96-4CAC-BCDE-55DD2AA21918@gmx.de> In-Reply-To: <8A50C7B8-3D96-4CAC-BCDE-55DD2AA21918@gmx.de> From: Simon Glass Date: Fri, 31 Mar 2023 12:48:38 +1300 Message-ID: Subject: Re: [PATCH 14/38] qfw: Show the file address if available To: Heinrich Schuchardt Cc: U-Boot Mailing List , Bin Meng , Andre Przywara , =?UTF-8?Q?Pierre=2DCl=C3=A9ment_Tosi?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Heinrich, On Fri, 31 Mar 2023 at 11:31, Heinrich Schuchardt wrot= e: > > > > Am 30. M=C3=A4rz 2023 23:32:03 MESZ schrieb Simon Glass : > >Some files have an associated address. Show this with the 'qfw list' > >command so that it is possible to dump the data. > > > >Signed-off-by: Simon Glass > >--- > > > > cmd/qfw.c | 2 +- > > doc/usage/cmd/qfw.rst | 28 ++++++++++++++++------------ > > 2 files changed, 17 insertions(+), 13 deletions(-) > > > >diff --git a/cmd/qfw.c b/cmd/qfw.c > >index ae3c6a7a84e9..d6ecfa60d5a7 100644 > >--- a/cmd/qfw.c > >+++ b/cmd/qfw.c > >@@ -26,7 +26,7 @@ static int qemu_fwcfg_cmd_list_firmware(void) > > for (file =3D qfw_file_iter_init(qfw_dev, &iter); > > !qfw_file_iter_end(&iter); > > file =3D qfw_file_iter_next(&iter)) { > >- printf("%-56s\n", file->cfg.name); > >+ printf("%08lx %-56s\n", file->addr, file->cfg.name); > > Are the tables always in the lower 4GiB on all architectures (riscv64, ar= m64, x86)? Yes, so far as I have seen on x86. We don't generate them for ARM or RISC-V. I do want to make sure the addresses are readable. [..] Regards, Simon