From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C5D2ECAAD2 for ; Tue, 30 Aug 2022 02:30:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EC52884951; Tue, 30 Aug 2022 04:30:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="GfJytjxL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9C88184951; Tue, 30 Aug 2022 04:30:05 +0200 (CEST) Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [IPv6:2607:f8b0:4864:20::112c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DDF4B84832 for ; Tue, 30 Aug 2022 04:29:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-333a4a5d495so240363257b3.10 for ; Mon, 29 Aug 2022 19:29:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc; bh=EcufR/60cCNWo3Bp6deyt4L9bCfwgez7EqSjLyv1wr8=; b=GfJytjxLvgzdCMVj/8YLQZ8zQaIkSHaLXwYaFT+a5qnzazMYqPz2V37vsGK0nJuL1j WewBLr6jCMtL+fIqHUpIVr7RvxZjE696PSDMQKuIzjwIEfNjgZkEkg538wpApeIDAZqG MJ1jJ7jZF6avMyxbuyooBN2c6GpS+XtM8jfco= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc; bh=EcufR/60cCNWo3Bp6deyt4L9bCfwgez7EqSjLyv1wr8=; b=tkBw2XgYodrFPBGf9+s4NpX0ArzQJ0Pi0kgiZ34F3Mf57xsCmMNMmBvHyrBzB4GQKX RL1YczJ6eBRva00SyerofBb1CLy36fJi7xcQ0dTv8yNfxJYlW+RlR3JLur7h5hnWDA7z 0tZx0DhXN/vskeAv3bXkrgTe7Pe1r5O3aJpyi5P5mUi119Ffps3yDjl7c6vUtq++RnsR FACOl8xAfCzNXgKFcTyLE1toGcLX9qbeDwQLJFI81H7VJ7yWmKl0RG3qRliHkJIWxr7I ByVkaSlxyV+9M9+bUHUn2LRAX9Y/kTSv/48czVvvZfG/QmM071KHtqWKc35fD71zryNT Xrqw== X-Gm-Message-State: ACgBeo25iDVWGa8A+H6NFQXX8qyM92s/DYLpgsCOfa8zs7ymTZbuw+m3 S1PAC0XV1/vTUYerhFggFCwDGOoTrkuKRsw8MUFOHg== X-Google-Smtp-Source: AA6agR5IoVpTRkEi9tsEX7FS3W1J0YPBEiHAPtOQHy4LDc+6/hOTu5Oy1w/0DninAiaYzDgUZUZq322Xdb5SsLlDN10= X-Received: by 2002:a0d:d850:0:b0:340:d2c0:b022 with SMTP id a77-20020a0dd850000000b00340d2c0b022mr9652696ywe.469.1661826597334; Mon, 29 Aug 2022 19:29:57 -0700 (PDT) MIME-Version: 1.0 References: <20220826075317.1888714-1-pan@semihalf.com> <20220826075317.1888714-5-pan@semihalf.com> In-Reply-To: From: Simon Glass Date: Mon, 29 Aug 2022 20:29:46 -0600 Message-ID: Subject: Re: [PATCH 4/4] arm: dts: chameleonv3: Add 270-2 variant To: =?UTF-8?Q?Pawe=C5=82_Anikiel?= Cc: U-Boot Mailing List , Marek Vasut , Simon Goldschmidt , Tien Fong Chee , Konrad Adamczyk , Marcin Wojtas , Alexandru M Stan Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Pawe=C5=82, On Mon, 29 Aug 2022 at 02:23, Pawe=C5=82 Anikiel wrote: > > On Sat, Aug 27, 2022 at 2:22 AM Simon Glass wrote: > > > > Hi Pawe=C5=82, > > > > On Fri, 26 Aug 2022 at 01:54, Pawe=C5=82 Anikiel wro= te: > > > > > > Add devicetree for chameleonv3 with the 270-2I2-D11E variant of the > > > Mercury+ AA1 module > > > > > > Signed-off-by: Pawe=C5=82 Anikiel > > > --- > > > arch/arm/dts/Makefile | 1 + > > > .../socfpga_arria10_chameleonv3_270_2-u-boot.dtsi | 12 ++++++++++= ++ > > > arch/arm/dts/socfpga_arria10_chameleonv3_270_2.dts | 5 +++++ > > > 3 files changed, 18 insertions(+) > > > create mode 100644 arch/arm/dts/socfpga_arria10_chameleonv3_270_2-u-= boot.dtsi > > > create mode 100644 arch/arm/dts/socfpga_arria10_chameleonv3_270_2.dt= s > > > > > > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile > > > index 7330121dba..36d5d65595 100644 > > > --- a/arch/arm/dts/Makefile > > > +++ b/arch/arm/dts/Makefile > > > @@ -425,6 +425,7 @@ dtb-$(CONFIG_ARCH_SOCFPGA) +=3D = \ > > > socfpga_agilex_socdk.dtb \ > > > socfpga_arria5_secu1.dtb \ > > > socfpga_arria5_socdk.dtb \ > > > + socfpga_arria10_chameleonv3_270_2.dtb \ > > > socfpga_arria10_chameleonv3_270_3.dtb \ > > > socfpga_arria10_chameleonv3_480_2.dtb \ > > > socfpga_arria10_socdk_sdmmc.dtb \ > > > diff --git a/arch/arm/dts/socfpga_arria10_chameleonv3_270_2-u-boot.dt= si b/arch/arm/dts/socfpga_arria10_chameleonv3_270_2-u-boot.dtsi > > > new file mode 100644 > > > index 0000000000..05b4485cf3 > > > --- /dev/null > > > +++ b/arch/arm/dts/socfpga_arria10_chameleonv3_270_2-u-boot.dtsi > > > @@ -0,0 +1,12 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * Copyright 2022 Google LLC > > > + */ > > > +#include "socfpga_arria10_chameleonv3_480_2_handoff.h" > > > +#include "socfpga_arria10-handoff.dtsi" > > > +#include "socfpga_arria10_handoff_u-boot.dtsi" > > > +#include "socfpga_arria10_mercury_aa1-u-boot.dtsi" > > > + > > > +&fpga_mgr { > > > + altr,bitstream =3D "fpga-270-2.itb"; > > > +}; > > > diff --git a/arch/arm/dts/socfpga_arria10_chameleonv3_270_2.dts b/arc= h/arm/dts/socfpga_arria10_chameleonv3_270_2.dts > > > new file mode 100644 > > > index 0000000000..5f40af6eb9 > > > --- /dev/null > > > +++ b/arch/arm/dts/socfpga_arria10_chameleonv3_270_2.dts > > > @@ -0,0 +1,5 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * Copyright 2022 Google LLC > > > + */ > > > +#include "socfpga_arria10_chameleonv3.dts" > > > > Can you create a common .dtsi file instead? We should not be including > > a .dts file into another file. > > > Do you mean renaming chameleonv3.dts to .dtsi? In Linux it's a .dts, > because nothing includes it (no handoff headers are needed). Is it > fine to have the names differ across U-Boot and Linux? Ideally not, but we should not include a .dts file in another one and it is probably more important to follow that rule. But why is Linux not getting this variant? Regards, Simon