From: Simon Glass <sjg@chromium.org>
To: Tom Rini <trini@konsulko.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Luca Ceresoli <luca@lucaceresoli.net>,
Bin Meng <bmeng.cn@gmail.com>,
Roger Pau Monne <royger@freebsd.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: [PATCH 1/4] Makefile: Add a Python-based CONFIG checker
Date: Wed, 14 Sep 2022 16:39:18 -0600 [thread overview]
Message-ID: <CAPnjgZ2V-AMbv3CDz6kS+oD5O06HJmp7JXkq+K_wNgyvO5tC_A@mail.gmail.com> (raw)
In-Reply-To: <20220914184715.GT6993@bill-the-cat>
Hi Tom,
On Wed, 14 Sept 2022 at 12:47, Tom Rini <trini@konsulko.com> wrote:
>
> On Mon, Aug 29, 2022 at 07:57:04AM -0600, Simon Glass wrote:
> > The existing shell script is a bit ugly. It was picked up by
> > Chromium OS and then rewritten in Python, adding unit tests. Bring this
> > new version into U-Boot.
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > ---
> >
> > scripts/kconfig_check.py | 338 ++++++++++++++++++++++++++++++++++
> > scripts/test_kconfig_check.py | 185 +++++++++++++++++++
> > 2 files changed, 523 insertions(+)
> > create mode 100755 scripts/kconfig_check.py
> > create mode 100755 scripts/test_kconfig_check.py
>
> All told, this ends up being +400 or so lines to replace a shell script
> with Python. I'm not sure that's a win overall.
It is more maintainable, has tests (which should not detract from line
count) and uses kconfiglib. We could remove the non-kconfig code
perhaps, but half the code is comments.
Perhaps we are going to delete all this anyway soon, I'm not sure?
Regards,
Simon
>
> --
> Tom
next prev parent reply other threads:[~2022-09-14 22:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 13:57 [PATCH 1/4] Makefile: Add a Python-based CONFIG checker Simon Glass
2022-08-29 13:57 ` [PATCH 2/4] Makefile: Switch over to the " Simon Glass
2022-08-29 13:57 ` [PATCH 3/4] CI: Add kconfig checker tests to gitlab/azure Simon Glass
2022-08-29 13:57 ` [PATCH 4/4] pylibfdt: fix with Python 3.10 Simon Glass
2022-09-14 18:47 ` [PATCH 1/4] Makefile: Add a Python-based CONFIG checker Tom Rini
2022-09-14 22:39 ` Simon Glass [this message]
2022-09-15 18:32 ` Tom Rini
2022-09-16 1:30 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPnjgZ2V-AMbv3CDz6kS+oD5O06HJmp7JXkq+K_wNgyvO5tC_A@mail.gmail.com \
--to=sjg@chromium.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bmeng.cn@gmail.com \
--cc=luca@lucaceresoli.net \
--cc=royger@freebsd.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).