From: Simon Glass <sjg@chromium.org>
To: "Marek Behún" <kabel@kernel.org>
Cc: "Tom Rini" <trini@konsulko.com>,
"U-Boot Mailing List" <u-boot@lists.denx.de>,
"Marek Behún" <marek.behun@nic.cz>
Subject: Re: [PATCH v3 12/13] env: Simplify env_match() and inline into env_get_f()
Date: Mon, 18 Oct 2021 12:12:12 -0600 [thread overview]
Message-ID: <CAPnjgZ2zgt+=oE4dBzSNz_qm3ngBNpEg6Sk+Ar0-_Em9=zbz9A@mail.gmail.com> (raw)
In-Reply-To: <20211017153638.29870-13-kabel@kernel.org>
On Sun, 17 Oct 2021 at 09:37, Marek Behún <kabel@kernel.org> wrote:
>
> From: Marek Behún <marek.behun@nic.cz>
>
> In the past the env_match() function was used to match envs with
> - name, i.e. string "name"
> - variable assignment, i.e. string "name=other_value"
>
> The latter is not the case anymore, since the env_match() function is
> now used only in env_get_f(), and so we can simplify the function into
> a simple strncmp() with an additional comparison to '='.
>
> Let's do this, and since the resulting function is quite simple, let's
> also inline its code into env_get_f().
>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> ---
> cmd/nvedit.c | 19 +++++--------------
> 1 file changed, 5 insertions(+), 14 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
next prev parent reply other threads:[~2021-10-18 18:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 15:36 [PATCH v3 00/13] env_get_char() removal and env_get_f() refactor Marek Behún
2021-10-17 15:36 ` [PATCH v3 01/13] env: Fix documentation for env_get_f() Marek Behún
2021-10-17 15:36 ` [PATCH v3 02/13] env: Drop env_get_char_spec() and old, unused .get_char() implementations Marek Behún
2021-10-17 15:36 ` [PATCH v3 03/13] examples: api: glue: Remove comment that does not apply anymore Marek Behún
2021-10-17 15:36 ` [PATCH v3 04/13] env: Change env_match() to static and remove from header Marek Behún
2021-10-17 15:36 ` [PATCH v3 05/13] env: Inline env_get_char() into its only user Marek Behún
2021-10-17 15:36 ` [PATCH v3 06/13] env: Use string pointer instead of indexes in env_get_f() Marek Behún
2021-10-17 15:36 ` [PATCH v3 07/13] env: Use better name for variable " Marek Behún
2021-10-17 15:36 ` [PATCH v3 08/13] env: Don't match empty variable name in env_match() Marek Behún
2021-10-17 15:36 ` [PATCH v3 09/13] env: Early return from env_get_f() on NULL name Marek Behún
2021-10-17 15:36 ` [PATCH v3 10/13] env: Make return value of env_get_f() behave like sprintf() on success Marek Behún
2021-10-17 15:36 ` [PATCH v3 11/13] env: Use memcpy() instead of ad-hoc code to copy variable value Marek Behún
2021-10-17 15:36 ` [PATCH v3 12/13] env: Simplify env_match() and inline into env_get_f() Marek Behún
2021-10-18 18:12 ` Simon Glass [this message]
2021-10-19 0:49 ` Marek Behún
2021-10-19 14:11 ` Simon Glass
2021-10-21 18:49 ` Simon Glass
2021-10-17 15:36 ` [PATCH v3 13/13] env: Move non-cli env functions to env/common.c Marek Behún
2021-10-21 18:49 ` Simon Glass
2021-10-21 18:49 ` [PATCH v3 11/13] env: Use memcpy() instead of ad-hoc code to copy variable value Simon Glass
2021-10-21 18:49 ` [PATCH v3 10/13] env: Make return value of env_get_f() behave like sprintf() on success Simon Glass
2021-10-21 18:49 ` [PATCH v3 09/13] env: Early return from env_get_f() on NULL name Simon Glass
2021-10-21 18:49 ` [PATCH v3 07/13] env: Use better name for variable in env_get_f() Simon Glass
2021-10-21 18:49 ` [PATCH v3 08/13] env: Don't match empty variable name in env_match() Simon Glass
2021-10-21 18:49 ` [PATCH v3 06/13] env: Use string pointer instead of indexes in env_get_f() Simon Glass
2021-10-21 18:49 ` [PATCH v3 05/13] env: Inline env_get_char() into its only user Simon Glass
2021-10-21 18:49 ` [PATCH v3 03/13] examples: api: glue: Remove comment that does not apply anymore Simon Glass
2021-10-21 18:49 ` [PATCH v3 04/13] env: Change env_match() to static and remove from header Simon Glass
2021-10-21 18:49 ` [PATCH v3 02/13] env: Drop env_get_char_spec() and old, unused .get_char() implementations Simon Glass
2021-10-21 18:49 ` [PATCH v3 01/13] env: Fix documentation for env_get_f() Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPnjgZ2zgt+=oE4dBzSNz_qm3ngBNpEg6Sk+Ar0-_Em9=zbz9A@mail.gmail.com' \
--to=sjg@chromium.org \
--cc=kabel@kernel.org \
--cc=marek.behun@nic.cz \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).