From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1FC3C433F5 for ; Mon, 27 Sep 2021 20:15:23 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC7A260EC0 for ; Mon, 27 Sep 2021 20:15:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DC7A260EC0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D226082952; Mon, 27 Sep 2021 22:15:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="m2bLOKWe"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B482182314; Mon, 27 Sep 2021 22:15:18 +0200 (CEST) Received: from mail-ua1-x92a.google.com (mail-ua1-x92a.google.com [IPv6:2607:f8b0:4864:20::92a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8AC2382D1C for ; Mon, 27 Sep 2021 22:15:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x92a.google.com with SMTP id i8so10965214uae.7 for ; Mon, 27 Sep 2021 13:15:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VdNp0WM54nan3onPHKDOG6GDvHkmfAfHZKYTUTjwp3I=; b=m2bLOKWeuVtihXCFSm8PrEPPPpXwLXsEulLd8upW5GTEB/aSrryXjJdvuncg2Mv6cr htz4CGCpefyfsFYfOGqrigQGs4AJJ088P+Is8k4JNpMdiiQDiorGVZeehm6GsfKi/KrF pW7DYR/U0VNUhtS8NB7fqdP/lPuugoPWIsvys= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VdNp0WM54nan3onPHKDOG6GDvHkmfAfHZKYTUTjwp3I=; b=jj7TsIxJx8Hnb9o7U0vuB2XZKrJ+WfSHE8gpd3b2PPfpgVvkTw7rzoMv+sZIwJDMUI 6jH6f3jc0qpSCcKhRr45pU2vnQF8R6dR/IsWzskWBcyn8Odfo6OpgXnN7B2JYgwnsjca s7KoaRU873CM5qNuBUB84x1K9fQ9qpqpSD0R20JpKnqnhdKMBjEDNRHuyhfhh4jIp1N+ N6SCp3jLcvy2jcKc2Cr6KwCiHsWIDbHAzcEUyNiHDvcCDnToHBE5E+eTCfR/bKSc0yQj 1OhBIfvz54WZcRUMOc+R3TPb1dkKsM1ahBJAljfbwF9/l9pQx/W+gpdk9AddbwwueT9w VGgw== X-Gm-Message-State: AOAM531/YhKMvc5R61AOAObCK0vXe11qSOz+N/lkVpYLHlZ0X351EJlx WoQDAb9ieUoB3yiIcM5n/3XewvSJKd5oEcX6T03aZQ== X-Google-Smtp-Source: ABdhPJxVKdfGI83dBOJYZ9pZ79D1doKWgA7urpToXEG2wK70geoxWlyz3YYggodRljB43DR01sz80Oo9isolWaffabc= X-Received: by 2002:ab0:14a7:: with SMTP id d36mr1925970uae.96.1632773707961; Mon, 27 Sep 2021 13:15:07 -0700 (PDT) MIME-Version: 1.0 References: <20210927064751.78591-1-ilias.apalodimas@linaro.org> In-Reply-To: <20210927064751.78591-1-ilias.apalodimas@linaro.org> From: Simon Glass Date: Mon, 27 Sep 2021 14:14:57 -0600 Message-ID: Subject: Re: [PATCH 1/3] treewide: Remove OF_PRIOR_STAGE from RISC-V boards To: Ilias Apalodimas Cc: Tom Rini , Mark Kettenis , Bharat Gooty , Rayagonda Kokatanur , Rick Chen , Leo , Thomas Fitzsimmons , Bin Meng , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Green Wan , Sean Anderson , Lukas Auer , Brad Kim , Zong Li , Heinrich Schuchardt , David Abdurachmanov , Dimitri John Ledkov , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Mon, 27 Sept 2021 at 00:48, Ilias Apalodimas wrote: > > At some point back in 2018 prior_stage_fdt_address and OF_PRIOR_STAGE got > introduced, in order to support a DTB handed over by an earlier stage boo > loader. However we have another option in the Kconfig (OF_BOARD) which has > identical semantics. > > On RISC-V boards which during their startup, some of the platforms, pick > up the DTB from a1 and copy it in their private gd_t. Apart from that they > copy it to prior_stage_fdt_address, if the Kconfig option is selected, > which is unnecessary. > > So let's switch the config option for those boards to OF_BOARD and define > the required board_fdt_blob_setup() for them. > > Signed-off-by: Ilias Apalodimas > --- > arch/riscv/cpu/cpu.c | 3 --- > arch/riscv/cpu/start.S | 5 ----- > arch/riscv/dts/binman.dtsi | 6 +++--- > board/AndesTech/ax25-ae350/ax25-ae350.c | 1 - > board/emulation/qemu-riscv/qemu-riscv.c | 9 +++++++++ > board/sifive/unleashed/unleashed.c | 10 ++++------ > board/sifive/unmatched/unmatched.c | 10 ++++------ > configs/ae350_rv32_defconfig | 2 +- > configs/ae350_rv32_spl_defconfig | 2 +- > configs/ae350_rv64_defconfig | 2 +- > configs/ae350_rv64_spl_defconfig | 2 +- > configs/qemu-riscv32_defconfig | 2 +- > configs/qemu-riscv32_smode_defconfig | 2 +- > configs/qemu-riscv32_spl_defconfig | 2 +- > configs/qemu-riscv64_defconfig | 2 +- > configs/qemu-riscv64_smode_defconfig | 2 +- > configs/qemu-riscv64_spl_defconfig | 2 +- > dts/Kconfig | 2 +- > 18 files changed, 31 insertions(+), 35 deletions(-) Reviewed-by: Simon Glass