From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 156B3C761AF for ; Sun, 2 Apr 2023 02:26:51 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C0EDF85801; Sun, 2 Apr 2023 04:26:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="URrNauN8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DC6D985845; Sun, 2 Apr 2023 04:26:45 +0200 (CEST) Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2D32D8573D for ; Sun, 2 Apr 2023 04:26:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ed1-x533.google.com with SMTP id eh3so104425092edb.11 for ; Sat, 01 Apr 2023 19:26:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1680402402; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VdZWTlaZWzQ8/sOL9yYUTvSKL1+2rMGDlZi3X0XZvRo=; b=URrNauN839/4/WJ5x5Rlm3g/6M025/g6N4d7kEnqolS1KLnoC9WN04NR/tpbeTvkSH QdHhqHza23ONeUf/j0qk0WaXxX+Cw2tJ6RJoOHQ9Sbg0lzmc/WUur1yDQfjhIXVLRVDp z9VfxE6qe4iYH8Nee/QMhAnxMHcqSAykRemEI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680402402; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VdZWTlaZWzQ8/sOL9yYUTvSKL1+2rMGDlZi3X0XZvRo=; b=Zn9/SE3SYJWWqj7fcJy8EpOO2h9sz/OvEIg77DXNCiiIR76gWWtoRmCmM6OZULhcM5 es6WlwxoF386b4iUg8sW/Wvkrj/YxXhC2OM2mZXJe2xnVIuzbGByhMQjsMt4hG7gsSMd IsnZy2IrYVP51MtdaO4iG07Ncu94DMLV/e/zj4802bAhCKbfM4mKBrFfzMmAwfXpgung TamHdAWUpPbYXo6wCpvLsKjuV3/BAC1JhZeN3k+nS4uBcliSsgl4vPMbOHHJweRhsJmJ YFfUZTYF8pVrcy1A9rgNPB4fiEHqgnznErzSG2EIEaVOP+yl8oXKQVDmqs6neuwyzujN 9G2g== X-Gm-Message-State: AAQBX9dzsHLd48qTrGYdNfs3TFZ/oyiKiPDm9EZssP4yJdZXbkMRQSFr vft8o0EK+J2CtqzORRSbpEAJ18KyBAnFEv7WUijAug== X-Google-Smtp-Source: AKy350YmRNuX8oqJIj2WfS7n3VBDoN17Gr9r0W9uVhZZuefOlhJK6mZ4E2rQ7oKaSibRw/8f9859kQp/vC7K6gx/KGw= X-Received: by 2002:a17:906:7217:b0:932:6a2:ba19 with SMTP id m23-20020a170906721700b0093206a2ba19mr16522134ejk.14.1680402402395; Sat, 01 Apr 2023 19:26:42 -0700 (PDT) MIME-Version: 1.0 References: <20230401071411.110815-1-heinrich.schuchardt@canonical.com> In-Reply-To: <20230401071411.110815-1-heinrich.schuchardt@canonical.com> From: Simon Glass Date: Sun, 2 Apr 2023 14:26:28 +1200 Message-ID: Subject: Re: [PATCH 1/1] cmd: convert fallthrough comment. To: Heinrich Schuchardt Cc: Tom Rini , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.39 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Sat, 1 Apr 2023 at 20:14, Heinrich Schuchardt < heinrich.schuchardt@canonical.com> wrote: > > gcc does not understand /* FALL TROUGH */ and emits a warning: > > cmd/date.c: In function =E2=80=98do_date=E2=80=99: > cmd/date.c:62:20: warning: > this statement may fall through [-Wimplicit-fallthrough=3D] > 62 | if (strcmp(argv[1],"reset") =3D=3D 0) { > | ^ > cmd/date.c:102:9: note: here > 102 | case 1: /* get date & time */ > | ^~~~ > > Use the fallthrough macro instead. > > Signed-off-by: Heinrich Schuchardt > --- > cmd/date.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass