From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9588ECAAD3 for ; Tue, 30 Aug 2022 02:31:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7DB25849AC; Tue, 30 Aug 2022 04:30:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="EyzzYIt2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 30AED8493A; Tue, 30 Aug 2022 04:30:28 +0200 (CEST) Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D227184974 for ; Tue, 30 Aug 2022 04:30:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-33dce2d4bc8so240829977b3.4 for ; Mon, 29 Aug 2022 19:30:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=Zui7iMKcy8KeUdQnytHbQYZ/zz9hWUaU69aCEjCWuoU=; b=EyzzYIt27ayf3NSCLn34IQhjvmu2BFjUD8pYo2+gpWYu4+jHgWNAkKqJiVLQmRBLor jh0FlKVECiQ9hlvVoYLMwTbycAIwvEGa+W5erBMvo96Y20JU4SAQpqL/HxDHLW753No8 e7e1HuDM3z8jyGhfbpXx8GMRTBCG/OaR8xEBA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=Zui7iMKcy8KeUdQnytHbQYZ/zz9hWUaU69aCEjCWuoU=; b=UPJtQ3cGWve/khNGuZvluxuP+RIFjoCrZo/fC053paflNopi/Tv6yuyXWzxq3bqhoz fV1GLcoBjCwrYJubdGojQknKnPKJ+WKw58Ch+bxsJzNFakuSowPdYgFsNC4Zya2uAljB QK5gSPejQ1j8iDtzmZp0giiWHz1k08S/wRvX6NMTQ4lTh7zi+TQ7rOSN38bBt1OwETey sHfpxoinEk89NVvwjTyE8bul8BkHPZD8G364ZCo8pbgYfJKPISACL9kXB8l/y2JGBbSG JcLqpsF9as00NRRpoI1p4YxWme8eZfI/w4uuvQMFP6yZgEWf24f/7KGWFJjh0CmcebIP Lqtw== X-Gm-Message-State: ACgBeo1vr61ju5/LYAmNvUuwxs7Y+GtJAan35js4njoysD/PlCzKblPm ZZL+YbcOnWXWiOtb/Ulxy3ErK2RO4vbi+4bPV/2giNS4wEje38Cc X-Google-Smtp-Source: AA6agR5kHa4MRQ1C23jwpcUKnO91Dgj+ng4jVg4haXDKHCnbns2bJ4kQ06Eel/4jlI0jVAJbK5x+aIlxiCxcXLPRtRc= X-Received: by 2002:a25:6003:0:b0:68c:870b:2405 with SMTP id u3-20020a256003000000b0068c870b2405mr10371366ybb.9.1661826624341; Mon, 29 Aug 2022 19:30:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Simon Glass Date: Mon, 29 Aug 2022 20:30:12 -0600 Message-ID: Subject: Re: [PATCH v4 2/2] image-fit: don't set compression if it can't be read To: Daniel Golle Cc: Tom Rini , U-Boot Mailing List , Alexandru Gagniuc , Chia-Wei Wang , Sean Anderson , Heinrich Schuchardt , Joel Stanley Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Fri, 26 Aug 2022 at 21:18, Daniel Golle wrote: > > fit_image_get_comp() should not set value -1 in case it can't read > the compression node. Instead, leave the value untouched in that case > as it can be absent and a default value previously defined by the > caller of fit_image_get_comp() should be used. > > As a result the warning message > WARNING: 'compression' nodes for ramdisks are deprecated, please fix your .its file! > no longer shows if the compression node is actually absent. > > Signed-off-by: Daniel Golle > --- > v2: fix typo 'imape_comp' vs. 'image_comp' > v3: rather fix the typo everywhere in an additional patch before > v4: rebase on updated patch fixing typo > > boot/bootm.c | 6 ++---- > boot/image-fit.c | 3 +-- > cmd/ximg.c | 7 ++----- > 3 files changed, 5 insertions(+), 11 deletions(-) Reviewed-by: Simon Glass