From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 469A5C7619A for ; Mon, 3 Apr 2023 01:17:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DF18B85C52; Mon, 3 Apr 2023 03:17:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="RYZYZDUe"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9809685C5F; Mon, 3 Apr 2023 03:17:00 +0200 (CEST) Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B9AA685C68 for ; Mon, 3 Apr 2023 03:16:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ed1-x529.google.com with SMTP id ew6so111031541edb.7 for ; Sun, 02 Apr 2023 18:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1680484610; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=9idmMYbECsxg2UouuLx2pzr/rYx9hP82Z/iaQ+poMCY=; b=RYZYZDUegZxytfiGPUpUwLTSMe34iEiFIvQEXE6z3HIQn050coMfkUJCqc07D51TFF BiS5g9Ap65k1ok6XQbxqlkjbBJV9i4lfFK42ZQ4PC/LT0ywaHwv41VQJdyWJRWfD4cMi hAQ63Pk9ozHLiT62yYpnckzSNGkwCf0l0Bndc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680484610; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9idmMYbECsxg2UouuLx2pzr/rYx9hP82Z/iaQ+poMCY=; b=jJn3SFZMW2XNYYaRUYL/5Rdtzbd+KVb03vKFguGBQqAWWm3Vv3xN14l5IAVsHa8J9I whjTa9iB0P0k2ATxLZa3n7da3zmzB+AbP/eF8oZk8Zzp5LGPdzvsd1/SWIlNKFUkkBE6 oNOsYzGp8IILjz5Wk06xDJ7eFYtC5UJS6tUCy4ish/zgBjiuPG1TmoTb2zKJIJbptvjt 5+MsnuMMO4wkrpFHwMER9+5/FMmiQxL9RmDxggN3bXw++2I3ca6GhO4Jx3cR2joVlDxz LjGaIicGaeXVDrW5WC+AAh3ZtTNYKs4GY/Xdc79oGxGKtZkmeP3MVZlNsjTdbn/Bh7KY cOqg== X-Gm-Message-State: AAQBX9d1VZp7J6yOatmVu7J0/XFeMip+XW+Qqv6vQ0b9pgLTc9XL/CqT ZcLxK3XRDqzWdxf8bKy7i4SlkI3wN0zm1TooJg0xHQ== X-Google-Smtp-Source: AKy350Z3X0U/+mOfoP1Y5tjeF2pfFamGFIN/PFzL5FXD6LgP3BFw2y6k5n1og4FKx6XREuNsrEkZvUujWPpsmEI9aO4= X-Received: by 2002:a17:907:2101:b0:931:2196:b863 with SMTP id qn1-20020a170907210100b009312196b863mr14966355ejb.14.1680484610004; Sun, 02 Apr 2023 18:16:50 -0700 (PDT) MIME-Version: 1.0 References: <20230319192957.1084530-1-sjg@chromium.org> <20230331141703.GV13222@bill-the-cat> <20230403000613.GA37805@laputa> In-Reply-To: <20230403000613.GA37805@laputa> From: Simon Glass Date: Mon, 3 Apr 2023 13:16:38 +1200 Message-ID: Subject: Re: [PATCH v2] disk: Use a helper function to reduce duplication To: AKASHI Takahiro , Tom Rini , Simon Glass , U-Boot Mailing List , Ilias Apalodimas , Heinrich Schuchardt Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.39 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi, On Mon, 3 Apr 2023, 12:06 AKASHI Takahiro, wrote: > Hi Tom, > > On Fri, Mar 31, 2023 at 10:17:03AM -0400, Tom Rini wrote: > > On Mon, Mar 20, 2023 at 08:29:57AM +1300, Simon Glass wrote: > > > > > Reduce the duplicated code slightly by using a helper function to > handle > > > the common code. > > > > > > This reduces the code size very slightly. > > > > > > Signed-off-by: Simon Glass > > > > Applied to u-boot/next, thanks! > > I think I said nak against this patch. > https://lists.denx.de/pipermail/u-boot/2023-March/512677.html Yes,sorry I did'nt get back to it. If this applied I wonder if there is test coverage missing. Do you think you could add a test for it? I am afk so cannot send a revert for a few days,if someone else can? Regards, Simon > > > -Takahiro Akashi > > > > -- > > Tom > > >