From: Simon Glass <sjg@chromium.org>
To: Simon Glass <sjg@chromium.org>
Cc: u-boot@lists.denx.de, Hannu Lounento <hannu.lounento@vaisala.com>
Subject: Re: [PATCH] image.h: make image_sign_info.fit point to const
Date: Sun, 31 Oct 2021 13:57:14 +0100 [thread overview]
Message-ID: <CAPnjgZ3QEzd6tM6p-MZ8GhdZev=5UbWqe1zO71BXr=6RUjFcTg@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ09KaBPN+UYmJapzQDjM=jZkCPc5FFi9Ls4XybaODLjDw@mail.gmail.com>
On Sun, 17 Oct 2021 at 23:49, Hannu Lounento <hannu.lounento@vaisala.com> wrote:
>
> The data blob apparently does not need to be modified through the fit
> field of the image_sign_info struct so make it point to const to avoid
> the need to cast away constness in functions that assign a pointer to
> const data to the field.
>
> fit_image_setup_verify already had to cast away constness as it assigned
> a const void * argument to the field. The cast can now be removed.
>
> Signed-off-by: Hannu Lounento <hannu.lounento@vaisala.com>
> ---
> common/image-fit-sig.c | 2 +-
> include/image.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot-dm, thanks!
prev parent reply other threads:[~2021-10-31 13:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 5:49 [PATCH] image.h: make image_sign_info.fit point to const Hannu Lounento
2021-10-29 1:16 ` Simon Glass
2021-10-31 12:57 ` Simon Glass [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPnjgZ3QEzd6tM6p-MZ8GhdZev=5UbWqe1zO71BXr=6RUjFcTg@mail.gmail.com' \
--to=sjg@chromium.org \
--cc=hannu.lounento@vaisala.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).