u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: Stefan Herbrechtsmeier <stefan.herbrechtsmeier-oss@weidmueller.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	 Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>,
	 AKASHI Takahiro <takahiro.akashi@linaro.org>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	 Oleksii Bidnichenko <oleksii.bidnichenko@toradex.com>,
	Sean Anderson <sean.anderson@seco.com>, schspa <schspa@gmail.com>
Subject: Re: [PATCH] disk: part: remove dependency to ubifs for spl
Date: Mon, 8 Aug 2022 13:26:29 -0600	[thread overview]
Message-ID: <CAPnjgZ3R=j_QpVPYonYu_nxCLp4Uxn1EESR23z-=6-icJOHvjQ@mail.gmail.com> (raw)
In-Reply-To: <20220808144517.22967-1-stefan.herbrechtsmeier-oss@weidmueller.com>

Hi Stefan,

On Mon, 8 Aug 2022 at 08:45, Stefan Herbrechtsmeier
<stefan.herbrechtsmeier-oss@weidmueller.com> wrote:
>
> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>
> The spl doesn't support ubifs and thereby doesn't provide the
> ubifs_is_mounted function. Remove the dependency to ubifs for the spl.
>
> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>
> ---
>
>  disk/part.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/disk/part.c b/disk/part.c
> index 79955c7fb0..de1b917e84 100644
> --- a/disk/part.c
> +++ b/disk/part.c
> @@ -479,7 +479,7 @@ int blk_get_device_part_str(const char *ifname, const char *dev_part_str,
>         }
>  #endif
>
> -#ifdef CONFIG_CMD_UBIFS
> +#if IS_ENABLED(CONFIG_CMD_UBIFS) && !IS_ENABLED(CONFIG_SPL_BUILD)
>         /*
>          * Special-case ubi, ubi goes through a mtd, rather than through
>          * a regular block device.
> --
> 2.30.2
>

A CMD config should not be used outside cmd/ - can we add a proper
CONFIG_UBIFS ?

Regards,
Simon

  reply	other threads:[~2022-08-08 19:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08 14:45 [PATCH] disk: part: remove dependency to ubifs for spl Stefan Herbrechtsmeier
2022-08-08 19:26 ` Simon Glass [this message]
2022-08-09  7:27   ` Stefan Herbrechtsmeier
2022-08-27 12:06 ` Tom Rini
2022-08-29 15:01 ` Heinrich Schuchardt
2022-08-29 15:53   ` Stefan Herbrechtsmeier
2022-08-30  2:29     ` Simon Glass
2022-08-30  7:58       ` Stefan Herbrechtsmeier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ3R=j_QpVPYonYu_nxCLp4Uxn1EESR23z-=6-icJOHvjQ@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=oleksii.bidnichenko@toradex.com \
    --cc=schspa@gmail.com \
    --cc=sean.anderson@seco.com \
    --cc=stefan.herbrechtsmeier-oss@weidmueller.com \
    --cc=stefan.herbrechtsmeier@weidmueller.com \
    --cc=takahiro.akashi@linaro.org \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).