From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DBC9C433F5 for ; Sat, 25 Sep 2021 15:46:30 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D8276109D for ; Sat, 25 Sep 2021 15:46:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6D8276109D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E81E48353B; Sat, 25 Sep 2021 17:46:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="LwDoijFQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9C3FA83549; Sat, 25 Sep 2021 17:46:25 +0200 (CEST) Received: from mail-vs1-xe2a.google.com (mail-vs1-xe2a.google.com [IPv6:2607:f8b0:4864:20::e2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8170D8323F for ; Sat, 25 Sep 2021 17:46:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vs1-xe2a.google.com with SMTP id 188so12301661vsv.0 for ; Sat, 25 Sep 2021 08:46:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4sbSPSvZ2D0JNBpUWf3hQAZWmVwVVOZQzrust1B6ehY=; b=LwDoijFQuwUiybhqGsTodm7D43nRUoLfUsNfycGdRUg7qpPdd034Ma1yJGgthypaVH OjRemVidpfCK5GErXiidcEZulXqNY27XTXnoADpIQzfBKFw+eOMbG5qv0EA1PjPIHhH6 3mEN8ZLEdq437x56kNmnfjPYvT2xiuOC82/ck= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4sbSPSvZ2D0JNBpUWf3hQAZWmVwVVOZQzrust1B6ehY=; b=bQDeqXCdCTmqCBSWXHLRT5RRLYRHWPOrw/GcpT4WzCVF+lCepMlqWfrTmZ/uO1iSzm cineImh6WnIfvFuqRsJ4pF8VqqnaeM0uSVOiUK8sKH6I6b/JfPVrAOCEFsAdfgMCw5TH VQzuVWmEKvDt9ytEMuaKFuKaNOtohS7NQAauwbjwn5GHU5kPpgzSyThVsVE3/QPxOd0I d+w5ZPSNRHCTgW+7+lWiPysPJI2MZH8JEv9IpRH2KW+rW4xwNKHPlZiCfYeYJwUWcdLI /tBouYLYHQERybgtOjUWjHTvo97FJm597oaPt7tr856a4GtquAieeeKkuoSFQNGzZ/pI gtvw== X-Gm-Message-State: AOAM533h/jMGhT7y60bjq4o5Zb81wNMafCsFqqfm9VTgGfycIKFdBg0H A+UfsrMUtBhmlTsOoOI8nCR+3G9HIxAYcNXbnRrbt/8uzLQxCg== X-Google-Smtp-Source: ABdhPJxLR6hChLVVVxfWvDbLRtg3ISmeKaSQGc4v01g+3uCeBbHDu2Chz9i3/KGxhvo8/VT8BBI94p7n+SEc1/e41x0= X-Received: by 2002:a67:67c1:: with SMTP id b184mr14534655vsc.59.1632584779902; Sat, 25 Sep 2021 08:46:19 -0700 (PDT) MIME-Version: 1.0 References: <20210801205951.2202789-1-sjg@chromium.org> <20210801205951.2202789-2-sjg@chromium.org> <22eb78079a4f99f2966c99a59872b439de0a2237.camel@buserror.net> In-Reply-To: From: Simon Glass Date: Sat, 25 Sep 2021 09:46:08 -0600 Message-ID: Subject: Re: [PATCH v3 2/3] arm: Add an __image_copy_start symbol for ARMv8 To: Scott Wood Cc: U-Boot Mailing List , Tim Harvey , Albert Aribaud , Tom Rini Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Scott, On Thu, 5 Aug 2021 at 13:20, Simon Glass wrote: > > Hi Scott, > > On Wed, 4 Aug 2021 at 13:53, Scott Wood wrote: > > > > On Sun, 2021-08-01 at 14:59 -0600, Simon Glass wrote: > > > This symbol is needed for binman to locate the start of the image. Add it. > > > > > > Note: the existing line to bring in the .__image_copy_start symbol does > > > not appear to do anything. > > > > > > Signed-off-by: Simon Glass > > > --- > > > I have copied Scott Wood who originally added the line about the > > > __image_copy_start in the hope that he can decide if we should remove it. > > > > It's been a long time since I looked at this stuff, but __image_copy_start is > > used for relocation and that code does not seem to be in the SPL, so the > > *(.__image_copy_start) was probably just a copy-and-paste leftover from the > > main SPL that can go away. > > > > Of course, that doesn't resolve the binman issue. :-) > > > > > diff --git a/arch/arm/cpu/armv8/u-boot-spl.lds b/arch/arm/cpu/armv8/u-boot- > > > spl.lds > > > index 9edb662b094..2827a07590d 100644 > > > --- a/arch/arm/cpu/armv8/u-boot-spl.lds > > > +++ b/arch/arm/cpu/armv8/u-boot-spl.lds > > > @@ -22,6 +22,7 @@ ENTRY(_start) > > > SECTIONS > > > { > > > .text : { > > > + __image_copy_start = .; > > > . = ALIGN(8); > > > *(.__image_copy_start) > > > CPUDIR/start.o (.text*) > > > > If for whatever reason you did need to define the symbol this way, shouldn't > > it be after the alignment? > > Well I don't want to miss out any of the image, otherwise the offsets > would be off. > > But perhaps that is another question. Since this is the first section, > it should already be aligned (to 16 I suspect). So why do we need it? I'd like to get this applied, assuming it is correct, because at present binman is silently ignoring problems where it cannot find symbols. The fix for that is: http://patchwork.ozlabs.org/project/uboot/patch/20210722210216.1.Id1246d1ff1cb5750f8c7ddde9665cf6f09615a7c@changeid/ which has been sitting there for a while. Regards, Simon