From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A203EC433F5 for ; Fri, 24 Sep 2021 08:36:58 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D53C961211 for ; Fri, 24 Sep 2021 08:36:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D53C961211 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5D10E833DA; Fri, 24 Sep 2021 10:36:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="AhzLTv6m"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 738B183422; Fri, 24 Sep 2021 10:36:51 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20619.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1a::619]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A87F98338C for ; Fri, 24 Sep 2021 10:36:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=wasim.khan@oss.nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BUx4HL7UJ3RnZ0dU0yD3tT6rnUYKlr5ctlKKNEqvJEP0eRt1bOSAqPKxJloEeT7VcuD5OpdhKIFJGLwUoA4dDAO7Il9diJ8Rw/Gu7AODfeNnpNhksDrAiURJlMc1k6s5itGg9Ym/oMLzZP2zPmNED+XH5KQcVqRHcjPky18DzS/G5To++1Wc7fPqPFJ9PKT5CqM0kHR9+4LUlS/TbWd8cZpcUfJztYKWROiDLoIgeSrgZ2ECVziZFs9pKLlsLvpagHfuOY9xMafOcM8FnRlXt/WuAwSeNKsyE9InuJZY0cgrvP7OIx5wSTFakM+kcosq2CFj881V3d8QhlgFW8mLYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=FyTiCMbHPGbdcn3KR66izasD+q0zjvK111XDCIfzn9c=; b=IDyg4Yvja9FLL2LL9d465VswcXz/BbovEJ59GFxaUdEuux0j5uRbYp4qXVX17EmoM6rVTY//5NzI9S5xjyrQlo7R2SO5H4DIiaIJ0HndfL/7Vgr783GBV+cj5mTgD6u4mfnP5bqSvBC6Bp9OY53tZBV91VXRyBP+e0vmkDhTXTQauvbm4j1hDCYlNruN6KYmR0wR3D8OQOLvDO+LRR5W6u92II0ZsB95pGI7OzAZL0GjtUIzDQgFM4doni48dph7vWOvwvGYadG/5cN5VCF+KqmBaqd0ZgJ7jnwIxA0jBGFCgJbu2bpTyB2khzpPUsQ/fh3PVWa5qsLuJAryS6Yliw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FyTiCMbHPGbdcn3KR66izasD+q0zjvK111XDCIfzn9c=; b=AhzLTv6mqLZY7tBUF+UXRd5rb0AUfxcraDBQGxKw6IqxJYghEG4GsJQ7i3XPP/3h5VVb2Gevz76ynrIbt7WLL8IRZLBxVKuXNLV4EwKfmuum+j6ckYBZg2gDPqfyNrTNq3s1Sx0TSuwuwtCgs+3atcSOUvlfXLn/tTJXPLIqTCU= Received: from DU2PR04MB8726.eurprd04.prod.outlook.com (2603:10a6:10:2dd::9) by DU2PR04MB8613.eurprd04.prod.outlook.com (2603:10a6:10:2d8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Fri, 24 Sep 2021 08:36:45 +0000 Received: from DU2PR04MB8726.eurprd04.prod.outlook.com ([fe80::c4c0:dc25:bf03:589c]) by DU2PR04MB8726.eurprd04.prod.outlook.com ([fe80::c4c0:dc25:bf03:589c%5]) with mapi id 15.20.4544.018; Fri, 24 Sep 2021 08:36:45 +0000 From: "Wasim Khan (OSS)" To: Tom Rini , "Wasim Khan (OSS)" CC: Priyanka Jain , Varun Sethi , "u-boot@lists.denx.de" Subject: RE: [PATCH] board/freescale/vid : move platform specific definitions Thread-Topic: [PATCH] board/freescale/vid : move platform specific definitions Thread-Index: AQHXrvR7XwLKWn3PyE6mM408Ap8C7quukESAgARHe4A= Date: Fri, 24 Sep 2021 08:36:45 +0000 Message-ID: References: <20210921142457.3485758-1-wasim.khan@oss.nxp.com> <20210921144349.GF8579@bill-the-cat> In-Reply-To: <20210921144349.GF8579@bill-the-cat> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: konsulko.com; dkim=none (message not signed) header.d=none;konsulko.com; dmarc=none action=none header.from=oss.nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 68250028-3e57-4f84-a146-08d97f36716e x-ms-traffictypediagnostic: DU2PR04MB8613: x-ms-exchange-sharedmailbox-routingagent-processed: True x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GcwPJNrRom7hvBudMMDIJcEU2hfjrVTwT0Mm6S4Ij3PKYsfo/+NNEcKNu8zNsHWOXdjEsEAHYy0jnZfUBvJjXJCNCtwBlknoHOjby8ntT6Wsy8W9UCRsfu2p2Mzk48yFBfFKvTujoMml1v/ZQKqXxrypL4SXUKugJXhW40Q8tBVQr1wx04QbiCJdpnBZAUkTylZQkgBIiVN5Ogdt9KKiZweV77NjqR+zRT+gwjQ2b6lS0N72z46oHhN8A4Bdtq2uB+sYYG5Wx4dPN7Ynh5YqgO2kdV4Fr6stzFssNbXmvsGKXEorRfbXQGgZNpNVGK7lVPetalHhcHjmj0+ET8ElPwla0AzkLczLZBoCeU1kVmMz0+V0t2GMCOVGPDSjIjWuLz3sdp9ZxVRIou4HjGI5a1VEJO56ItWqE6YakBTffbFoDsRhYD1JMOgGyzZJVBp5GhyAKt/OteowZ/zvkez+utj5hWmjGPgrVbRThwD22XmSCSoDBfMTX7G/PD2BQCofXJkODSvTsBUTl2g5n4nHLI+k3XJYqBL7IkKznIOGisJfxY0R7YQiQcR6asZrsvIaaSUsiZRgLoePmN+FDM62IJ+lZi+TIEiXtRd1Bgz369CmImzOQwXDQ/6KYlQBHm67/W1Wv8gmsBhkgbRsqUfRdOYll9+FR3kymjAkK22pYQrRItSi83EdsmyLV4SCUH6ub0OIBSqrRIzlw7wYaoyXcQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8726.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(38100700002)(66946007)(5660300002)(122000001)(66556008)(316002)(66446008)(54906003)(110136005)(52536014)(76116006)(64756008)(66476007)(2906002)(8936002)(26005)(86362001)(4326008)(186003)(8676002)(9686003)(33656002)(55016002)(38070700005)(7696005)(508600001)(53546011)(83380400001)(71200400001)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wuxC1nTWY/enYb52Bpf4jikO9IyXNQOGmqPI4N67f3ks2qSISXFZX9nHYVbg?= =?us-ascii?Q?WJqgArIpzL45bc3kNXKZyxQ9kOdQdxmYhpfovSxnZ+NPuZaeVMmsUxRKJFDA?= =?us-ascii?Q?AjfFGMK5TSf8j6bawR3XEgbXIVye+RpkF6j/ezb3KL8bcmYF4/GxatkuMrnO?= =?us-ascii?Q?4aYvqP8VSmLdmAdVVnrnRcLCK+xb/KbwZ8GnBNAtuClJoANzsomW9iPtKCrB?= =?us-ascii?Q?7FDBjm6Tl36kYpE2wHOS83smym2W1u2UYMuIFn2p/QM4q5bYoCaTYWph7Not?= =?us-ascii?Q?xmrlgoc/k4P1d5w1ni2xJrFnx5xyLyJkWvKjsynJQKAUubgWOMDOudOZJJL6?= =?us-ascii?Q?7nZObr10QXv9skSXADIUXF/JAlCtFFcBB6l73PoNm17kazkI5LjvBzwLAVxn?= =?us-ascii?Q?pTOuprGMpg5QfSogs54rMUc0OqYqv5lApz0tBIBH5ic3hnZyigrENFtDF53s?= =?us-ascii?Q?bry3kfUh1p6J0KWacelW+RMZNKKkCVZOS/fSWCxPSH1UGBM/s76yWL4HwAF2?= =?us-ascii?Q?IzGskUkVk1lr1p6R2R2a/nzV4i6iY35U8GX5SwZCcvFTRvTq6e6ypq4QLR8m?= =?us-ascii?Q?Ab+qfrA9Rif52udjjhbD2eWft0/sITx5tqXQEN+g/xDx3i8G27JSDSGYDOJc?= =?us-ascii?Q?d5Ocin6G6MK6tRx4kqs3RNWOzncq7fl9UsFvdPpnDdGTvYEszyuitHSD3A5t?= =?us-ascii?Q?g4e3cWmQ2l6jeFSiEuT3G23kS4RL99hinblcvzZjVT9kELlMXB5u6XzcvnwR?= =?us-ascii?Q?7YrTTi+0Qb+84NVa2OUqEjtlBuCe/6rHCkWDvO63WMMfFb2typ0mR3Za1vli?= =?us-ascii?Q?4kgqC0Fz+EWX5lv1iXyI3uEVebVqfH/f6JuKhvXik+oarGj4a/VfmrhFdPoZ?= =?us-ascii?Q?7gMhI/nixshISoErieeIXsjhioLeE5D3SVoKF70vrV+UCVLh8CGzWb4TtSWD?= =?us-ascii?Q?AOuu6dYqat2b4rb9CiQk0b+Hg2rtpq9fsu0QjhSV/42eOIs+f0ZQyHWCkSuH?= =?us-ascii?Q?rOmpyYakshUxVXLeiQ1YhvqyDNdwg4IC4cet5sioCK6U0V9F4Q4YFH695cY5?= =?us-ascii?Q?8u/DWSKZ4lvtMPyUmnSxP4JhK5oUQKmZANfTv2M21mMfQNXR7IWTAGH9xEtQ?= =?us-ascii?Q?OWEMIrX/lAQ2iZa+H3GAfcmLBJUPxPKMehMHzH0Ovbxkp88X8Q4idM8IR0+i?= =?us-ascii?Q?AqJKo8UeSZyRM1GSCgmqQtdQyEfZHCw7ldX4Oau3b3wJitQ2OAJvehLOYWrc?= =?us-ascii?Q?MohxeIQCrC4PGtlR2zPyA1pRz12FUMQ18RDFP1Pa7Hwnm/KdcrkxQYem2v18?= =?us-ascii?Q?kfS2y/s79wKtWa3fOb/OS7mN?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8726.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68250028-3e57-4f84-a146-08d97f36716e X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Sep 2021 08:36:45.6508 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4EMvlRyl9CASnApINa9j3POHOtgVGjXtjql43J9H7nxRKb0tjDw0dFqug41Fj3Z+O1mA6ifUZl3M+67uBLmrpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8613 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Tom, > -----Original Message----- > From: Tom Rini > Sent: Tuesday, September 21, 2021 8:14 PM > To: Wasim Khan (OSS) > Cc: Priyanka Jain ; Varun Sethi ;= u- > boot@lists.denx.de; Wasim Khan > Subject: Re: [PATCH] board/freescale/vid : move platform specific definit= ions >=20 > On Tue, Sep 21, 2021 at 04:24:57PM +0200, Wasim Khan wrote: >=20 > > From: Wasim Khan > > > > VID is a common driver. Move platform specific definitions to platform > > specific header files > > > > Signed-off-by: Wasim Khan > > --- > > board/freescale/common/vid.h | 10 ---------- > > include/configs/lx2160a_common.h | 7 +++++++ > > 2 files changed, 7 insertions(+), 10 deletions(-) >=20 > NAK. Things need to move out of include/configs/ and not in to them, ple= ase > find another common header file to use. >=20 > -- > Tom Thank you so much for review. Header files 'include/configs/' are auto picked for platform we are using.= =20 I find it useful especially for common drivers like VID to auto pick requir= ed values for underneath platform from 'include/configs/.h' and we don't need changes in common driver. (arch/Kconfig) config SYS_CONFIG_NAME string help This option should contain the base name of board header file. The header file include/configs/.h should be included from include/config.h. (Same is recommended for add/remove boards: doc/README.kconfig) Define CONFIG_SYS_CONFIG_NAME=3D"target" to include include/configs/.h Currently all NXP platforms (except LX2 series) are using CONFIG_SYS_CONFIG= _NAME to include platform specific header file for VID driver. I extended t= he support for LX2 and because the changes are common for lx2160ardb, lx216= 0aqds and lx2162aqds , I added them to lx2160a_common.h.=20 Do you want me to move changes from ' include/configs/lx2160a_common.h' to = ' include/configs/lx2160ardb.h', ' include/configs/lx2160aqds.h' and ' inc= lude/configs/lx2162aqds.h' ? =20 Or you want me to avoid adding anything to 'include/configs/.h ' files ? Is there any reason to do so ?