From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41491C61DA4 for ; Mon, 6 Feb 2023 14:44:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0EF0485B13; Mon, 6 Feb 2023 15:44:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="XugfTzPY"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E336C85BF0; Mon, 6 Feb 2023 15:44:39 +0100 (CET) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D8BD385B13 for ; Mon, 6 Feb 2023 15:44:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2c.google.com with SMTP id q10so7148023qvt.10 for ; Mon, 06 Feb 2023 06:44:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GiVb3+BetYRzlYvxXE4pqzL7Sww6bmTVjTa/7D6XHsM=; b=XugfTzPYF9tA49FLeD4ORW1GEQA3Fcr6IZWve38JRHMp1tvFWdktxIbFSIWhpqs96f JfooZhCbGVFK+YgZdYJUi70fQC5wPLjjmLyj1nzxg0ucPNWxos69reGEgrawkisIeBnL GAd/x0teZVlnAmPSANrLoWZDzwtjG4sj6PHpI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GiVb3+BetYRzlYvxXE4pqzL7Sww6bmTVjTa/7D6XHsM=; b=J5zHWbSWzYaoiGAew2mM5zrxIBA7X88rc8JTEUBkOoLdC69onu2w0NLFvIq1BP2g+3 4QGbeW1l7qdf864JV5C1FDunqj1AlhOiPDfKKT3/JcR+wO+IegiEEfsKP258RwamRJfc 6omn03MP+6j+m0cSI+ujXIC0XZYnBP1ZbjcimfljDUjivD3z8uUy486kVhsxcMxitqLF lYpZGZdzioJFps/riT0+UReiSJWW7BCtudLSKxuDU9MpUSR7wZuBmduGQW4ivzUQy6Jx VtntBljQwZ95X6sBQigFc71V2qX5J/JiMhboCoZEXhgdvNuXIyQz/wJfozCLZfOimQXa TbTA== X-Gm-Message-State: AO0yUKXvRzVdRtgYs3CkfahUrHvp4iUZ8RxSQXPvJbrUbKVG3/Aa1bD2 R2LSaMBhVKQtIQ0Ma8THujGBvg== X-Google-Smtp-Source: AK7set+CE1VqDLIpWUl6T5Dmj8o6lQFC2zmaXshr6SIDfb9SjaH3xwAgri2nhvHWnGv+cNdeEFkoAg== X-Received: by 2002:a0c:e6a7:0:b0:538:baf2:3ca7 with SMTP id j7-20020a0ce6a7000000b00538baf23ca7mr25674154qvn.2.1675694675519; Mon, 06 Feb 2023 06:44:35 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-7624-7f8a-2088-981c.res6.spectrum.com. [2603:6081:7b00:6400:7624:7f8a:2088:981c]) by smtp.gmail.com with ESMTPSA id bq34-20020a05620a46a200b006cbc00db595sm7566247qkb.23.2023.02.06.06.44.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Feb 2023 06:44:35 -0800 (PST) Date: Mon, 6 Feb 2023 09:44:33 -0500 From: Tom Rini To: Michal Simek Cc: Simon Glass , u-boot@lists.denx.de, U-Boot Custodians Subject: Re: [PATCH v3 6/8] dm: treewide: Complete migration to new driver model schema Message-ID: References: <20230201225428.2001161-1-sjg@chromium.org> <20230201225428.2001161-7-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EHyePlHO6PJwNqvv" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --EHyePlHO6PJwNqvv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 06, 2023 at 01:22:48PM +0100, Michal Simek wrote: > Hi Simon, >=20 > On 2/1/23 23:54, Simon Glass wrote: > > Update various build and test components to use the new schema. > >=20 > > Signed-off-by: Simon Glass > > --- > >=20 > > (no changes since v1) > >=20 > > drivers/core/ofnode.c | 10 +++++----- > > drivers/video/video-uclass.c | 4 ++-- > > dts/Kconfig | 2 +- > > include/dm/device.h | 2 +- > > include/dm/ofnode.h | 10 +++++----- > > scripts/Makefile.lib | 12 ++++++------ > > test/dm/test-fdt.c | 2 +- > > test/py/tests/test_ofplatdata.py | 8 ++++---- > > tools/binman/binman.rst | 3 +-- > > tools/dtoc/test_fdt.py | 8 ++++---- > > 10 files changed, 30 insertions(+), 31 deletions(-) > >=20 > > diff --git a/drivers/core/ofnode.c b/drivers/core/ofnode.c > > index 4d56b1a7675..5249a60639b 100644 > > --- a/drivers/core/ofnode.c > > +++ b/drivers/core/ofnode.c > > @@ -1265,22 +1265,22 @@ bool ofnode_pre_reloc(ofnode node) > > { > > #if defined(CONFIG_SPL_BUILD) || defined(CONFIG_TPL_BUILD) > > /* for SPL and TPL the remaining nodes after the fdtgrep 1st pass > > - * had property dm-pre-reloc or u-boot,dm-spl/tpl. > > + * had property bootph-all or bootph-pre-sram/bootph-pre-ram. > > * They are removed in final dtb (fdtgrep 2nd pass) > > */ > > return true; > > #else > > - if (ofnode_read_bool(node, "u-boot,dm-pre-reloc")) > > + if (ofnode_read_bool(node, "bootph-all")) > > return true; > > - if (ofnode_read_bool(node, "u-boot,dm-pre-proper")) > > + if (ofnode_read_bool(node, "bootph-some-ram")) > > return true; > > /* > > * In regular builds individual spl and tpl handling both > > * count as handled pre-relocation for later second init. > > */ > > - if (ofnode_read_bool(node, "u-boot,dm-spl") || > > - ofnode_read_bool(node, "u-boot,dm-tpl")) > > + if (ofnode_read_bool(node, "bootph-pre-ram") || > > + ofnode_read_bool(node, "bootph-pre-sram")) > > return true; >=20 > Please correct me if I am wrong but this change will likely break all boa= rds > which didn't migrate to this at this stage. And because targeting early > stages people will be without console. > I think we should have transition period for 1-2 releases to give people > enough time to migrate. It means print big warning that they have to migr= ate > their DTS. What's the migration case here we're missing? Is it platforms that maintain a dts externally, via tooling / etc, that populate those nodes? --=20 Tom --EHyePlHO6PJwNqvv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPhEkUACgkQFHw5/5Y0 tyxbkAv9FNl50+QUilqJu7/+7S/RxcQhptK4LDyrH97jFxQtav1xJBzpIhRFhQog oJykrlpe6td3K/wWDJHvgqHc1BMTMHiDHYk4OiGLL2Ge8Qw9F2FDvq5qjB0dL6iv jphtJutYCukzqqhEGKvEtC62U1SRpPcr8gYyhbGX199cxFLs1VaQP4G1qO0QHYEw Y2H22LfAy8RSKkvuXG7ghf/oXAzb1+LuGb4I6MSnEq6M9RcGZRwRbsHMpz60EsJb cCLPmnrzhvCYJYfGb7RmIaGUlYaBk4oNe9WWpxqKJGTHUyWl0s4a+tRNaPaDiTxT Hi5v509BoFi4X+rlMXciqfzyWsCReerkO/r2bhLaIS0ZMba2q6S1cuQHAB6itBHw bTNUmK553Vds9Vc2vJHVYcYBJ65yerz+vYbpvVlgHpNQl1cTlaoBxV6IlklHHW15 IjXglOZ537yAVimeAX+yxZP9sCQbYhBpb7gQWx7Ll2m+00wXTh5xw/Y8Xy9cS/Ch 4yOP8xOj =31kK -----END PGP SIGNATURE----- --EHyePlHO6PJwNqvv--